Title: [136593] trunk/Tools
- Revision
- 136593
- Author
- [email protected]
- Date
- 2012-12-04 16:43:13 -0800 (Tue, 04 Dec 2012)
Log Message
nrwt: fix total number of tests computed in the result summary
https://bugs.webkit.org/show_bug.cgi?id=104061
Unreviewed, build fix.
One of the recent changes to the resultsummary refactoring caused
us to not include the number of skipped tests in the total number
of tests, throwing off the totals printed in print_one_line_summary().
Unfortunately, given the current state of the code it is difficult
to construct an accurate unit test for this. I have verified the
fix by hand, and will write a test once the remaining refactoring
patches land, at which point it will be trivial to test it.
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._prepare_lists):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (136592 => 136593)
--- trunk/Tools/ChangeLog 2012-12-05 00:36:59 UTC (rev 136592)
+++ trunk/Tools/ChangeLog 2012-12-05 00:43:13 UTC (rev 136593)
@@ -1,5 +1,24 @@
2012-12-04 Dirk Pranke <[email protected]>
+ nrwt: fix total number of tests computed in the result summary
+ https://bugs.webkit.org/show_bug.cgi?id=104061
+
+ Unreviewed, build fix.
+
+ One of the recent changes to the resultsummary refactoring caused
+ us to not include the number of skipped tests in the total number
+ of tests, throwing off the totals printed in print_one_line_summary().
+
+ Unfortunately, given the current state of the code it is difficult
+ to construct an accurate unit test for this. I have verified the
+ fix by hand, and will write a test once the remaining refactoring
+ patches land, at which point it will be trivial to test it.
+
+ * Scripts/webkitpy/layout_tests/controllers/manager.py:
+ (Manager._prepare_lists):
+
+2012-12-04 Dirk Pranke <[email protected]>
+
nrwt is not returning the exit status properly
https://bugs.webkit.org/show_bug.cgi?id=103830
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py (136592 => 136593)
--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2012-12-05 00:36:59 UTC (rev 136592)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2012-12-05 00:43:13 UTC (rev 136593)
@@ -315,7 +315,7 @@
self._expectations.add_skipped_tests(tests_in_other_chunks)
tests_to_skip.update(tests_in_other_chunks)
- summary = ResultSummary(self._expectations, len(tests_to_run) * self._options.repeat_each * self._options.iterations)
+ summary = ResultSummary(self._expectations, len(tests_to_run) * self._options.repeat_each * self._options.iterations + len(tests_to_skip))
for test_name in set(tests_to_skip):
result = test_results.TestResult(test_name)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
