Title: [136626] trunk/Source/WebCore
- Revision
- 136626
- Author
- [email protected]
- Date
- 2012-12-04 20:35:19 -0800 (Tue, 04 Dec 2012)
Log Message
Static code analysis warning fixes
https://bugs.webkit.org/show_bug.cgi?id=103837
Patch by Anthony Scian <[email protected]> on 2012-12-04
Reviewed by Rob Buis.
172,174: disable copy ctor, op= in AutofillBackingStore
504,506: disable copy ctor, op= in CookieManager
1488,1491: disable copy ctor, op= in RSSParserBase
1489,1490: disable copy ctor, op= in RSSItem
514,516: disable copy ctor, op= in CredentialBackingStore
1363: m_state not initialized in ctor
* platform/blackberry/CookieManager.h:
* platform/blackberry/PlatformTouchPointBlackBerry.cpp:
(WebCore::PlatformTouchPoint::PlatformTouchPoint):
* platform/network/blackberry/AutofillBackingStore.h:
(AutofillBackingStore):
* platform/network/blackberry/CredentialBackingStore.h:
(CredentialBackingStore):
* platform/network/blackberry/rss/RSSParserBase.h:
(RSSParserBase):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (136625 => 136626)
--- trunk/Source/WebCore/ChangeLog 2012-12-05 04:33:22 UTC (rev 136625)
+++ trunk/Source/WebCore/ChangeLog 2012-12-05 04:35:19 UTC (rev 136626)
@@ -1,3 +1,27 @@
+2012-12-04 Anthony Scian <[email protected]>
+
+ Static code analysis warning fixes
+ https://bugs.webkit.org/show_bug.cgi?id=103837
+
+ Reviewed by Rob Buis.
+
+ 172,174: disable copy ctor, op= in AutofillBackingStore
+ 504,506: disable copy ctor, op= in CookieManager
+ 1488,1491: disable copy ctor, op= in RSSParserBase
+ 1489,1490: disable copy ctor, op= in RSSItem
+ 514,516: disable copy ctor, op= in CredentialBackingStore
+ 1363: m_state not initialized in ctor
+
+ * platform/blackberry/CookieManager.h:
+ * platform/blackberry/PlatformTouchPointBlackBerry.cpp:
+ (WebCore::PlatformTouchPoint::PlatformTouchPoint):
+ * platform/network/blackberry/AutofillBackingStore.h:
+ (AutofillBackingStore):
+ * platform/network/blackberry/CredentialBackingStore.h:
+ (CredentialBackingStore):
+ * platform/network/blackberry/rss/RSSParserBase.h:
+ (RSSParserBase):
+
2012-12-04 Noel Gordon <[email protected]>
[v8] Improve worker.postMessage() string performance: avoid utf8 conversion
Modified: trunk/Source/WebCore/platform/blackberry/CookieManager.h (136625 => 136626)
--- trunk/Source/WebCore/platform/blackberry/CookieManager.h 2012-12-05 04:33:22 UTC (rev 136625)
+++ trunk/Source/WebCore/platform/blackberry/CookieManager.h 2012-12-05 04:35:19 UTC (rev 136626)
@@ -136,6 +136,7 @@
CookieDatabaseBackingStore* m_cookieBackingStore;
Timer<CookieManager> m_limitTimer;
+ DISABLE_COPY(CookieManager)
};
// Get the global instance.
Modified: trunk/Source/WebCore/platform/blackberry/PlatformTouchPointBlackBerry.cpp (136625 => 136626)
--- trunk/Source/WebCore/platform/blackberry/PlatformTouchPointBlackBerry.cpp 2012-12-05 04:33:22 UTC (rev 136625)
+++ trunk/Source/WebCore/platform/blackberry/PlatformTouchPointBlackBerry.cpp 2012-12-05 04:35:19 UTC (rev 136626)
@@ -21,6 +21,7 @@
#include "config.h"
#include "PlatformTouchPoint.h"
+#include <BlackBerryPlatformAssert.h>
#include <BlackBerryPlatformTouchEvent.h>
#if ENABLE(TOUCH_EVENTS)
@@ -45,6 +46,10 @@
case BlackBerry::Platform::TouchPoint::TouchStationary:
m_state = TouchStationary;
break;
+ default:
+ m_state = TouchStationary; // make sure m_state is initialized
+ BLACKBERRY_ASSERT(false);
+ break;
}
}
Modified: trunk/Source/WebCore/platform/network/blackberry/AutofillBackingStore.h (136625 => 136626)
--- trunk/Source/WebCore/platform/network/blackberry/AutofillBackingStore.h 2012-12-05 04:33:22 UTC (rev 136625)
+++ trunk/Source/WebCore/platform/network/blackberry/AutofillBackingStore.h 2012-12-05 04:35:19 UTC (rev 136626)
@@ -21,6 +21,8 @@
#include "SQLiteDatabase.h"
+#include <BlackBerryPlatformMisc.h>
+
namespace WebCore {
class AutofillBackingStore {
@@ -43,6 +45,8 @@
SQLiteStatement* m_updateStatement;
SQLiteStatement* m_containsStatement;
SQLiteStatement* m_getStatement;
+
+ DISABLE_COPY(AutofillBackingStore)
};
AutofillBackingStore& autofillBackingStore();
Modified: trunk/Source/WebCore/platform/network/blackberry/CredentialBackingStore.h (136625 => 136626)
--- trunk/Source/WebCore/platform/network/blackberry/CredentialBackingStore.h 2012-12-05 04:33:22 UTC (rev 136625)
+++ trunk/Source/WebCore/platform/network/blackberry/CredentialBackingStore.h 2012-12-05 04:35:19 UTC (rev 136626)
@@ -24,6 +24,8 @@
#include "Credential.h"
#include "SQLiteDatabase.h"
+#include <BlackBerryPlatformMisc.h>
+
namespace BlackBerry {
namespace Platform {
class CertMgrWrapper;
@@ -74,6 +76,8 @@
SQLiteStatement* m_removeNeverRememberStatement;
BlackBerry::Platform::CertMgrWrapper* m_certMgrWrapper;
+
+ DISABLE_COPY(CredentialBackingStore)
};
CredentialBackingStore& credentialBackingStore();
Modified: trunk/Source/WebCore/platform/network/blackberry/rss/RSSParserBase.h (136625 => 136626)
--- trunk/Source/WebCore/platform/network/blackberry/rss/RSSParserBase.h 2012-12-05 04:33:22 UTC (rev 136625)
+++ trunk/Source/WebCore/platform/network/blackberry/rss/RSSParserBase.h 2012-12-05 04:35:19 UTC (rev 136626)
@@ -20,6 +20,7 @@
#ifndef RSSParserBase_h
#define RSSParserBase_h
+#include <BlackBerryPlatformMisc.h>
#include <libxml/tree.h>
#include <wtf/Vector.h>
#include <wtf/text/WTFString.h>
@@ -86,6 +87,8 @@
String m_comments;
Vector<String> m_categories;
RSSEnclosure* m_enclosure;
+private:
+ DISABLE_COPY(RSSItem)
};
class RSSParserBase {
@@ -96,6 +99,8 @@
virtual bool parseBuffer(const char* buffer, int length, const char* url, const char* encoding) = 0;
RSSFeed* m_root;
+private:
+ DISABLE_COPY(RSSParserBase)
};
String textFromXMLAttr(xmlAttr*);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
