Title: [136632] trunk/Source/WebCore
Revision
136632
Author
[email protected]
Date
2012-12-04 21:02:21 -0800 (Tue, 04 Dec 2012)

Log Message

[V8] Replace v8::Null(isolate) with v8Null(isolate)
https://bugs.webkit.org/show_bug.cgi?id=104070

Reviewed by Adam Barth.

v8Null(isolate) is a faster version of v8::Null(isolate).

No tests. No change in behavior.

* bindings/v8/V8Binding.h:
(WebCore::v8StringOrNull):
* bindings/v8/custom/V8ClipboardCustom.cpp:
(WebCore::V8Clipboard::typesAccessorGetter):
* bindings/v8/custom/V8CoordinatesCustom.cpp:
(WebCore::V8Coordinates::altitudeAccessorGetter):
(WebCore::V8Coordinates::altitudeAccuracyAccessorGetter):
(WebCore::V8Coordinates::headingAccessorGetter):
(WebCore::V8Coordinates::speedAccessorGetter):
* bindings/v8/custom/V8DeviceMotionEventCustom.cpp:
(WebCore::V8DeviceMotionEvent::accelerationAccessorGetter):
(WebCore::V8DeviceMotionEvent::accelerationIncludingGravityAccessorGetter):
(WebCore::V8DeviceMotionEvent::rotationRateAccessorGetter):
(WebCore::V8DeviceMotionEvent::intervalAccessorGetter):
* bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:
(WebCore::V8DeviceOrientationEvent::alphaAccessorGetter):
(WebCore::V8DeviceOrientationEvent::betaAccessorGetter):
(WebCore::V8DeviceOrientationEvent::gammaAccessorGetter):
(WebCore::V8DeviceOrientationEvent::absoluteAccessorGetter):
* bindings/v8/custom/V8DocumentLocationCustom.cpp:
(WebCore::V8Document::locationAccessorGetter):
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::getContextCallback):
* bindings/v8/custom/V8HistoryCustom.cpp:
(WebCore::V8History::stateAccessorGetter):
* bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAccessorGetter):
* bindings/v8/custom/V8MicroDataItemValueCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::V8Node::insertBeforeCallback):
(WebCore::V8Node::replaceChildCallback):
(WebCore::V8Node::removeChildCallback):
(WebCore::V8Node::appendChildCallback):
* bindings/v8/custom/V8PopStateEventCustom.cpp:
(WebCore::V8PopStateEvent::stateAccessorGetter):
* bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
(WebCore::V8SQLResultSetRowList::itemCallback):
* bindings/v8/custom/V8TrackEventCustom.cpp:
(WebCore::V8TrackEvent::trackAccessorGetter):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getSupportedExtensionsCallback):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (136631 => 136632)


--- trunk/Source/WebCore/ChangeLog	2012-12-05 04:55:38 UTC (rev 136631)
+++ trunk/Source/WebCore/ChangeLog	2012-12-05 05:02:21 UTC (rev 136632)
@@ -1,3 +1,59 @@
+2012-12-04  Kentaro Hara  <[email protected]>
+
+        [V8] Replace v8::Null(isolate) with v8Null(isolate)
+        https://bugs.webkit.org/show_bug.cgi?id=104070
+
+        Reviewed by Adam Barth.
+
+        v8Null(isolate) is a faster version of v8::Null(isolate).
+
+        No tests. No change in behavior.
+
+        * bindings/v8/V8Binding.h:
+        (WebCore::v8StringOrNull):
+        * bindings/v8/custom/V8ClipboardCustom.cpp:
+        (WebCore::V8Clipboard::typesAccessorGetter):
+        * bindings/v8/custom/V8CoordinatesCustom.cpp:
+        (WebCore::V8Coordinates::altitudeAccessorGetter):
+        (WebCore::V8Coordinates::altitudeAccuracyAccessorGetter):
+        (WebCore::V8Coordinates::headingAccessorGetter):
+        (WebCore::V8Coordinates::speedAccessorGetter):
+        * bindings/v8/custom/V8DeviceMotionEventCustom.cpp:
+        (WebCore::V8DeviceMotionEvent::accelerationAccessorGetter):
+        (WebCore::V8DeviceMotionEvent::accelerationIncludingGravityAccessorGetter):
+        (WebCore::V8DeviceMotionEvent::rotationRateAccessorGetter):
+        (WebCore::V8DeviceMotionEvent::intervalAccessorGetter):
+        * bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:
+        (WebCore::V8DeviceOrientationEvent::alphaAccessorGetter):
+        (WebCore::V8DeviceOrientationEvent::betaAccessorGetter):
+        (WebCore::V8DeviceOrientationEvent::gammaAccessorGetter):
+        (WebCore::V8DeviceOrientationEvent::absoluteAccessorGetter):
+        * bindings/v8/custom/V8DocumentLocationCustom.cpp:
+        (WebCore::V8Document::locationAccessorGetter):
+        * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
+        (WebCore::V8HTMLCanvasElement::getContextCallback):
+        * bindings/v8/custom/V8HistoryCustom.cpp:
+        (WebCore::V8History::stateAccessorGetter):
+        * bindings/v8/custom/V8MessageEventCustom.cpp:
+        (WebCore::V8MessageEvent::dataAccessorGetter):
+        * bindings/v8/custom/V8MicroDataItemValueCustom.cpp:
+        (WebCore::toV8):
+        * bindings/v8/custom/V8NodeCustom.cpp:
+        (WebCore::V8Node::insertBeforeCallback):
+        (WebCore::V8Node::replaceChildCallback):
+        (WebCore::V8Node::removeChildCallback):
+        (WebCore::V8Node::appendChildCallback):
+        * bindings/v8/custom/V8PopStateEventCustom.cpp:
+        (WebCore::V8PopStateEvent::stateAccessorGetter):
+        * bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
+        (WebCore::V8SQLResultSetRowList::itemCallback):
+        * bindings/v8/custom/V8TrackEventCustom.cpp:
+        (WebCore::V8TrackEvent::trackAccessorGetter):
+        * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
+        (WebCore::toV8Object):
+        (WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
+        (WebCore::V8WebGLRenderingContext::getSupportedExtensionsCallback):
+
 2012-12-04  Min Qin  <[email protected]>
 
         Make LazyDecodingPixelRef inherit from skia::LazyPixelRef so that cc thread can access it

Modified: trunk/Source/WebCore/bindings/v8/V8Binding.h (136631 => 136632)


--- trunk/Source/WebCore/bindings/v8/V8Binding.h	2012-12-05 04:55:38 UTC (rev 136631)
+++ trunk/Source/WebCore/bindings/v8/V8Binding.h	2012-12-05 05:02:21 UTC (rev 136632)
@@ -157,7 +157,7 @@
 
     inline v8::Handle<v8::Value> v8StringOrNull(const String& str, v8::Isolate* isolate = 0)
     {
-        return str.isNull() ? v8::Handle<v8::Value>(v8::Null()) : v8::Handle<v8::Value>(v8String(str, isolate));
+        return str.isNull() ? v8::Handle<v8::Value>(v8NullWithCheck(isolate)) : v8::Handle<v8::Value>(v8String(str, isolate));
     }
 
     inline v8::Handle<v8::Value> v8StringOrUndefined(const String& str, v8::Isolate* isolate = 0)

Modified: trunk/Source/WebCore/bindings/v8/custom/V8ClipboardCustom.cpp (136631 => 136632)


--- trunk/Source/WebCore/bindings/v8/custom/V8ClipboardCustom.cpp	2012-12-05 04:55:38 UTC (rev 136631)
+++ trunk/Source/WebCore/bindings/v8/custom/V8ClipboardCustom.cpp	2012-12-05 05:02:21 UTC (rev 136632)
@@ -50,7 +50,7 @@
 
     ListHashSet<String> types = clipboard->types();
     if (types.isEmpty())
-        return v8::Null(info.GetIsolate());
+        return v8Null(info.GetIsolate());
 
     v8::Local<v8::Array> result = v8::Array::New(types.size());
     ListHashSet<String>::const_iterator end = types.end();

Modified: trunk/Source/WebCore/bindings/v8/custom/V8CoordinatesCustom.cpp (136631 => 136632)


--- trunk/Source/WebCore/bindings/v8/custom/V8CoordinatesCustom.cpp	2012-12-05 04:55:38 UTC (rev 136631)
+++ trunk/Source/WebCore/bindings/v8/custom/V8CoordinatesCustom.cpp	2012-12-05 05:02:21 UTC (rev 136632)
@@ -37,7 +37,7 @@
     v8::Handle<v8::Object> holder = info.Holder();
     Coordinates* imp = V8Coordinates::toNative(holder);
     if (!imp->canProvideAltitude())
-        return v8::Null(info.GetIsolate());
+        return v8Null(info.GetIsolate());
     return v8::Number::New(imp->altitude());
 }
 
@@ -47,7 +47,7 @@
     v8::Handle<v8::Object> holder = info.Holder();
     Coordinates* imp = V8Coordinates::toNative(holder);
     if (!imp->canProvideAltitudeAccuracy())
-        return v8::Null(info.GetIsolate());
+        return v8Null(info.GetIsolate());
     return v8::Number::New(imp->altitudeAccuracy());
 }
 
@@ -57,7 +57,7 @@
     v8::Handle<v8::Object> holder = info.Holder();
     Coordinates* imp = V8Coordinates::toNative(holder);
     if (!imp->canProvideHeading())
-        return v8::Null(info.GetIsolate());
+        return v8Null(info.GetIsolate());
     return v8::Number::New(imp->heading());
 }
 
@@ -67,7 +67,7 @@
     v8::Handle<v8::Object> holder = info.Holder();
     Coordinates* imp = V8Coordinates::toNative(holder);
     if (!imp->canProvideSpeed())
-        return v8::Null(info.GetIsolate());
+        return v8Null(info.GetIsolate());
     return v8::Number::New(imp->speed());
 }
 

Modified: trunk/Source/WebCore/bindings/v8/custom/V8DeviceMotionEventCustom.cpp (136631 => 136632)


--- trunk/Source/WebCore/bindings/v8/custom/V8DeviceMotionEventCustom.cpp	2012-12-05 04:55:38 UTC (rev 136631)
+++ trunk/Source/WebCore/bindings/v8/custom/V8DeviceMotionEventCustom.cpp	2012-12-05 05:02:21 UTC (rev 136632)
@@ -40,18 +40,18 @@
 static v8::Handle<v8::Value> createAccelerationObject(const DeviceMotionData::Acceleration* acceleration, v8::Isolate* isolate)
 {
     v8::Local<v8::Object> object = v8::Object::New();
-    object->Set(v8::String::NewSymbol("x"), acceleration->canProvideX() ? v8::Number::New(acceleration->x()) : v8::Null(isolate));
-    object->Set(v8::String::NewSymbol("y"), acceleration->canProvideY() ? v8::Number::New(acceleration->y()) : v8::Null(isolate));
-    object->Set(v8::String::NewSymbol("z"), acceleration->canProvideZ() ? v8::Number::New(acceleration->z()) : v8::Null(isolate));
+    object->Set(v8::String::NewSymbol("x"), acceleration->canProvideX() ? v8::Number::New(acceleration->x()) : v8Null(isolate));
+    object->Set(v8::String::NewSymbol("y"), acceleration->canProvideY() ? v8::Number::New(acceleration->y()) : v8Null(isolate));
+    object->Set(v8::String::NewSymbol("z"), acceleration->canProvideZ() ? v8::Number::New(acceleration->z()) : v8Null(isolate));
     return object;
 }
 
 static v8::Handle<v8::Value> createRotationRateObject(const DeviceMotionData::RotationRate* rotationRate, v8::Isolate* isolate)
 {
     v8::Local<v8::Object> object = v8::Object::New();
-    object->Set(v8::String::NewSymbol("alpha"), rotationRate->canProvideAlpha() ? v8::Number::New(rotationRate->alpha()) : v8::Null(isolate));
-    object->Set(v8::String::NewSymbol("beta"),  rotationRate->canProvideBeta()  ? v8::Number::New(rotationRate->beta())  : v8::Null(isolate));
-    object->Set(v8::String::NewSymbol("gamma"), rotationRate->canProvideGamma() ? v8::Number::New(rotationRate->gamma()) : v8::Null(isolate));
+    object->Set(v8::String::NewSymbol("alpha"), rotationRate->canProvideAlpha() ? v8::Number::New(rotationRate->alpha()) : v8Null(isolate));
+    object->Set(v8::String::NewSymbol("beta"),  rotationRate->canProvideBeta()  ? v8::Number::New(rotationRate->beta())  : v8Null(isolate));
+    object->Set(v8::String::NewSymbol("gamma"), rotationRate->canProvideGamma() ? v8::Number::New(rotationRate->gamma()) : v8Null(isolate));
     return object;
 }
 
@@ -127,7 +127,7 @@
     v8::Handle<v8::Object> holder = info.Holder();
     DeviceMotionEvent* imp = V8DeviceMotionEvent::toNative(holder);
     if (!imp->deviceMotionData()->acceleration())
-        return v8::Null(info.GetIsolate());
+        return v8Null(info.GetIsolate());
     return createAccelerationObject(imp->deviceMotionData()->acceleration(), info.GetIsolate());
 }
 
@@ -137,7 +137,7 @@
     v8::Handle<v8::Object> holder = info.Holder();
     DeviceMotionEvent* imp = V8DeviceMotionEvent::toNative(holder);
     if (!imp->deviceMotionData()->accelerationIncludingGravity())
-        return v8::Null(info.GetIsolate());
+        return v8Null(info.GetIsolate());
     return createAccelerationObject(imp->deviceMotionData()->accelerationIncludingGravity(), info.GetIsolate());
 }
 
@@ -147,7 +147,7 @@
     v8::Handle<v8::Object> holder = info.Holder();
     DeviceMotionEvent* imp = V8DeviceMotionEvent::toNative(holder);
     if (!imp->deviceMotionData()->rotationRate())
-        return v8::Null(info.GetIsolate());
+        return v8Null(info.GetIsolate());
     return createRotationRateObject(imp->deviceMotionData()->rotationRate(), info.GetIsolate());
 }
 
@@ -157,7 +157,7 @@
     v8::Handle<v8::Object> holder = info.Holder();
     DeviceMotionEvent* imp = V8DeviceMotionEvent::toNative(holder);
     if (!imp->deviceMotionData()->canProvideInterval())
-        return v8::Null(info.GetIsolate());
+        return v8Null(info.GetIsolate());
     return v8::Number::New(imp->deviceMotionData()->interval());
 }
 

Modified: trunk/Source/WebCore/bindings/v8/custom/V8DeviceOrientationEventCustom.cpp (136631 => 136632)


--- trunk/Source/WebCore/bindings/v8/custom/V8DeviceOrientationEventCustom.cpp	2012-12-05 04:55:38 UTC (rev 136631)
+++ trunk/Source/WebCore/bindings/v8/custom/V8DeviceOrientationEventCustom.cpp	2012-12-05 05:02:21 UTC (rev 136632)
@@ -41,7 +41,7 @@
     v8::Handle<v8::Object> holder = info.Holder();
     DeviceOrientationEvent* imp = V8DeviceOrientationEvent::toNative(holder);
     if (!imp->orientation()->canProvideAlpha())
-        return v8::Null(info.GetIsolate());
+        return v8Null(info.GetIsolate());
     return v8::Number::New(imp->orientation()->alpha());
 }
 
@@ -51,7 +51,7 @@
     v8::Handle<v8::Object> holder = info.Holder();
     DeviceOrientationEvent* imp = V8DeviceOrientationEvent::toNative(holder);
     if (!imp->orientation()->canProvideBeta())
-        return v8::Null(info.GetIsolate());
+        return v8Null(info.GetIsolate());
     return v8::Number::New(imp->orientation()->beta());
 }
 
@@ -61,7 +61,7 @@
     v8::Handle<v8::Object> holder = info.Holder();
     DeviceOrientationEvent* imp = V8DeviceOrientationEvent::toNative(holder);
     if (!imp->orientation()->canProvideGamma())
-        return v8::Null(info.GetIsolate());
+        return v8Null(info.GetIsolate());
     return v8::Number::New(imp->orientation()->gamma());
 }
 
@@ -71,7 +71,7 @@
     v8::Handle<v8::Object> holder = info.Holder();
     DeviceOrientationEvent* imp = V8DeviceOrientationEvent::toNative(holder);
     if (!imp->orientation()->canProvideAbsolute())
-        return v8::Null(info.GetIsolate());
+        return v8Null(info.GetIsolate());
     return v8::Boolean::New(imp->orientation()->absolute());
 }
 

Modified: trunk/Source/WebCore/bindings/v8/custom/V8DocumentLocationCustom.cpp (136631 => 136632)


--- trunk/Source/WebCore/bindings/v8/custom/V8DocumentLocationCustom.cpp	2012-12-05 04:55:38 UTC (rev 136631)
+++ trunk/Source/WebCore/bindings/v8/custom/V8DocumentLocationCustom.cpp	2012-12-05 05:02:21 UTC (rev 136632)
@@ -37,7 +37,7 @@
 {
     Document* document = V8Document::toNative(info.Holder());
     if (!document->frame())
-        return v8::Null(info.GetIsolate());
+        return v8Null(info.GetIsolate());
 
     DOMWindow* window = document->domWindow();
     return toV8(window->location(), info.Holder(), info.GetIsolate());

Modified: trunk/Source/WebCore/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp (136631 => 136632)


--- trunk/Source/WebCore/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp	2012-12-05 04:55:38 UTC (rev 136631)
+++ trunk/Source/WebCore/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp	2012-12-05 05:02:21 UTC (rev 136632)
@@ -84,7 +84,7 @@
 #endif
     CanvasRenderingContext* result = imp->getContext(contextId, attrs.get());
     if (!result)
-        return v8::Null(args.GetIsolate());
+        return v8Null(args.GetIsolate());
     else if (result->is2d()) {
         v8::Handle<v8::Value> v8Result = toV8(static_cast<CanvasRenderingContext2D*>(result), args.Holder(), args.GetIsolate());
         if (InspectorInstrumentation::canvasAgentEnabled(imp->document())) {
@@ -116,7 +116,7 @@
     }
 #endif
     ASSERT_NOT_REACHED();
-    return v8::Null(args.GetIsolate());
+    return v8Null(args.GetIsolate());
 }
 
 v8::Handle<v8::Value> V8HTMLCanvasElement::toDataURLCallback(const v8::Arguments& args)

Modified: trunk/Source/WebCore/bindings/v8/custom/V8HistoryCustom.cpp (136631 => 136632)


--- trunk/Source/WebCore/bindings/v8/custom/V8HistoryCustom.cpp	2012-12-05 04:55:38 UTC (rev 136631)
+++ trunk/Source/WebCore/bindings/v8/custom/V8HistoryCustom.cpp	2012-12-05 05:02:21 UTC (rev 136632)
@@ -52,7 +52,7 @@
         return value;
 
     SerializedScriptValue* serialized = history->state();
-    value = serialized ? serialized->deserialize(0, info.GetIsolate()) : v8::Handle<v8::Value>(v8::Null(info.GetIsolate()));
+    value = serialized ? serialized->deserialize(0, info.GetIsolate()) : v8::Handle<v8::Value>(v8Null(info.GetIsolate()));
     info.Holder()->SetHiddenValue(V8HiddenPropertyName::state(), value);
 
     return value;

Modified: trunk/Source/WebCore/bindings/v8/custom/V8MessageEventCustom.cpp (136631 => 136632)


--- trunk/Source/WebCore/bindings/v8/custom/V8MessageEventCustom.cpp	2012-12-05 04:55:38 UTC (rev 136631)
+++ trunk/Source/WebCore/bindings/v8/custom/V8MessageEventCustom.cpp	2012-12-05 05:02:21 UTC (rev 136632)
@@ -52,7 +52,7 @@
     case MessageEvent::DataTypeScriptValue: {
         ScriptValue scriptValue = event->dataAsScriptValue();
         if (scriptValue.hasNoValue())
-            result = v8::Null(info.GetIsolate());
+            result = v8Null(info.GetIsolate());
         else
             result = v8::Local<v8::Value>::New(scriptValue.v8Value());
         break;
@@ -62,7 +62,7 @@
         if (SerializedScriptValue* serializedValue = event->dataAsSerializedScriptValue())
             result = serializedValue->deserialize(event->ports(), info.GetIsolate());
         else
-            result = v8::Null(info.GetIsolate());
+            result = v8Null(info.GetIsolate());
         break;
 
     case MessageEvent::DataTypeString: {

Modified: trunk/Source/WebCore/bindings/v8/custom/V8MicroDataItemValueCustom.cpp (136631 => 136632)


--- trunk/Source/WebCore/bindings/v8/custom/V8MicroDataItemValueCustom.cpp	2012-12-05 04:55:38 UTC (rev 136631)
+++ trunk/Source/WebCore/bindings/v8/custom/V8MicroDataItemValueCustom.cpp	2012-12-05 05:02:21 UTC (rev 136632)
@@ -42,7 +42,7 @@
 v8::Handle<v8::Value> toV8(MicroDataItemValue* itemValue, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
 {
     if (!itemValue)
-        return v8::Null();
+        return v8Null(isolate);
     if (itemValue->isNode())
         return toV8(itemValue->getNode(), creationContext, isolate);
     return v8String(itemValue->getString(), isolate);

Modified: trunk/Source/WebCore/bindings/v8/custom/V8NodeCustom.cpp (136631 => 136632)


--- trunk/Source/WebCore/bindings/v8/custom/V8NodeCustom.cpp	2012-12-05 04:55:38 UTC (rev 136631)
+++ trunk/Source/WebCore/bindings/v8/custom/V8NodeCustom.cpp	2012-12-05 05:02:21 UTC (rev 136632)
@@ -74,7 +74,7 @@
         return setDOMException(ec, args.GetIsolate());
     if (success)
         return args[0];
-    return v8::Null(args.GetIsolate());
+    return v8Null(args.GetIsolate());
 }
 
 // This function is customized to take advantage of the optional 4th argument: shouldLazyAttach
@@ -91,7 +91,7 @@
         return setDOMException(ec, args.GetIsolate());
     if (success)
         return args[1];
-    return v8::Null(args.GetIsolate());
+    return v8Null(args.GetIsolate());
 }
 
 v8::Handle<v8::Value> V8Node::removeChildCallback(const v8::Arguments& args)
@@ -106,7 +106,7 @@
         return setDOMException(ec, args.GetIsolate());
     if (success)
         return args[0];
-    return v8::Null(args.GetIsolate());
+    return v8Null(args.GetIsolate());
 }
 
 // This function is customized to take advantage of the optional 4th argument: shouldLazyAttach
@@ -122,7 +122,7 @@
         return setDOMException(ec, args.GetIsolate());
     if (success)
         return args[0];
-    return v8::Null(args.GetIsolate());
+    return v8Null(args.GetIsolate());
 }
 
 v8::Handle<v8::Object> wrap(Node* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)

Modified: trunk/Source/WebCore/bindings/v8/custom/V8PopStateEventCustom.cpp (136631 => 136632)


--- trunk/Source/WebCore/bindings/v8/custom/V8PopStateEventCustom.cpp	2012-12-05 04:55:38 UTC (rev 136631)
+++ trunk/Source/WebCore/bindings/v8/custom/V8PopStateEventCustom.cpp	2012-12-05 05:02:21 UTC (rev 136632)
@@ -61,7 +61,7 @@
 
     History* history = event->history();
     if (!history || !event->serializedState())
-        return cacheState(info.Holder(), v8::Null(info.GetIsolate()));
+        return cacheState(info.Holder(), v8Null(info.GetIsolate()));
 
     // There's no cached value from a previous invocation, nor a state value was provided by the
     // event, but there is a history object, so first we need to see if the state object has been

Modified: trunk/Source/WebCore/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp (136631 => 136632)


--- trunk/Source/WebCore/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp	2012-12-05 04:55:38 UTC (rev 136631)
+++ trunk/Source/WebCore/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp	2012-12-05 05:02:21 UTC (rev 136632)
@@ -66,7 +66,7 @@
                 value = v8String(sqlValue.string(), args.GetIsolate());
                 break;
             case SQLValue::NullValue:
-                value = v8::Null(args.GetIsolate());
+                value = v8Null(args.GetIsolate());
                 break;
             case SQLValue::NumberValue:
                 value = v8::Number::New(sqlValue.number());

Modified: trunk/Source/WebCore/bindings/v8/custom/V8TrackEventCustom.cpp (136631 => 136632)


--- trunk/Source/WebCore/bindings/v8/custom/V8TrackEventCustom.cpp	2012-12-05 04:55:38 UTC (rev 136631)
+++ trunk/Source/WebCore/bindings/v8/custom/V8TrackEventCustom.cpp	2012-12-05 05:02:21 UTC (rev 136632)
@@ -47,7 +47,7 @@
     TrackBase* track = trackEvent->track();
     
     if (!track)
-        return v8::Null(info.GetIsolate());
+        return v8Null(info.GetIsolate());
 
     switch (track->type()) {
     case TrackBase::BaseTrack:
@@ -66,7 +66,7 @@
         break;
     }
 
-    return v8::Null(info.GetIsolate());
+    return v8Null(info.GetIsolate());
 }
 
 } // namespace WebCore

Modified: trunk/Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp (136631 => 136632)


--- trunk/Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp	2012-12-05 04:55:38 UTC (rev 136631)
+++ trunk/Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp	2012-12-05 05:02:21 UTC (rev 136632)
@@ -132,7 +132,7 @@
     case WebGLGetInfo::kTypeInt:
         return v8Integer(info.getInt(), isolate);
     case WebGLGetInfo::kTypeNull:
-        return v8::Null(isolate);
+        return v8Null(isolate);
     case WebGLGetInfo::kTypeString:
         return v8String(info.getString());
     case WebGLGetInfo::kTypeUnsignedInt:
@@ -168,7 +168,7 @@
 static v8::Handle<v8::Value> toV8Object(WebGLExtension* extension, v8::Handle<v8::Object> contextObject, v8::Isolate* isolate)
 {
     if (!extension)
-        return v8::Null(isolate);
+        return v8Null(isolate);
     v8::Handle<v8::Value> extensionObject;
     const char* referenceName = 0;
     switch (extension->getName()) {
@@ -286,10 +286,10 @@
     bool succeed = context->getAttachedShaders(program, shaders, ec);
     if (ec) {
         setDOMException(ec, args.GetIsolate());
-        return v8::Null(args.GetIsolate());
+        return v8Null(args.GetIsolate());
     }
     if (!succeed)
-        return v8::Null(args.GetIsolate());
+        return v8Null(args.GetIsolate());
     v8::Local<v8::Array> array = v8::Array::New(shaders.size());
     for (size_t ii = 0; ii < shaders.size(); ++ii)
         array->Set(v8Integer(ii, args.GetIsolate()), toV8(shaders[ii].get(), args.Holder(), args.GetIsolate()));
@@ -396,7 +396,7 @@
     INC_STATS("DOM.WebGLRenderingContext.getSupportedExtensionsCallback()");
     WebGLRenderingContext* imp = V8WebGLRenderingContext::toNative(args.Holder());
     if (imp->isContextLost())
-        return v8::Null(args.GetIsolate());
+        return v8Null(args.GetIsolate());
 
     Vector<String> value = imp->getSupportedExtensions();
     v8::Local<v8::Array> array = v8::Array::New(value.size());
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to