Title: [136647] trunk/Source/WebCore
- Revision
- 136647
- Author
- [email protected]
- Date
- 2012-12-05 00:03:58 -0800 (Wed, 05 Dec 2012)
Log Message
[CSS Exclusions] ExclusionShape inlines should use isFlippedBlocksWritingMode()
https://bugs.webkit.org/show_bug.cgi?id=103939
Patch by Hans Muller <[email protected]> on 2012-12-05
Reviewed by Dirk Schulze.
Just a minor cleanup: the protected ExclusionShape inlines, like minYForLogicalLine(),
now use isFlippedBlocksWritingMode() instead of testing for RightToLeftWritingMode directly.
This changeimproves consistency with the rest of WebKit and will work correctly
if "horizontal-bt" writing-mode support is ever added.
No new tests were added since the existing tests cover these methods.
* rendering/ExclusionShape.h:
(WebCore::ExclusionShape::minYForLogicalLine):
(WebCore::ExclusionShape::maxYForLogicalLine):
(WebCore::ExclusionShape::internalToLogicalBoundingBox):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (136646 => 136647)
--- trunk/Source/WebCore/ChangeLog 2012-12-05 08:02:47 UTC (rev 136646)
+++ trunk/Source/WebCore/ChangeLog 2012-12-05 08:03:58 UTC (rev 136647)
@@ -1,3 +1,22 @@
+2012-12-05 Hans Muller <[email protected]>
+
+ [CSS Exclusions] ExclusionShape inlines should use isFlippedBlocksWritingMode()
+ https://bugs.webkit.org/show_bug.cgi?id=103939
+
+ Reviewed by Dirk Schulze.
+
+ Just a minor cleanup: the protected ExclusionShape inlines, like minYForLogicalLine(),
+ now use isFlippedBlocksWritingMode() instead of testing for RightToLeftWritingMode directly.
+ This changeimproves consistency with the rest of WebKit and will work correctly
+ if "horizontal-bt" writing-mode support is ever added.
+
+ No new tests were added since the existing tests cover these methods.
+
+ * rendering/ExclusionShape.h:
+ (WebCore::ExclusionShape::minYForLogicalLine):
+ (WebCore::ExclusionShape::maxYForLogicalLine):
+ (WebCore::ExclusionShape::internalToLogicalBoundingBox):
+
2012-12-05 Bear Travis <[email protected]>
Absolutely positioned non-replaced elements should resolve vertical margins against
Modified: trunk/Source/WebCore/rendering/ExclusionShape.h (136646 => 136647)
--- trunk/Source/WebCore/rendering/ExclusionShape.h 2012-12-05 08:02:47 UTC (rev 136646)
+++ trunk/Source/WebCore/rendering/ExclusionShape.h 2012-12-05 08:03:58 UTC (rev 136647)
@@ -69,9 +69,9 @@
virtual void getExcludedIntervals(float logicalTop, float logicalHeight, SegmentList&) const = 0;
protected:
- float minYForLogicalLine(float logicalTop, float logicalHeight) const { return (m_writingMode == RightToLeftWritingMode) ? m_logicalBoxHeight - logicalTop - logicalHeight : logicalTop; }
- float maxYForLogicalLine(float logicalTop, float logicalHeight) const { return (m_writingMode == RightToLeftWritingMode) ? m_logicalBoxHeight - logicalTop : logicalTop + logicalHeight; }
- FloatRect internalToLogicalBoundingBox(FloatRect r) const { return (m_writingMode == RightToLeftWritingMode) ? FloatRect(r.x(), m_logicalBoxHeight - r.maxY(), r.width(), r.height()) : r; }
+ float minYForLogicalLine(float logicalTop, float logicalHeight) const { return isFlippedBlocksWritingMode(m_writingMode) ? m_logicalBoxHeight - logicalTop - logicalHeight : logicalTop; }
+ float maxYForLogicalLine(float logicalTop, float logicalHeight) const { return isFlippedBlocksWritingMode(m_writingMode) ? m_logicalBoxHeight - logicalTop : logicalTop + logicalHeight; }
+ FloatRect internalToLogicalBoundingBox(const FloatRect& r) const { return isFlippedBlocksWritingMode(m_writingMode) ? FloatRect(r.x(), m_logicalBoxHeight - r.maxY(), r.width(), r.height()) : r; }
private:
WritingMode m_writingMode;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
