Title: [136691] trunk/Source/WebKit2
- Revision
- 136691
- Author
- [email protected]
- Date
- 2012-12-05 08:10:37 -0800 (Wed, 05 Dec 2012)
Log Message
[EFL][WK2] EWK2UnitTestBase.ewk_favicon_database_async_icon_get is crashing with new Ewk_Context
https://bugs.webkit.org/show_bug.cgi?id=104110
Reviewed by Laszlo Gombos.
Unregister the WKFaviconDatabase client in EwkFaviconDatabase
destructor to avoid crashing if the callbacks get called
after the EwkFaviconDatabase object has been destroyed (i.e.
the parent EwkContext object was destroyed).
* UIProcess/API/efl/ewk_favicon_database.cpp:
(EwkFaviconDatabase::~EwkFaviconDatabase):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (136690 => 136691)
--- trunk/Source/WebKit2/ChangeLog 2012-12-05 15:57:42 UTC (rev 136690)
+++ trunk/Source/WebKit2/ChangeLog 2012-12-05 16:10:37 UTC (rev 136691)
@@ -1,3 +1,18 @@
+2012-12-05 Christophe Dumez <[email protected]>
+
+ [EFL][WK2] EWK2UnitTestBase.ewk_favicon_database_async_icon_get is crashing with new Ewk_Context
+ https://bugs.webkit.org/show_bug.cgi?id=104110
+
+ Reviewed by Laszlo Gombos.
+
+ Unregister the WKFaviconDatabase client in EwkFaviconDatabase
+ destructor to avoid crashing if the callbacks get called
+ after the EwkFaviconDatabase object has been destroyed (i.e.
+ the parent EwkContext object was destroyed).
+
+ * UIProcess/API/efl/ewk_favicon_database.cpp:
+ (EwkFaviconDatabase::~EwkFaviconDatabase):
+
2012-12-05 Andras Becsi <[email protected]>
[Qt][WK2] REGRESSION(r135399): It made qmltests::DoubleTapToZoom::test_double_zoomInAndBack() API test fail
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_favicon_database.cpp (136690 => 136691)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_favicon_database.cpp 2012-12-05 15:57:42 UTC (rev 136690)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_favicon_database.cpp 2012-12-05 16:10:37 UTC (rev 136691)
@@ -53,6 +53,7 @@
EwkFaviconDatabase::~EwkFaviconDatabase()
{
+ WKIconDatabaseSetIconDatabaseClient(toAPI(m_iconDatabase.get()), 0);
}
String EwkFaviconDatabase::iconURLForPageURL(const String& pageURL) const
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
