Title: [136777] trunk/Source/WebCore
Revision
136777
Author
[email protected]
Date
2012-12-05 16:31:31 -0800 (Wed, 05 Dec 2012)

Log Message

Unreviewed, rolling out r136481.
http://trac.webkit.org/changeset/136481
https://bugs.webkit.org/show_bug.cgi?id=103868

it might have regressed dom_perf/CloneNodes (See bug 104177)

* dom/ContainerNodeAlgorithms.h:
(ChildNodeInsertionNotifier):
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoDocument):
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoTree):
(WebCore::ChildNodeInsertionNotifier::notify):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (136776 => 136777)


--- trunk/Source/WebCore/ChangeLog	2012-12-06 00:22:45 UTC (rev 136776)
+++ trunk/Source/WebCore/ChangeLog	2012-12-06 00:31:31 UTC (rev 136777)
@@ -1,3 +1,17 @@
+2012-12-05  Kentaro Hara  <[email protected]>
+
+        Unreviewed, rolling out r136481.
+        http://trac.webkit.org/changeset/136481
+        https://bugs.webkit.org/show_bug.cgi?id=103868
+
+        it might have regressed dom_perf/CloneNodes (See bug 104177)
+
+        * dom/ContainerNodeAlgorithms.h:
+        (ChildNodeInsertionNotifier):
+        (WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoDocument):
+        (WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoTree):
+        (WebCore::ChildNodeInsertionNotifier::notify):
+
 2012-12-05  David Grogan  <[email protected]>
 
         IndexedDB: Abort transactions because of leveldb errors part 3

Modified: trunk/Source/WebCore/dom/ContainerNodeAlgorithms.h (136776 => 136777)


--- trunk/Source/WebCore/dom/ContainerNodeAlgorithms.h	2012-12-06 00:22:45 UTC (rev 136776)
+++ trunk/Source/WebCore/dom/ContainerNodeAlgorithms.h	2012-12-06 00:31:31 UTC (rev 136777)
@@ -47,7 +47,7 @@
     void notifyNodeInsertedIntoTree(ContainerNode*);
 
     ContainerNode* m_insertionPoint;
-    OwnPtr<Vector<RefPtr<Node> > > m_postInsertionNotificationTargets;
+    Vector< RefPtr<Node> > m_postInsertionNotificationTargets;
 };
 
 class ChildNodeRemovalNotifier {
@@ -194,11 +194,8 @@
 {
     ASSERT(m_insertionPoint->inDocument());
     RefPtr<Node> protect(node);
-    if (Node::InsertionShouldCallDidNotifySubtreeInsertions == node->insertedInto(m_insertionPoint)) {
-        if (!m_postInsertionNotificationTargets)
-            m_postInsertionNotificationTargets = adoptPtr(new Vector<RefPtr<Node> >);
-        m_postInsertionNotificationTargets->append(node);
-    }
+    if (Node::InsertionShouldCallDidNotifySubtreeInsertions == node->insertedInto(m_insertionPoint))
+        m_postInsertionNotificationTargets.append(node);
     if (node->isContainerNode())
         notifyDescendantInsertedIntoDocument(toContainerNode(node));
 }
@@ -208,11 +205,8 @@
     NoEventDispatchAssertion assertNoEventDispatch;
     ASSERT(!m_insertionPoint->inDocument());
 
-    if (Node::InsertionShouldCallDidNotifySubtreeInsertions == node->insertedInto(m_insertionPoint)) {
-        if (!m_postInsertionNotificationTargets)
-            m_postInsertionNotificationTargets = adoptPtr(new Vector<RefPtr<Node> >);
-        m_postInsertionNotificationTargets->append(node);
-    }
+    if (Node::InsertionShouldCallDidNotifySubtreeInsertions == node->insertedInto(m_insertionPoint))
+        m_postInsertionNotificationTargets.append(node);
     notifyDescendantInsertedIntoTree(node);
 }
 
@@ -237,10 +231,8 @@
     else if (node->isContainerNode())
         notifyNodeInsertedIntoTree(toContainerNode(node));
 
-    if (m_postInsertionNotificationTargets) {
-        for (size_t i = 0; i < m_postInsertionNotificationTargets->size(); ++i)
-            m_postInsertionNotificationTargets->at(i)->didNotifySubtreeInsertions(m_insertionPoint);
-    }
+    for (size_t i = 0; i < m_postInsertionNotificationTargets.size(); ++i)
+        m_postInsertionNotificationTargets[i]->didNotifySubtreeInsertions(m_insertionPoint);
 }
 
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to