Title: [136783] trunk/Websites/bugs.webkit.org
Revision
136783
Author
[email protected]
Date
2012-12-05 17:35:36 -0800 (Wed, 05 Dec 2012)

Log Message

Make the strip line numbers link into a checkbox
https://bugs.webkit.org/show_bug.cgi?id=104187

Reviewed by Tony Chang.

The link text was confusing.

* PrettyPatch/PrettyPatch.rb:
* code-review.js:

Modified Paths

Diff

Modified: trunk/Websites/bugs.webkit.org/ChangeLog (136782 => 136783)


--- trunk/Websites/bugs.webkit.org/ChangeLog	2012-12-06 01:30:35 UTC (rev 136782)
+++ trunk/Websites/bugs.webkit.org/ChangeLog	2012-12-06 01:35:36 UTC (rev 136783)
@@ -1,5 +1,17 @@
 2012-12-05  Ojan Vafai  <[email protected]>
 
+        Make the strip line numbers link into a checkbox
+        https://bugs.webkit.org/show_bug.cgi?id=104187
+
+        Reviewed by Tony Chang.
+
+        The link text was confusing.
+
+        * PrettyPatch/PrettyPatch.rb:
+        * code-review.js:
+
+2012-12-05  Ojan Vafai  <[email protected]>
+
         Sanitize content on copy in the code review tool
         https://bugs.webkit.org/show_bug.cgi?id=104155
 

Modified: trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb (136782 => 136783)


--- trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb	2012-12-06 01:30:35 UTC (rev 136782)
+++ trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb	2012-12-06 01:35:36 UTC (rev 136783)
@@ -417,6 +417,7 @@
   border: 0;
 }
 
+.LinkContainer label:after,
 .LinkContainer a:after {
   content: " | ";
   color: black;
@@ -426,6 +427,10 @@
   content: "";
 }
 
+.LinkContainer label {
+  color: #039;
+}
+
 .help {
  color: gray;
  font-style: italic;
@@ -501,7 +506,7 @@
 }
 </style>
 <script src="" 
-<script src=""
+<script src=""
 </head>
 EOF
 

Modified: trunk/Websites/bugs.webkit.org/code-review.js (136782 => 136783)


--- trunk/Websites/bugs.webkit.org/code-review.js	2012-12-06 01:30:35 UTC (rev 136782)
+++ trunk/Websites/bugs.webkit.org/code-review.js	2012-12-06 01:35:36 UTC (rev 136783)
@@ -1099,7 +1099,7 @@
     $(document.body).prepend('<div id="message">' +
         '<div class="help">Select line numbers to add a comment. Scroll though diffs with the "j" and "k" keys.' +
           '<div class="DiffLinks LinkContainer">' +
-            '<a href="" id="line-number-on-copy-link"></a> ' +
+            '<input type="checkbox" id="line-number-on-copy"><label for="" line numbers on copy</label>' +
             diffLinksHtml() +
           '</div>' +
           '<a href="" class="more">[more]</a>' +
@@ -1138,11 +1138,10 @@
     Array.prototype.forEach.call(nodeList, callback);
   }
 
-  $('#line-number-on-copy-link').live('click', toggleShouldStripLineNumbersOnCopy);
+  $('#line-number-on-copy').live('click', toggleShouldStripLineNumbersOnCopy);
 
   function updateLineNumberOnCopyLinkContents() {
-    var link = document.getElementById('line-number-on-copy-link');
-    link.textContent = shouldStripLineNumbersOnCopy() ? 'Don\'t strip line numbers on copy' : 'Strip line numbers on copy';
+    document.getElementById('line-number-on-copy').checked = shouldStripLineNumbersOnCopy();
   }
 
   function shouldStripLineNumbersOnCopy() {
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to