Title: [136800] trunk
- Revision
- 136800
- Author
- [email protected]
- Date
- 2012-12-05 22:08:03 -0800 (Wed, 05 Dec 2012)
Log Message
HTMLFormElement#requestAutocomplete() should require a user action
https://bugs.webkit.org/show_bug.cgi?id=102320
Patch by Dan Beam <[email protected]> on 2012-12-05
Reviewed by Kent Tamura.
This patch dispatches an autocompleteerror when HTMLFormElement::requestAutocomplete() is called while not processing
a user gesture.
Source/WebCore:
* fast/forms/form-request-autocomplete.html is updated.
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::requestAutocomplete):
Asynchronously dispatch an autocomplete error when not processing a user action when
HTMLFormElement#requestAutocomplete() is invoked.
LayoutTests:
* fast/forms/form-request-autocomplete.html:
Added a test to ensure that dispatching a call to HTMLFormElement#requestAutocomplete() in a setTimeout() (which will
never be a user gesture) always fails.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (136799 => 136800)
--- trunk/LayoutTests/ChangeLog 2012-12-06 06:02:30 UTC (rev 136799)
+++ trunk/LayoutTests/ChangeLog 2012-12-06 06:08:03 UTC (rev 136800)
@@ -1,3 +1,18 @@
+2012-12-05 Dan Beam <[email protected]>
+
+ HTMLFormElement#requestAutocomplete() should require a user action
+ https://bugs.webkit.org/show_bug.cgi?id=102320
+
+ Reviewed by Kent Tamura.
+
+ This patch dispatches an autocompleteerror when HTMLFormElement::requestAutocomplete() is called while not processing
+ a user gesture.
+
+ * fast/forms/form-request-autocomplete.html:
+
+ Added a test to ensure that dispatching a call to HTMLFormElement#requestAutocomplete() in a setTimeout() (which will
+ never be a user gesture) always fails.
+
2012-12-05 Andrei Bucur <[email protected]>
[CSS Regions] Blocks don't relayout children if the width of a region changes
Modified: trunk/LayoutTests/fast/forms/form-request-autocomplete.html (136799 => 136800)
--- trunk/LayoutTests/fast/forms/form-request-autocomplete.html 2012-12-06 06:02:30 UTC (rev 136799)
+++ trunk/LayoutTests/fast/forms/form-request-autocomplete.html 2012-12-06 06:08:03 UTC (rev 136800)
@@ -55,6 +55,20 @@
form.requestAutocomplete();
}
+function checkNonUserGesture()
+{
+ numErrorsExpected += 1;
+
+ var form = document.createElement('form');
+ checkForEnumerableProperties(form);
+ form._onautocompleteerror_ = onError;
+
+ setTimeout(function()
+ {
+ form.requestAutocomplete();
+ }, 0);
+}
+
function onError()
{
numErrors += 1;
Modified: trunk/Source/WebCore/ChangeLog (136799 => 136800)
--- trunk/Source/WebCore/ChangeLog 2012-12-06 06:02:30 UTC (rev 136799)
+++ trunk/Source/WebCore/ChangeLog 2012-12-06 06:08:03 UTC (rev 136800)
@@ -1,3 +1,21 @@
+2012-12-05 Dan Beam <[email protected]>
+
+ HTMLFormElement#requestAutocomplete() should require a user action
+ https://bugs.webkit.org/show_bug.cgi?id=102320
+
+ Reviewed by Kent Tamura.
+
+ This patch dispatches an autocompleteerror when HTMLFormElement::requestAutocomplete() is called while not processing
+ a user gesture.
+
+ * fast/forms/form-request-autocomplete.html is updated.
+
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::requestAutocomplete):
+
+ Asynchronously dispatch an autocomplete error when not processing a user action when
+ HTMLFormElement#requestAutocomplete() is invoked.
+
2012-12-05 Kentaro Hara <[email protected]>
[V8] Optimize v8StringOrNull() and v8StringOrUndefined()
Modified: trunk/Source/WebCore/html/HTMLFormElement.cpp (136799 => 136800)
--- trunk/Source/WebCore/html/HTMLFormElement.cpp 2012-12-06 06:02:30 UTC (rev 136799)
+++ trunk/Source/WebCore/html/HTMLFormElement.cpp 2012-12-06 06:08:03 UTC (rev 136800)
@@ -397,7 +397,7 @@
if (!frame)
return;
- if (!shouldAutocomplete()) {
+ if (!shouldAutocomplete() || !ScriptController::processingUserGesture()) {
finishRequestAutocomplete(AutocompleteResultError);
return;
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes