Title: [136806] trunk
- Revision
- 136806
- Author
- [email protected]
- Date
- 2012-12-05 22:33:10 -0800 (Wed, 05 Dec 2012)
Log Message
[Chromium] DRT on Windows crashes when a testcase has a progress element in indeterminate state
https://bugs.webkit.org/show_bug.cgi?id=102459
Reviewed by Dimitri Glazkov.
Tools:
Since WebThemeControlDRTWin::markState does not consider indeterminate state, DRT caused a crash.
* DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
(WebThemeControlDRTWin::markState):
LayoutTests:
* fast/dom/HTMLProgressElement/progress-element-indeterminate-crash-expected.txt: Added.
* fast/dom/HTMLProgressElement/progress-element-indeterminate-crash.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (136805 => 136806)
--- trunk/LayoutTests/ChangeLog 2012-12-06 06:31:22 UTC (rev 136805)
+++ trunk/LayoutTests/ChangeLog 2012-12-06 06:33:10 UTC (rev 136806)
@@ -1,3 +1,13 @@
+2012-12-05 Shinya Kawanaka <[email protected]>
+
+ [Chromium] DRT on Windows crashes when a testcase has a progress element in indeterminate state
+ https://bugs.webkit.org/show_bug.cgi?id=102459
+
+ Reviewed by Dimitri Glazkov.
+
+ * fast/dom/HTMLProgressElement/progress-element-indeterminate-crash-expected.txt: Added.
+ * fast/dom/HTMLProgressElement/progress-element-indeterminate-crash.html: Added.
+
2012-12-05 Kent Tamura <[email protected]>
INPUT_MULTIPLE_FIELDS_UI: The hour field and the am/pm field should support read-only state correctly
Added: trunk/LayoutTests/fast/dom/HTMLProgressElement/progress-element-indeterminate-crash-expected.txt (0 => 136806)
--- trunk/LayoutTests/fast/dom/HTMLProgressElement/progress-element-indeterminate-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLProgressElement/progress-element-indeterminate-crash-expected.txt 2012-12-06 06:33:10 UTC (rev 136806)
@@ -0,0 +1,9 @@
+Test for Bug 102459. OK if not crashed.
+
+
+PASS unless crash.
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/dom/HTMLProgressElement/progress-element-indeterminate-crash.html (0 => 136806)
--- trunk/LayoutTests/fast/dom/HTMLProgressElement/progress-element-indeterminate-crash.html (rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLProgressElement/progress-element-indeterminate-crash.html 2012-12-06 06:33:10 UTC (rev 136806)
@@ -0,0 +1,12 @@
+<!DOCTYPE html>
+<html>
+<body>
+<script src=""
+<h1>Test for <a href="" 102459</a>. OK if not crashed.</h1>
+<progress indeterminate="true"></progress>
+<p>PASS unless crash.</p>
+
+<pre id="console"></pre>
+<script src=""
+</body>
+</html>
Modified: trunk/Tools/ChangeLog (136805 => 136806)
--- trunk/Tools/ChangeLog 2012-12-06 06:31:22 UTC (rev 136805)
+++ trunk/Tools/ChangeLog 2012-12-06 06:33:10 UTC (rev 136806)
@@ -1,3 +1,15 @@
+2012-12-05 Shinya Kawanaka <[email protected]>
+
+ [Chromium] DRT on Windows crashes when a testcase has a progress element in indeterminate state
+ https://bugs.webkit.org/show_bug.cgi?id=102459
+
+ Reviewed by Dimitri Glazkov.
+
+ Since WebThemeControlDRTWin::markState does not consider indeterminate state, DRT caused a crash.
+
+ * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
+ (WebThemeControlDRTWin::markState):
+
2012-12-05 Filip Pizlo <[email protected]>
DFG profiler should be able to display where a code block was inlined into, and what it inlined
Modified: trunk/Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp (136805 => 136806)
--- trunk/Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp 2012-12-06 06:31:22 UTC (rev 136805)
+++ trunk/Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp 2012-12-06 06:33:10 UTC (rev 136806)
@@ -235,6 +235,7 @@
case UnknownState:
case DisabledState:
case NormalState:
+ case IndeterminateState:
// Don't visually mark these states (color is enough).
break;
case ReadOnlyState:
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes