Title: [136809] trunk/Source/WebCore
Revision
136809
Author
[email protected]
Date
2012-12-05 23:28:05 -0800 (Wed, 05 Dec 2012)

Log Message

Web Inspector: Title of "Record Timeline" status button on "Timeline
Panel" should reflect the recording state.
https://bugs.webkit.org/show_bug.cgi?id=104108

Patch by Sankeerth V S <[email protected]> on 2012-12-05
Reviewed by Alexander Pavlov.

Title should be toggled between "Record"/"Stop" to reflect current
state of the Status bar button.

No new tests as UI related change.

* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype.get _toggleTimelineButtonClicked):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (136808 => 136809)


--- trunk/Source/WebCore/ChangeLog	2012-12-06 07:10:22 UTC (rev 136808)
+++ trunk/Source/WebCore/ChangeLog	2012-12-06 07:28:05 UTC (rev 136809)
@@ -1,3 +1,19 @@
+2012-12-05  Sankeerth V S  <[email protected]>
+
+        Web Inspector: Title of "Record Timeline" status button on "Timeline
+        Panel" should reflect the recording state.
+        https://bugs.webkit.org/show_bug.cgi?id=104108
+
+        Reviewed by Alexander Pavlov.
+
+        Title should be toggled between "Record"/"Stop" to reflect current
+        state of the Status bar button.
+
+        No new tests as UI related change.
+
+        * inspector/front-end/TimelinePanel.js:
+        (WebInspector.TimelinePanel.prototype.get _toggleTimelineButtonClicked):
+
 2012-12-03  Kent Tamura  <[email protected]>
 
         INPUT_MULTIPLE_FIELDS_UI doesn't show digits well in RTL locales

Modified: trunk/Source/WebCore/inspector/front-end/TimelinePanel.js (136808 => 136809)


--- trunk/Source/WebCore/inspector/front-end/TimelinePanel.js	2012-12-06 07:10:22 UTC (rev 136808)
+++ trunk/Source/WebCore/inspector/front-end/TimelinePanel.js	2012-12-06 07:28:05 UTC (rev 136809)
@@ -546,10 +546,13 @@
     {
         if (this._operationInProgress)
             return;
-        if (this.toggleTimelineButton.toggled)
+        if (this.toggleTimelineButton.toggled) {
             this._model.stopRecord();
+            this.toggleTimelineButton.title = WebInspector.UIString("Record");
+        }
         else {
             this._model.startRecord();
+            this.toggleTimelineButton.title = WebInspector.UIString("Stop");
             WebInspector.userMetrics.TimelineStarted.record();
         }
         this.toggleTimelineButton.toggled = !this.toggleTimelineButton.toggled;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to