Title: [136816] trunk/Source/WebCore
Revision
136816
Author
[email protected]
Date
2012-12-06 00:47:18 -0800 (Thu, 06 Dec 2012)

Log Message

[V8] Pass Isolate to toDOMStringList()
https://bugs.webkit.org/show_bug.cgi?id=104224

Reviewed by Adam Barth.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(JSValueToNative):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::overloadedMethod6Callback):
(WebCore::TestObjV8Internal::overloadedMethod7Callback):
(WebCore::TestObjV8Internal::overloadedMethod9Callback):
(WebCore::TestObjV8Internal::stringArrayFunctionCallback):
* bindings/v8/V8Binding.cpp:
(WebCore::toDOMStringList):
* bindings/v8/V8Binding.h:
(WebCore):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (136815 => 136816)


--- trunk/Source/WebCore/ChangeLog	2012-12-06 08:43:22 UTC (rev 136815)
+++ trunk/Source/WebCore/ChangeLog	2012-12-06 08:47:18 UTC (rev 136816)
@@ -1,3 +1,24 @@
+2012-12-05  Kentaro Hara  <[email protected]>
+
+        [V8] Pass Isolate to toDOMStringList()
+        https://bugs.webkit.org/show_bug.cgi?id=104224
+
+        Reviewed by Adam Barth.
+
+        No tests. No change in behavior.
+
+        * bindings/scripts/CodeGeneratorV8.pm:
+        (JSValueToNative):
+        * bindings/scripts/test/V8/V8TestObj.cpp:
+        (WebCore::TestObjV8Internal::overloadedMethod6Callback):
+        (WebCore::TestObjV8Internal::overloadedMethod7Callback):
+        (WebCore::TestObjV8Internal::overloadedMethod9Callback):
+        (WebCore::TestObjV8Internal::stringArrayFunctionCallback):
+        * bindings/v8/V8Binding.cpp:
+        (WebCore::toDOMStringList):
+        * bindings/v8/V8Binding.h:
+        (WebCore):
+
 2012-12-06  Kentaro Hara  <[email protected]>
 
         Remove JSDependentRetained.h and V8DependentRetained.h

Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (136815 => 136816)


--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2012-12-06 08:43:22 UTC (rev 136815)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2012-12-06 08:47:18 UTC (rev 136816)
@@ -3783,9 +3783,9 @@
     return "toInt64($value)" if $type eq "unsigned long long" or $type eq "long long";
     return "static_cast<Range::CompareHow>($value->Int32Value())" if $type eq "CompareHow";
     return "toWebCoreDate($value)" if $type eq "Date";
-    return "toDOMStringList($value)" if $type eq "DOMStringList";
+    return "toDOMStringList($value, $getIsolate)" if $type eq "DOMStringList";
     # FIXME: Consider replacing DOMStringList with DOMString[] or sequence<DOMString>.
-    return "toDOMStringList($value)" if $type eq "DOMString[]";
+    return "toDOMStringList($value, $getIsolate)" if $type eq "DOMString[]";
 
     if ($type eq "DOMString") {
         return $value;

Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp (136815 => 136816)


--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp	2012-12-06 08:43:22 UTC (rev 136815)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp	2012-12-06 08:47:18 UTC (rev 136816)
@@ -1609,7 +1609,7 @@
     if (args.Length() < 1)
         return throwNotEnoughArgumentsError(args.GetIsolate());
     TestObj* imp = V8TestObj::toNative(args.Holder());
-    V8TRYCATCH(RefPtr<DOMStringList>, listArg, toDOMStringList(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined)));
+    V8TRYCATCH(RefPtr<DOMStringList>, listArg, toDOMStringList(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined), args.GetIsolate()));
     imp->overloadedMethod(listArg);
     return v8Undefined();
 }
@@ -1620,7 +1620,7 @@
     if (args.Length() < 1)
         return throwNotEnoughArgumentsError(args.GetIsolate());
     TestObj* imp = V8TestObj::toNative(args.Holder());
-    V8TRYCATCH(RefPtr<DOMStringList>, arrayArg, toDOMStringList(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined)));
+    V8TRYCATCH(RefPtr<DOMStringList>, arrayArg, toDOMStringList(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined), args.GetIsolate()));
     imp->overloadedMethod(arrayArg);
     return v8Undefined();
 }
@@ -1642,7 +1642,7 @@
     if (args.Length() < 1)
         return throwNotEnoughArgumentsError(args.GetIsolate());
     TestObj* imp = V8TestObj::toNative(args.Holder());
-    V8TRYCATCH(RefPtr<DOMStringList>, arrayArg, toDOMStringList(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined)));
+    V8TRYCATCH(RefPtr<DOMStringList>, arrayArg, toDOMStringList(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined), args.GetIsolate()));
     imp->overloadedMethod(arrayArg);
     return v8Undefined();
 }
@@ -1830,7 +1830,7 @@
     TestObj* imp = V8TestObj::toNative(args.Holder());
     ExceptionCode ec = 0;
     {
-    V8TRYCATCH(RefPtr<DOMStringList>, values, toDOMStringList(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined)));
+    V8TRYCATCH(RefPtr<DOMStringList>, values, toDOMStringList(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined), args.GetIsolate()));
     RefPtr<DOMStringList> result = imp->stringArrayFunction(values, ec);
     if (UNLIKELY(ec))
         goto fail;

Modified: trunk/Source/WebCore/bindings/v8/V8Binding.cpp (136815 => 136816)


--- trunk/Source/WebCore/bindings/v8/V8Binding.cpp	2012-12-06 08:43:22 UTC (rev 136815)
+++ trunk/Source/WebCore/bindings/v8/V8Binding.cpp	2012-12-06 08:47:18 UTC (rev 136816)
@@ -196,7 +196,7 @@
     info.addMember(m_stringCache);
 }
     
-PassRefPtr<DOMStringList> toDOMStringList(v8::Handle<v8::Value> value)
+PassRefPtr<DOMStringList> toDOMStringList(v8::Handle<v8::Value> value, v8::Isolate* isolate)
 {
     v8::Local<v8::Value> v8Value(v8::Local<v8::Value>::New(value));
 
@@ -211,7 +211,7 @@
     RefPtr<DOMStringList> ret = DOMStringList::create();
     v8::Local<v8::Array> v8Array = v8::Local<v8::Array>::Cast(v8Value);
     for (size_t i = 0; i < v8Array->Length(); ++i) {
-        v8::Local<v8::Value> indexedValue = v8Array->Get(v8Integer(i));
+        v8::Local<v8::Value> indexedValue = v8Array->Get(v8Integer(i, isolate));
         ret->append(toWebCoreString(indexedValue));
     }
     return ret.release();

Modified: trunk/Source/WebCore/bindings/v8/V8Binding.h (136815 => 136816)


--- trunk/Source/WebCore/bindings/v8/V8Binding.h	2012-12-06 08:43:22 UTC (rev 136815)
+++ trunk/Source/WebCore/bindings/v8/V8Binding.h	2012-12-06 08:47:18 UTC (rev 136816)
@@ -429,7 +429,7 @@
 
     v8::Persistent<v8::FunctionTemplate> createRawTemplate();
 
-    PassRefPtr<DOMStringList> toDOMStringList(v8::Handle<v8::Value>);
+    PassRefPtr<DOMStringList> toDOMStringList(v8::Handle<v8::Value>, v8::Isolate*);
     PassRefPtr<XPathNSResolver> toXPathNSResolver(v8::Handle<v8::Value>);
 
     v8::Handle<v8::Object> toInnerGlobalObject(v8::Handle<v8::Context>);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to