Title: [136820] trunk/Source/WebCore
- Revision
- 136820
- Author
- [email protected]
- Date
- 2012-12-06 01:01:57 -0800 (Thu, 06 Dec 2012)
Log Message
[V8] Make an Isolate mandatory for v8StringOrNull() and v8StringOrUndefined()
https://bugs.webkit.org/show_bug.cgi?id=104213
Reviewed by Adam Barth.
All call sites of v8StringOrNull() and v8StringOrUndefined() have an Isolate.
No tests. No change in behavior.
* bindings/v8/V8Binding.h:
(WebCore::v8StringOrNull):
(WebCore::v8StringOrUndefined):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (136819 => 136820)
--- trunk/Source/WebCore/ChangeLog 2012-12-06 08:57:44 UTC (rev 136819)
+++ trunk/Source/WebCore/ChangeLog 2012-12-06 09:01:57 UTC (rev 136820)
@@ -1,3 +1,18 @@
+2012-12-06 Kentaro Hara <[email protected]>
+
+ [V8] Make an Isolate mandatory for v8StringOrNull() and v8StringOrUndefined()
+ https://bugs.webkit.org/show_bug.cgi?id=104213
+
+ Reviewed by Adam Barth.
+
+ All call sites of v8StringOrNull() and v8StringOrUndefined() have an Isolate.
+
+ No tests. No change in behavior.
+
+ * bindings/v8/V8Binding.h:
+ (WebCore::v8StringOrNull):
+ (WebCore::v8StringOrUndefined):
+
2012-12-05 Kentaro Hara <[email protected]>
[V8] Implement deprecatedV8Integer(int i)
Modified: trunk/Source/WebCore/bindings/v8/V8Binding.h (136819 => 136820)
--- trunk/Source/WebCore/bindings/v8/V8Binding.h 2012-12-06 08:57:44 UTC (rev 136819)
+++ trunk/Source/WebCore/bindings/v8/V8Binding.h 2012-12-06 09:01:57 UTC (rev 136820)
@@ -154,19 +154,17 @@
return V8PerIsolateData::from(isolate)->stringCache()->v8ExternalString(string.impl(), isolate);
}
- inline v8::Handle<v8::Value> v8StringOrNull(const String& string, v8::Isolate* isolate = 0)
+ inline v8::Handle<v8::Value> v8StringOrNull(const String& string, v8::Isolate* isolate)
{
- if (UNLIKELY(!isolate))
- isolate = v8::Isolate::GetCurrent();
+ ASSERT(isolate);
if (string.isNull())
return v8Null(isolate);
return V8PerIsolateData::from(isolate)->stringCache()->v8ExternalString(string.impl(), isolate);
}
- inline v8::Handle<v8::Value> v8StringOrUndefined(const String& string, v8::Isolate* isolate = 0)
+ inline v8::Handle<v8::Value> v8StringOrUndefined(const String& string, v8::Isolate* isolate)
{
- if (UNLIKELY(!isolate))
- isolate = v8::Isolate::GetCurrent();
+ ASSERT(isolate);
if (string.isNull())
return v8::Undefined(isolate);
return V8PerIsolateData::from(isolate)->stringCache()->v8ExternalString(string.impl(), isolate);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes