Title: [136824] trunk/Source/WebCore
- Revision
- 136824
- Author
- [email protected]
- Date
- 2012-12-06 01:49:09 -0800 (Thu, 06 Dec 2012)
Log Message
[v8] Fix hidden property name of V8ArrayBufferView flag.
https://bugs.webkit.org/show_bug.cgi?id=104099
Patch by Ulan Degenbaev <[email protected]> on 2012-12-06
Reviewed by Kentaro Hara.
Fix hidden property name of V8ArrayBufferView hidden copy method.
* bindings/v8/V8HiddenPropertyName.h:
(WebCore):
* bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
(WebCore::getHiddenCopyMethod):
(WebCore::installHiddenCopyMethod):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (136823 => 136824)
--- trunk/Source/WebCore/ChangeLog 2012-12-06 09:38:38 UTC (rev 136823)
+++ trunk/Source/WebCore/ChangeLog 2012-12-06 09:49:09 UTC (rev 136824)
@@ -1,3 +1,18 @@
+2012-12-06 Ulan Degenbaev <[email protected]>
+
+ [v8] Fix hidden property name of V8ArrayBufferView flag.
+ https://bugs.webkit.org/show_bug.cgi?id=104099
+
+ Reviewed by Kentaro Hara.
+
+ Fix hidden property name of V8ArrayBufferView hidden copy method.
+
+ * bindings/v8/V8HiddenPropertyName.h:
+ (WebCore):
+ * bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
+ (WebCore::getHiddenCopyMethod):
+ (WebCore::installHiddenCopyMethod):
+
2012-12-06 Kentaro Hara <[email protected]>
Unreviewed. Fixed a wrong comment landed in r136822.
Modified: trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.h (136823 => 136824)
--- trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.h 2012-12-06 09:38:38 UTC (rev 136823)
+++ trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.h 2012-12-06 09:49:09 UTC (rev 136824)
@@ -45,7 +45,8 @@
V(scriptState) \
V(sleepFunction) \
V(state) \
- V(toStringString)
+ V(toStringString) \
+ V(typedArrayHiddenCopyMethod)
enum V8HiddenPropertyCreationType { NewSymbol, NewString };
Modified: trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp (136823 => 136824)
--- trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp 2012-12-06 09:38:38 UTC (rev 136823)
+++ trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp 2012-12-06 09:49:09 UTC (rev 136824)
@@ -26,19 +26,16 @@
#include "V8ArrayBufferViewCustom.h"
#include "V8ArrayBufferViewCustomScript.h"
+#include "V8HiddenPropertyName.h"
#include <v8.h>
namespace WebCore {
-// The random suffix helps to avoid name collision.
-const char hiddenCopyMethodName[] = "TypedArray::HiddenCopy::8NkZVq";
-
v8::Handle<v8::Value> getHiddenCopyMethod(v8::Handle<v8::Object> prototype)
{
- v8::Handle<v8::String> key = v8::String::NewSymbol(hiddenCopyMethodName);
- return prototype->GetHiddenValue(key);
+ return prototype->GetHiddenValue(V8HiddenPropertyName::typedArrayHiddenCopyMethod());
}
v8::Handle<v8::Value> installHiddenCopyMethod(v8::Handle<v8::Object> prototype, v8::Isolate* isolate)
@@ -49,8 +46,7 @@
sizeof(V8ArrayBufferViewCustomScript_js));
v8::Handle<v8::Script> script = v8::Script::Compile(v8String(source, isolate));
v8::Handle<v8::Value> value = script->Run();
- v8::Handle<v8::String> key = v8::String::NewSymbol(hiddenCopyMethodName);
- prototype->SetHiddenValue(key, value);
+ prototype->SetHiddenValue(V8HiddenPropertyName::typedArrayHiddenCopyMethod(), value);
return value;
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes