[webkit-changes] [136852] trunk

Thu, 06 Dec 2012 10:00:50 -0800

Title: [136852] trunk
Revision
136852
Author
[email protected]
Date
2012-12-06 10:02:36 -0800 (Thu, 06 Dec 2012)

Log Message

[chromium] Should apply link highlight to largest enclosing node with a handCursor.
https://bugs.webkit.org/show_bug.cgi?id=104264

Reviewed by Adrienne Walker.

Source/WebKit/chromium:

Link highlights sometimes only apply to part of a link, if we select an enclosed
node (e.g. font changes in link text). The highlight should be applied to the
largest enclosing node that still has handCursor set.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::bestTouchLinkNode):

LayoutTests:

Add layout test to cover new functionality.

* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-nested.html: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-nested-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-nested-expected.txt: Added.

Modified Paths

Added Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (136851 => 136852)


--- trunk/LayoutTests/ChangeLog	2012-12-06 17:53:26 UTC (rev 136851)
+++ trunk/LayoutTests/ChangeLog	2012-12-06 18:02:36 UTC (rev 136852)
@@ -1,3 +1,16 @@
+2012-12-06  W. James MacLean  <[email protected]>
+
+        [chromium] Should apply link highlight to largest enclosing node with a handCursor.
+        https://bugs.webkit.org/show_bug.cgi?id=104264
+
+        Reviewed by Adrienne Walker.
+
+        Add layout test to cover new functionality.
+
+        * platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-nested.html: Added.
+        * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-nested-expected.png: Added.
+        * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-nested-expected.txt: Added.
+
 2012-12-06  Zan Dobersek  <[email protected]>
 
         UndoManager layout tests should be removed

Added: trunk/LayoutTests/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-nested.html (0 => 136852)


--- trunk/LayoutTests/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-nested.html	                        (rev 0)
+++ trunk/LayoutTests/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-nested.html	2012-12-06 18:02:36 UTC (rev 136852)
@@ -0,0 +1,33 @@
+<!DOCTYPE html>
+<html>
+<head>
+<script src=""
+</head>
+<body _onload_="runTest();">
+<div style="-webkit-transform: translateZ(0); position: relative; left: 10; top: 40">
+<a href="" id="targetLink" style="-webkit-tap-highlight-color: rgba(0, 255, 0, 0.5)">Target <b id="nestedText">Nested</b> Link.</a>
+</div>
+<div style="position: relative; left: 10; top: 70">
+This test is successful if "Target Nested Link" above is covered in a transparent green rectangle with square corners.
+</div>
+<script>
+function runTest() {
+    var clientRect = document.getElementById('nestedText').getBoundingClientRect();
+    x = (clientRect.left + clientRect.right) / 2;
+    y = (clientRect.top + clientRect.bottom) / 2;
+    if (window.testRunner) {
+        testRunner.dumpAsText(true);
+        testRunner.waitUntilDone();
+    }
+
+    if (window.eventSender) {
+        eventSender.gestureTapDown(x, y);
+        window.setTimeout(function() { window.testRunner.notifyDone(); }, 0);
+    } else {
+        debug("This test requires DumpRenderTree.");
+    }
+}
+</script>
+</script>
+</body>
+</html>

Added: trunk/LayoutTests/platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-nested-expected.png (0 => 136852)


--- trunk/LayoutTests/platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-nested-expected.png	                        (rev 0)
+++ trunk/LayoutTests/platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-nested-expected.png	2012-12-06 18:02:36 UTC (rev 136852)
@@ -0,0 +1,22 @@
+\x89PNG
+
+
+IHDR X')tEXtchecksume4aaf7075e2a4f4bba51a7ebbf09f9bbAO\x90 IDATx\x9C\xED\xDD}\xB4Uu\x9D\xF8\xF1\xA2\xF8\x80"B\xA3\xADP@Ĕ0\xB4\xD0\x98je\xCB\x93\xAEh\xA6\xF9Q3\xB5\x92\xB14\x9BjY)\xD6\xCCZ\xAE\xA5Sk\x95di\x99V\x83J4|np(QS)2\x85\x80\xC0T\x90'A/\xB0\x9C;\x87\xE3y\xBA\x87\xCB{\xBD\xFEp\xF69{\xEF\xEF\xFE\xEE\xBD\xCF}{\xEF\xE1ҥ(\x8A \xCF\xFBzo6 \x99\xC0H&\xB0\x92	,\x80d \x99\xC0Hv`\xA3'\xAE\x8C+_\xCFqPvE\\xB1\xAF\x87\xEC\xDF\xC1H&\xB0\x92\xBD\xE1kǎ}=\x80\xDD\xD3\xF03X1yrg\x9EJ4mZ<\xF5T\xBC\xFAjD\xC4[\xDF\xFF\xEF\x9F#\xBAT\xEFzo\x8F\xA4\xBC\xFD\xE6\xFB\xAD\xFA\xE3ԩ1aB\xFD
+\xFE\xE5/q\xDF}q\xD1E\x83ޠVD\x8C\xEF~wt\xED\x93'\xC7\xE4\xC9\xF1\xCA+1{v<\xF2\xC8\xEB4\xB4.\x88\x88\x98<9\x88\xA7\x9F\x8EG\x8Bѣ\xE3\xEB_\x8F\xE5\xCB\xE3g?\x8B\xFA\xA78\xF6\xD8\xCEl\xF6׿\x8Eq\xE3Z}\xF1\xA5\x97\xC6\xFDW\x9D\xE5W\\xCF?\xD7_\xFF\xFA\xAFq\xCC1\xD5\xCF6\xAA\xAB\x88\xB8\xE3\x8Eش\xA9ս\xFB\xA7\xC6?"\xEC\xD7/ƌ\x89\xAE]w-9\xF8\xE08\xFB\xEC\xE8\xD7/Ϳu\xDEyѵk̚\xEB\xD6ŁƠA\x83\xC5A\xED\xF6\x8E֮\x8DGݍ\xD7\xF7\xE8Qy\x97.1`@D\xC4\xC0\x81q\xC0\xEE\xFC\x98\xF5_؍\xFB\xA7\xC6qp\xE1\x85q\xF0\xC1\xD59$.\xBC0yk\xD6t\xF0\x82~\xFD\xE2쳣\xAD-~\x{16B222}\xF3;jk\x8B[o\xDD\xC7\xEA:\xB0\xE9\xB7\x807\x85\xCE~\xBD\xFFӟ\xE2\x81⥗\xA2{\xF78\xEB\xAC5*\x96,\x89\xFB\xEE\x8Bѣ\xE37\xBF\x89\xBE}c\xE2\xC4X\xBB6\xEE\xB8#\x9E>\x86
+\x8Bs\xCFm\xFFN\xCF\xF6\xEDqｱ`A\xF4\xE9\xE3\xC7G\xEF\xDE\xF1\x8B_DDL\x9EÆ\xC5\xF9\xE7\xD7\xDFݙgƢE\xB1|y<\xF2h\x9Cq\xC6k\x9Eڸ1fώ\xC7\x8F.]bĈ8\xE7\x9C8\xFC\xF0\x88\x88\x85\xE3\x9E{b\xE3\xC6\xF6\x97M\x9E?\xFFy\xAC\\xD9\xFE\xB8\xF4\xDFF떖/Xg\x9D\xB5\xDB3\xB3dI\xDC{o\tQ\xFB\x84L\x983f\xC4/\xC4\xFB\xDF\xA7\x9F\xBE\xEBeE?\xFDi,[\xB6k<\xC0\x9BEgkΜ\xF8\xE4'\xA3G\x8Fx晘:5F\x8D\x8A3b\xEB\xD6\xE8\xDE=\xFE\xFD\xDF\xDB_3cF\x9CqF>\xDF\xFCft\xEB\x97]s\xE6\xC4\xDF\xFD]\xFC\xFD\xDF\xC7ҥq\xEF\xBD\xF1\xF1\x8FǤI\xED\x9F\xF1j\xE2\x80\xE2\xBC\xF3\xE2\x87?\x8C\xFB\xEF\x8FNx\xCDS\xDF\xFB^\xB4\xB5\xB5`kڴX\xBC8\xBE\x{125208};\xEF\x8C-[bҤX\xB2$~\xFD눈\x89w\xA5U\xF3u\xCB\xCBK\xB1\xDF-\xB7\xDF[\xB6\xECz\xB0hQ\pA\xACZ\xB7\xDD\xF6\x9A\xC0ڸ1z\xF5\x8Aq\xE3\xE2\xEDo\xDF\xED]ol\x9D\xFD5
+\xFF\xF6oѽ{<\xFEx\xDC{o\xBC\xF2JDĥ\x97FD\xB6\xEB5/\xBCC\x86\xC4AŘ1ѯ_\vYDēO\xC6m\xB7\xC5\xFEgL\x9B˗\xEF\xC6\x8F:\xAA\xE2\x85\xDA\xDA""N<1N<1"b۶\xF6\xE5\xA5\xEFE\xDD}wް\xDE\xAD[^~\xCA)\xBB1’\x8B/np\xC9%c\xC6D\x8F1hP\xBC\xFC\xF2\xAE\xD7̝\xB7\xDC#GƘ1\xED\xE3\xDED:\xFB\xAC矏;\xEF\x8CN\x88\xF1\xE3\xE3\xDAk#\xEA}\xBA\xE8\xD4S㡇⬳b\xE9\xD2غ\xB5}\xE1\x96-\x9D\xFF\x89ؘ1\xB1pa\xACX\xF1\x9A\x85]\xBADQ\xEC\xDAf\xF9#V\xE7\x9FӦŲeq\xDDuq\xC1\xF1ַ\xD6\xD9`\xA3u\xF7D\xF9\xA3\xF7\x95R\xF5A\xF8\x9D;\xE3\xB8\xE3\xDA?&\xBC\xE9t6\xB0f̈.\x88\xBE}w\x95S\xAD\xD3N\x8B;\xEE\x88\xDF\xFD.z\xF7\x8E\xF1\xE3\xDB}\xF4\xAE,X'\x9D\xB4;-\xFF\xA0p\xFB\xF6]{\xF6\x8C\x97^\x8A/}\xA9\xFA[A}\xFA\xC4g>\xF7\xDDs\xE7ƌ\xF1\xC5/\xD6\xD9`\xA3u\xCB*wԡ+\xE2\xDE{\xE33\x9F\xE9\xF8\x95\xA3G\xC7\xC3\xC7\xFD\xF7\xC7{߻\xDB\xF6\xFD\x88\xB0(\xE2\xB9\xE7""V\xAE\x8C\xA2\xE2o\xF0m\xDE/\xBE\x9B6ş\xFE]\xBAī\xAFƆ
+\xAF-\x92[o\x8D\xF8\x87\xB8\xEC\xB2\xF8\xDC\xE7v}iР\x987/\xB6n\x8D'\x9E\x88'\x9F\xFC\xBFQO?\xD7]\xF7\x9A]o\xDFK\x96DD,Z\xD4\xFE3\xBB\x888\xEA\xA88\xE7\x9C׼\xEC\xE4\x93#"|0\xB6m\x8BG\x8D\xE9\xD3ۗO\x9E\xF3\xE6\xB5"\xBE<\xF2ҷ\x97\x96,\x89\x9Bnj\xB6n\xE9e\xC6\xFEо\xA4\xFCa\xF9\xAAiY\xBF>"b\xE7\xCEX\xB5*~\xF5\xAB>\xBC}6l\x88\x97^ڵb\xE9\xBF6\xB4\xBF~Ӧ3&>8~\xFB\xDB\xDEt\xBAE\xFD_|pe\\xD1\xF8W\x96ϝ\xB3f\xC5\xD1GDŽ	q\xE3\x8D1th<\xF0@DđG\xC6\xE7?\xDF\xFE\x9A\x9Bn\x8A\xA7\x9Fn|\xF0\xC1\xF1\x81Ĉ\xF1\xEA\xABq\xC7\xF1\x97\xBFD\xBF~\xF1яF\xEF\xDE3g\xC6\xE2\xC5q\xFE\xF9q\xDCqu\xF6U\xF5ǝ;\xE3\xC6\xE3_\xFE\xA5\xFD\x8F۷\xC7}\xF7œOFQİa\xF1\xC1F\xB7n\xED\xAF\xFF\xC7\x8C\xFF\xF9\x9Fغ5>\xFA\xD1\xF6\xC2{\xEC\xB1\xF8\xDF\xFF\x8DC\x8D\xF1\xE3\xE3-oi\xB8n\xE9o.Zc\xC7ƽ\xF7\xD6Oݟrv\xED_\xFCb\}u\xF5\xF2\xBA\xE1/\xF5\xDF̙1hP\xACX_\xFBZ\xFC\xF7\xC7'>W\xC4u6\xEC?:
+\xACN[\xBD:6m\x8A㏏\x88ع3V\xAF\x8E\x9Bo\x8E\xAF~u\x8F\xB6\xF9\xB7A`\xC0\xFE\xAEq`M\xEE\xF2:\x85\x92+&\xEF\xC1/S\xDE:\xF5\x8F=\xB7b\xF1\xE2x\xF8\xE1X\xBD:v=\xE3\xC4c̘8\xE4\x90=\xDA&\xC0\xFE`\xAF\xFD\xCB-C\x86Đ!{k\xE3o`
+D@\xE7t\xF67\xB9Ѐ\xC0H&\xB0\x92	,\x80d
+\xABKcw\xDF}\xF7\x90zC\xF0\xC3\xFE\xF0\xDEj\xAF\xFF\xF7P[[ۗ\xBF\xFC\xE5\xBE}\xFB\xF6\xEF\xDF\xFF\xDA\xD2?\x92]\xA1Ém\xB4\xFAi\xA7\x9DV\xFEo\x93\xB7\xB7\x8E\xAAªU\xABJ\xFB\xBA\xF0\xC2+\x97\xBF>#\xA9;\x81\xCDw\xDD\xE4\xBA뮻\\xF7\xA9\xCA	\xEFܨ\xF6\x86\xFD\xEBvx㼍\xF0F\x96{\xFB\xD4^]\xAF\xDB\xED\xC9ߢ\xA2\x81\x88\xB8\xFC\xF2\xCB_y\xE5\x95\xD2\xE3\xA2(6l\xD8\xF0\x85/|!"\xFA\xF7\xEF\xDFdE\x9A\xB8\xEC\xB2\xCB~\xF9\xCB_\xAE_\xBF~ڴi'\x9DtRճh>\xB1\x8DV/\xADU\xFEo\xA3\x97~8MDď\xFC\xE3\xF2w\xEC\xD8\xF1裏Fģ\x8F>\xBA}\xFB\xF6\xBD\xB4\xD3~\xFD\xFA\xD5\xE6\x8E;\xE6Ν\x8F=\xF6X[[[\xEB[kr:*'\xBCC\xEA\x9E,\xA8\xD2\xE1\xBB\xE2r{\xB2\xF74\xFC5
+Ç\xF8ᇏ8∈\xE8ҥ\xFDe6l8\xF3\xCC3\xFF\xFB\xDFz衍V\xECPyk{u\x957\xA6\xE3\x8E;n\xE9ҥ\x95\xFE1\xE9۶mk>\xB1\x8DV/\xCDO\xE9\xBFMN\xDC\xFC\xF9\xF3\xF3e\xD7~=5nܸo}\xEB[\xA3F\x8Dj\xE5\xF5\x9D\xD8E\xAD&؉]w\xB8\xB5\xB7\xD9\xE1i\xFD\xDB\xF4:L\xCB~\xFD\xBE\xB1_>\xF2ƿ\x97\xAE\x93\xF2\xF0ܞ\xEC=
+D8\xFE\xFC\xD2\xE9J={\xF6\x9C?\xFE!-\xFCB\xF6\xA2(\xB6l\xD9R\xBB|\xC1\x82\xAD\xABr\xF5N\xAC\xB2\xBB\xCFf\xA9\xDDKՒg\x9F}\xB6Q]ED\x87\xDB|\xF5\x92&'\xAE\xF9\x8A\xBB\xAB\xC3\xF3r\xF3\xCD7O\x9A4i\xF5\xEAջ\xB5\xD9N\x9C\xFA\xB2V\xAE\xCC\xD7k\xB9\xA3j\xD1\xEBs\xC1=-\xBB{\xF14\xF1\xFAOf\xE2\xE0\xF7\x89\xC4\xF1\xEF\x8D\xEB\xA4rx-n\xFF\x8DC\xED%\xB3\x9E\xA3\x95osվ,"\x96.]:z\xF4\xE8=z\\xFD\xF5EQ\x94>\xB0Rz\xF6\xFA\xEB\xAF?\xEC\xB0\xC3\xCE?\xFF\xFC\xDAO<\xF1\xC4\xD2~Ǐ_Ŷm\xDB>\xFB\xD9\xCF\xF6\xEE\xDD{\xF4\xE8\xD1\xFD\xEB_\xEB\xAE^\xB5JY\x8B{\xAC}\xB6\xF2\xC0+\xEFر\xE3\xF2\xCB/\xEF߿\xFF\xFE\xFD\xF4\xA35Y\xD8ʰ\xED\xB7v\xF2\xABW
+\xBE|\x98\xBB{\xD6\xEAn\xED\xE6\x9Bo<xp\xB7n\xDDx\xED\xB5\xD7Eq\xF7\xDDw:\xF4\xFB\xDF\xFF~\xBF~\xFD\xDE\xFD\xEEwE\xB1x\xF1\xE2\xB1c\xC7\xF6\xE8\xD1\xE3S\x9F\xFAT\xF9\xC7y\xB5\x87\xDC\xE8\xBCT\xEEzΜ9\xE7\x9CsΫ\xAF\xBEZ;\x9EN\x9C\xFA\xBA\xABE1cƌ\xA1C\x87~\xF8\xE1\xB7\xDCrK\xA3ɩ\xBB\xBC<\xB7\xA5IX\xBAt\xE9g\x9CѣG\x8F뮻\xAEr\xAD;v\xBC\xE7=\xEFiq\xE6kg\xB8\xB4\x9D\xDF\xFC\xE67Æ
+;ꨣ~\xF8\xC3V\xBE~\xFA\xF4\xE9\xFD\xFB\xF7\xEFӧ\xCF~\xF0\x83\xA2(\xEE\xB9\xE7\x9EҎ
+T\xC5'>\xF1\x89\xD2_x\xE1\x85F\x87_u,\xB5\xD3X\xA5\xEE%\xBD\x87#\xA9\xBD\x8A:w\xB2:<#NuY\xE5\xC5S;\xBCF7B\xED\xAB&\xF3\x9E{\xEE6lؼy\xF3N9\xE5\x94^\xBDz\xDDz\xEB\xADM\xC6\xD3ʴ\xD4\xDDo\x93\x9B\xAB\xF6\xF6lq\xF2[\xDCu\xA5\xB7\{EU\x8D\xBF\xF5ٮ\xFB\xE6S\xBEN\x9A\xDCK\x96,)\xED\xF1\xD2K/-=\xEEڵ\xEB\xE1\x87~\xD3M7}\xF6\xB3\x9F-=u\xDBm\xB7\x95\xAE\xAE\xAA\xE1\xD5~9\xABR\xF7\x86\xBA\xFD\xF6\xDBO>\xF9\xE4#\x8E8\xE2\xC1\x9C0aB\xD1\xF8+K\xE7.\x8C*-޶\xB5o4խ\xDC\xC5\xCD\xDFI\xE8P\xE7\xEB\xDAk\xAF]\xB3f͌3\x8E9\xE6\x98ⵟ\xA8\xE8ݻ\xF7\xFC\xF9\xF3\xA7M\x9BV\xF7\xACT.\xBC\xFC\xF2\xCBo\xBE\xF9\xE6\x97_~yƌ\xF9\xC8G\xAD^w;\xAD\xEF\xB1\xEAٿ\xFE\xF5\xAF\xE5\x97-^\xBC\xB8\xFC\xF8\xDB\xDF\xFE\xF6\xFC\xC7lܸ\xF1G?\xFAѰaÚ,lq\xD8M\xA4\xD1j\xC7_y\x98\xBB{\x95׾~\xE8С˗/okk{\xE0\x81z\xF4\xE8QőG\xBF\xF8\xC5/ʯ9r\xE4ԩS\xB7l\xD9\xF2\x8Do|#"\xBAw\xEF\xDE萛\x8C\xA7\xFC\xD4w\xBE\xF3\x9D\xCF}\xEEs\xB5\xAF\xEFĩ\xAF\xBBʃ>8z\xF4\xE8E\x8B\xADY\xB3\xE6\xAB_\xFD\xEAnVynK\xAE\xBE\xFA\xEA\x95+W\xDEu\xD7]}\xFB\xF6\xAD\kŊ'N\xBC\xFA\xEA\xABW\xADZ\xD5\xE8x\xCBjg\xB8\xB4\x9D\xA9S\xA7\xAE_\xBF~\xFE\xFC\xF9\xA7\x9F~\xFA̙3K\xCB{\xEC\xB1\xF7\xBD\xEF}\xCF?\xFF\xFCw\xDCѳg\xCFٳgE\xF1\xE2\x8B/~\xF8\xC3޼ysQmmm\xA3F\x8Dڶm[\xA3ï=\x96\xBA\xD3X\xA9\xEE%\xBD\x87#\xA9\xBD\x8A:w\xB2:<#Nu\xA5\xF2\xF6k\x87W\xBBn\xA3=VMf߾}#\xE2?\xF8\xC1ڵk/^<jԨ\xDBo\xBF\xBD\xD16[\x99\x96\xE6\xD7^\xAD\xDA۳\xC5\xC9o}\xD7e-n\xB9\xEEU9\xFE\xD6g\xBB\xEE\x9BOyS\xCDo\x81+V\xF4\xEF\xDF\xF5\xEA\xD5EQ\xECܹs\xC0\x80\xA5\xF6\xD9g\x9F0`\xC0\xBAu\xEB\xBD\x97\xD6~9\xABR{C͜9sҤI\x8B/^\xB9r婧\x9E\xDA\xFC+K\xE7.\x8C*\xAD߶Uo4խ\xDC\xC5\xCD\xDFI\xE8P\xE7\xAB\x{120B6D}\xADk׮EQ\xBC\xFC\xF2\xCB\xE5\x85'\x9Ex\xE2\x94)S}\xA0\xB8rk\xC7|\xFC\x9F^\xBDz5Z\xBD\xEE\xD9m}\x8F\xCD7X~<dȐ\xF5\xEB\xD7W\xAD[wa\x8B\xC3nq\xBF\x95\x8Fk\x8F\xB4\xF20\xF7<\xB0\x8A\xA2ضm\xDB
+7\xDC0bĈҳ[\xB7n\xADzY\xF7\xEE\xDD7m\xDAT\xC5ƍ\xCB\xA5\xAF{ȭVQ\xE7\x9F~\xE9\xEF{x\xEA\xEB\xAE\xF2\x9E\xF7\xBC\xE7\xF1\xC7/=^\xB7n\xDDnVyn+'a\xFB\xF6\xED\x95\xFE\xFD\xEF\xFF\xD4SO\x9D;wn\xA3#\xADU5\xC3U{\xFC\xF1\xC7njSz|\xF6\xD9g/[\xB6\xAC\xF4\xF8'?\xF9\xC9\xF0\xE1\xC3K\x8F?\xFF\xF9ϗjΜ9_\xF9\xCAW\x9A~\xED\xB1\xDDu/\xE9=I\xEDUԹ\x93\xD5\xE1\xA9R;Օ\xCAk\x87W\xBBn\xA3=VM\xE6\xE6͛+7\xF5\xD0C\x9Dp\xC2	\xADl\xB3\x95\xA9\xAB\xBA\xF6\xEAr\xED\xED\xD9\xE2䷾\xEB\xB2\xB7\\xF7\x8A\xAAZ\xB1\xC5ٮ\xFB\xE6S~\xB6\xF9-P\xC5ĉKo5s\xE7\xCE\xEDҥK\xE9\x9B:\xD7\sM\xE9\xD2m\xF4^Z~\\xFErV\xA5\xF6\x86\xFA\xF4\xA7?]~\xBCiӦ\xE6\x9Bm~\xF8-Z\xEB\xB7m\xD5\xC6Mu+wq\xF3w:\xB4\xA7\x81Uԋ\x83g\x9Ey\xE6\xE3\xFF\xF8\xDB\xDE\xF6\xB6\x87z\xA8\xF9֎8\xE2\x88\xDAԮ\xDE\xE1W\xCD\xE6{l\xBE\xC1\xF2\xE3nݺծ[wa\x8B\xC3nq\xBFE\xD3\xC0\xEA\xF0\xD9&j_?o޼\x91#GN\x9E<y\xE1…\x8D6;iҤ\xCB/\xBF|˖-ӦM+\xFF\xFF\\xDDCn2\x9Eʧ6m\xDAtꩧ\x96\xFEaya'N}\xDDUz\xF5\xEAU\xFAK\xF3!u\xB8\xBC\xD1\xE9\xF8\xEEw\xBF{\xD1E\xD5]\xB7\xAEgx˖-\xA5\xD5Eq衇\x96\xDF47o\xDE|\xD8a\x87\x95\xFF\xEEw\xBF+\xBD\x83O\x980\xE1\xF8Cia\xDDï{,\xCDo\x87\xBA\x97\x{11E3E4}j\x86;}\xB2:\xFCZUVw\xAA
+\xA9\xEA\x9E\xA6&\x93Y\xF9\xB2͛7|\xF0\xC1-n\xB3ha\xEA:\xBC\xD9\xEBޞ\xAD\xEC\xA5\xF5]7zA\xA3\x8DԽ\xA2*Wl}\xB6\x9B]\x87\xB7\xC0̙3?\xF4\xA1E\xF1\xC9O~\xF2\x92K.y\xFF\xFB\xDF_\xC5\xC9'\x9F\xFC\xE7?\xFF\xB9jS\xBEW\xAA\xBD\xFA\xF4\xE9\xB3cǎڵ\xEAn\xAA\xD3F\xA5ݺm\xAB6^wT\xAD\xDC\xC5\xCD\xDFI\xE8\xD0^	\xAC\x92Y\xB3fw\xDCqͷv\xD6Yg\x95O\x9B6\xAD\xD1\xEA-~\xD5l\xB4Ǻ\xAC\xFC\xFF֭[\x8B\xA2\xE8۷o\xEDo\xA8\xBB\xB0\xC5a7?\x90\xBAc\xD8ہ5lذE\x8BE\xB1v\xED\xDAF\x9B}\xE2\x89'\xCE8\xE3\x8C\xEEݻ\x9F|\xF2ɥ\xEF9
+\xB9\xC5\xC0*\x8Ab\xE1…\xA5_6S^҉S_w\x95\x89'\x96\xB9aÆ\xF2L6Ϝ9sN;\x{DD22}\xA3w\xC6҃k\xAE\xB9\xE6\xB2\xCB.kt\xA4U:\x9C\xE1Gy\xE4\xF4\xD3O/=1b\xC4-\xB7\xDCRz\xBCbŊq\xE3ƕ_v\xD2I'-\\xB8\xB0\xF2\x97q4\x99\xB1\xBA\xC7\xD8\xE8v\xA8{I\xEF\xF9H\xAA\xF6\xDE\xE9\x93\xD5z`՝꺛\xAA\xDDB\x87\xA7\xA9\xC9dFD\xF9c\x85\xF3\xE7\xCF?\xE5\x94SZ\xDCf\xD1\xC2\xD4ux\xB3׽=[\xD9K뻮\xD4ʖ\xEB^Q\x95+\xB6>\xDB͏\xAE\xC3[`\xEB֭}\xFA\xF4Y\xB2d\xC9\xE0\xC1\x83_y\xE5\x95c\x8E9f֬Y#G\x8E\xAC\xDD\xD1nVI\xE550p\xE0\xC0g\x9F}\xB6\xF4\xF8\xA5\x97^\xAA\xDCl\xED\xBBz\xA7/\x8CJ\xBBu۶X\xAD\xBF\xA57\xFF\xC2J|\xC1.\xFF\xFA\xA2\xB9s疃\x{699DE288}\xD2\xE5\xB5r\xE5ʈX\xBE|\xF9\xF2\xE5\xCBK\x8A\xA2\x88\x88\xE9ӧ/X\xB0\xA0O\x9F>\xB5\xDB<\xF0\xC0gϞ\xFD\x{1B7FFD}(\x8Ao~\xF3\x9B7\xDCpúu\xEB~\x{1B37DD}w\xDEy\xEDc\xAAY\xBDr\x95\xB2\xD6\xF7X\xFB\xEC\x91Gy\xE7\x9Dw\xBE\xF0\xC2\xDF\xFB\xDE\xF7"\xA2\xFF\xFEEQL\x980a֬Y;v\xECx\xF2\xC9'K\xECm\xB4\xB0\xC5aW-y\xFA\xE9\xA7#\xE2\x91Gٹsg\xDD1\x94\x8E\xE8\x99g\x9E\xA9{\x98U\xABw\xE2\xC4Eѻw\xEF\xDBn\xBB\xED\xB9\xE7\x9E\xFB\xCEw\xBEs\xC0l޼yŊQ\xFAlM\xC9\xF0\xE1ß~\xFA\xE9\xAA
+\xD6=\xE4\xBA\xE7\xA5Ѯ\xA7O\x9F^y\xF7v\xE2\xD4\xD7]e͚5\xEFz׻fϞ\xBDaÆ/\xF9\xCBq\xF4\xD1G\xD7\xCFSO=UE[[\xDB\xFF\xF8\xC7\xC1\x83_s\xCD5\xE5\xB9]\xB6lY\xF9\x92~\xF6\xD9g#bŊ\xA5\xEB|\xE5ʕEQ\u\xD5UW^ye\x87\xD3^w\x86\x8B\xA2\xE8޽\xFB\xF5\xD7_\xBFnݺ\xF9\xF3\xE7\xBF\xE3\xEF\xB8\xFB\xEE\xBBK/~衇\x8E=\xF6\xD8ٳg\xAFZ\xB5j\xFC\xF8\xF1\xF3\xE6\xCD+o\xE7k_\xFBڠA\x83*î\xEEᗵ~;Խ\xA4\xF7p$\xB5WQ\xE7NV\xF33\xD2\xCATW*_<\xB5ë]\xB7\xD1\xEB\xDE\xD7_|\xF1ƍ\x97-[6v\xEC؟\xFF\xFC獶\xD9ʴ4\xDAoݛ\xAB\xA8w{\xB68\xF9\xAD\xEFzw\xB7\\xF7\x8A\xAA\xEB\xB3]{t\x95\xEF\x8A\xCDo\x81\x92\x8F}\xECc#F\x8C\xB8ꪫ\x8A\xA2\x988q\xE2\xB1\xC7;eʔ\xCAM\x95\xEE\x91\xF2\xF0\xEA~9\xAB\xDAf\xED5p\xF1\xC5_t\xD1E/\xBE\xF8\xE2ڵkK\xBFT\xB9\xB4\xBC\xEEW\x96\xCE]UZ\xBFm\xAB6\xDEh\xAA[\xB9\x8B\x9B\xBF\x93С+^\xABja\xED\xCA\xFC\xE3\xF7\xE9ӧ\xEE\xDF\xFD\xF9\xF4\xA7?}\xD4QG\xFD\xF6\xB7\xBF-\x8AbӦM&L\xE8ѣ\xC7;\xDF\xF9\xCE\xF2_\x9D\xA8]\xBDr\x95ڱu\xB8\xC7\xDAg\xAF\xBB\xEE\xBA\xEEݻ\x8F9򩧞<x\xF0]w\xDDUŚ5k\xCE=\xF7\xDC^\xBDz\x9D~\xFA\xE9?\xFD\xE9OK\xAF\xAC\xBB\xB0\xC5aW-\xA9\x9A\xA5\xDA1T\xCDs\xDDSP\xFB\x82\xD6O\QS\xA6L9\xE2\x88#\xCE<\xF3̗^zi\xF8\xF0\xE1_\xFF\xFA\xD7K/(߱EQ\x8C;\xB6\xBCb\x8F=n\xBC\xF1\xC6F\x87\xDC\xFC\xBC\xD4\xF5\x92K.)?\xEEĩ\xAF\xBBJQ,6l\xD8\xC0\x81\xEF\xBF\xFF\xFE\xE3\x8F?\xFE\xCE;\xEF\xECp:蠺\xBF?\xA2\xEE닢\xB8\xE1\x86"bܸq\xE5o\xC27R;\xC3EQ̛7o̘1\x87vبQ\xA3f͚U\xF5\xFA^\xBDzs\xCC1ӧO\xAF\\xFE\xE7?\xFF9"ʟXjr\xF8U\x87Yw+ս\xA4\xF7p$\xB5WQ\xD6ɪ:\xB4\xA7\xBAR\xF9\xE2\xA9^\xA3\xA1v\x8F\xB5\x93S\xA6L\xE9޽\xFB	'\x9CP\xBA;\x9Ao\xB3\xF9\xB44\xDAoݛ\xAB\xA8w{\xB68\xF9\xAD\xEF\xBA\xEAtt\xB8\xE5\xBAWT\xE5\xF8[\x9F\xEDFGWz\xB6\xF9-P2u\xEA\xD4C9\xE4\xC5_,\x8A\xE2\xF6\xDBo\xEF֭\xDBڵk+\xA7jz[\xB9\xD2j\xAF\x81-[\xB6L\x9C8\xB1gϞ'N\xAC\xFC\xE8Rݯ,\x9D\xBB0\xAA\xB4~\xDBVm\xBC\xD1\xB6r\xD7\xF8?\xF8\xC1\xBA\xD3N]\xFB\xF7\xEF\xB2#ݓO>\xF9\xDCs\xCF}\xE0\x88\x88\xED۷?\xF1\xC4\xEF}\xEF{ׯ_\x9F\xB2\xF1\xED۷x\xE0\x81)\x9B\x82}e\xFE
+нz{\xEEs\xFB\xEF\xD1\xED\xEF\xBF\x96\xBD\xC4?\xF6\xCCk\x9C{\xEE\xB9˖-[\xBDz\xF5\xF6\xED\xDBׯ_?k֬}\xE8CYWW\xEC\xEFJ?Ez\xFE\xF9\xE7\xF7\xC9\xDE\xF7\xEA\xED\xB9\xCF\xED\xA7G\xF7\xCC3\xCFD\xC4s\xCF=\xB7\xAF\xC2\x8E\xC0\xE25\xBE\xFB\xDD\xEF\xDEr\xCB-C\x86\xE9ݻ\xF7\xD9g\x9F\xBDiӦ)S\xA6\xEC\xEBA\xC1\xC5\xC0\x81#\xA2\xF4\xE4\xBD\xFE\xDEܷ\xE7~zt\xC7{lD\xBC\xE5-o\xD9\xD7\xE1
+\xC776\x92\xF9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\xC8(\xEF\xC2IDAT\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@2\x81\x90L`$X\xC9@\xB2\xFF>s\x8C\xD25\xE9e\xB2IEND\xAEB`\x82
\ No newline at end of file

Added: trunk/LayoutTests/platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-nested-expected.txt (0 => 136852)


--- trunk/LayoutTests/platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-nested-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-nested-expected.txt	2012-12-06 18:02:36 UTC (rev 136852)
@@ -0,0 +1,2 @@
+Target Nested Link.
+This test is successful if "Target Nested Link" above is covered in a transparent green rectangle with square corners.

Modified: trunk/Source/WebKit/chromium/ChangeLog (136851 => 136852)


--- trunk/Source/WebKit/chromium/ChangeLog	2012-12-06 17:53:26 UTC (rev 136851)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-12-06 18:02:36 UTC (rev 136852)
@@ -1,3 +1,17 @@
+2012-12-06  W. James MacLean  <[email protected]>
+
+        [chromium] Should apply link highlight to largest enclosing node with a handCursor.
+        https://bugs.webkit.org/show_bug.cgi?id=104264
+
+        Reviewed by Adrienne Walker.
+
+        Link highlights sometimes only apply to part of a link, if we select an enclosed
+        node (e.g. font changes in link text). The highlight should be applied to the
+        largest enclosing node that still has handCursor set.
+
+        * src/WebViewImpl.cpp:
+        (WebKit::WebViewImpl::bestTouchLinkNode):
+
 2012-12-06  Tommy Widenflycht  <[email protected]>
 
         Speech Recognition API: Change the error code to a string on SpeechRecognitionError

Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (136851 => 136852)


--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2012-12-06 17:53:26 UTC (rev 136851)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2012-12-06 18:02:36 UTC (rev 136852)
@@ -1221,6 +1221,10 @@
     while (bestTouchNode && !invokesHandCursor(bestTouchNode, shiftKey, m_page->mainFrame()))
         bestTouchNode = bestTouchNode->parentNode();
 
+    // We should pick the largest enclosing node with hand cursor set.
+    while (bestTouchNode && bestTouchNode->parentNode() && invokesHandCursor(bestTouchNode->parentNode(), shiftKey, m_page->mainFrame()))
+        bestTouchNode = bestTouchNode->parentNode();
+
     return bestTouchNode;
 }
 

_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to