Title: [136887] trunk/Source/WebCore
- Revision
- 136887
- Author
- [email protected]
- Date
- 2012-12-06 14:10:11 -0800 (Thu, 06 Dec 2012)
Log Message
[V8] Make an Isolate mandatory in v8UnsignedInteger()
https://bugs.webkit.org/show_bug.cgi?id=104235
Reviewed by Adam Barth.
No tests. No change in behavior.
* bindings/v8/ArrayValue.cpp:
(WebCore::ArrayValue::get):
* bindings/v8/V8Binding.h:
(WebCore::v8UnsignedInteger):
* bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (136886 => 136887)
--- trunk/Source/WebCore/ChangeLog 2012-12-06 22:08:33 UTC (rev 136886)
+++ trunk/Source/WebCore/ChangeLog 2012-12-06 22:10:11 UTC (rev 136887)
@@ -1,3 +1,19 @@
+2012-12-06 Kentaro Hara <[email protected]>
+
+ [V8] Make an Isolate mandatory in v8UnsignedInteger()
+ https://bugs.webkit.org/show_bug.cgi?id=104235
+
+ Reviewed by Adam Barth.
+
+ No tests. No change in behavior.
+
+ * bindings/v8/ArrayValue.cpp:
+ (WebCore::ArrayValue::get):
+ * bindings/v8/V8Binding.h:
+ (WebCore::v8UnsignedInteger):
+ * bindings/v8/V8LazyEventListener.cpp:
+ (WebCore::V8LazyEventListener::prepareListenerObject):
+
2012-12-06 David Hyatt <[email protected]>
[New Multicolumn] Add requiresBalancing booleans to track which column sets need to rebalance.
Modified: trunk/Source/WebCore/bindings/v8/ArrayValue.cpp (136886 => 136887)
--- trunk/Source/WebCore/bindings/v8/ArrayValue.cpp 2012-12-06 22:08:33 UTC (rev 136886)
+++ trunk/Source/WebCore/bindings/v8/ArrayValue.cpp 2012-12-06 22:10:11 UTC (rev 136887)
@@ -60,12 +60,12 @@
if (index >= m_array->Length())
return false;
- v8::Local<v8::Value> indexedValue = m_array->Get(v8UnsignedInteger(index));
+ ASSERT(m_isolate);
+ ASSERT(m_isolate == v8::Isolate::GetCurrent());
+ v8::Local<v8::Value> indexedValue = m_array->Get(v8UnsignedInteger(index, m_isolate));
if (indexedValue.IsEmpty() || !indexedValue->IsObject())
return false;
- ASSERT(m_isolate);
- ASSERT(m_isolate == v8::Isolate::GetCurrent());
value = Dictionary(indexedValue, m_isolate);
return true;
}
Modified: trunk/Source/WebCore/bindings/v8/V8Binding.h (136886 => 136887)
--- trunk/Source/WebCore/bindings/v8/V8Binding.h 2012-12-06 22:08:33 UTC (rev 136886)
+++ trunk/Source/WebCore/bindings/v8/V8Binding.h 2012-12-06 22:10:11 UTC (rev 136887)
@@ -189,10 +189,9 @@
return v8Integer(value, v8::Isolate::GetCurrent());
}
- inline v8::Handle<v8::Integer> v8UnsignedInteger(unsigned value, v8::Isolate* isolate = 0)
+ inline v8::Handle<v8::Integer> v8UnsignedInteger(unsigned value, v8::Isolate* isolate)
{
- if (UNLIKELY(!isolate))
- isolate = v8::Isolate::GetCurrent();
+ ASSERT(isolate);
return V8PerIsolateData::from(isolate)->integerCache()->v8UnsignedInteger(value, isolate);
}
Modified: trunk/Source/WebCore/bindings/v8/V8LazyEventListener.cpp (136886 => 136887)
--- trunk/Source/WebCore/bindings/v8/V8LazyEventListener.cpp 2012-12-06 22:08:33 UTC (rev 136886)
+++ trunk/Source/WebCore/bindings/v8/V8LazyEventListener.cpp 2012-12-06 22:10:11 UTC (rev 136887)
@@ -185,11 +185,11 @@
v8::Local<v8::Object> thisObject = v8::Object::New();
if (thisObject.IsEmpty())
return;
- if (!thisObject->ForceSet(v8UnsignedInteger(0), nodeWrapper))
+ if (!thisObject->ForceSet(deprecatedV8Integer(0), nodeWrapper))
return;
- if (!thisObject->ForceSet(v8UnsignedInteger(1), formWrapper))
+ if (!thisObject->ForceSet(deprecatedV8Integer(1), formWrapper))
return;
- if (!thisObject->ForceSet(v8UnsignedInteger(2), documentWrapper))
+ if (!thisObject->ForceSet(deprecatedV8Integer(2), documentWrapper))
return;
// FIXME: Remove this code when we stop doing the 'with' hack above.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
