Diff
Modified: trunk/LayoutTests/ChangeLog (136912 => 136913)
--- trunk/LayoutTests/ChangeLog 2012-12-07 01:45:07 UTC (rev 136912)
+++ trunk/LayoutTests/ChangeLog 2012-12-07 01:48:46 UTC (rev 136913)
@@ -1,3 +1,18 @@
+2012-12-06 Dominic Cooney <[email protected]>
+
+ Element.pseudo property should be prefixed
+ https://bugs.webkit.org/show_bug.cgi?id=104060
+
+ Reviewed by Hajime Morita.
+
+ Updated tests.
+
+ * fast/dom/shadow/pseudo-attribute-dynamic.html:
+ * fast/dom/shadow/pseudo-attribute-expected.txt:
+ * fast/dom/shadow/pseudo-attribute-rendering.html:
+ * fast/dom/shadow/pseudo-attribute.html:
+ * fast/dom/shadow/shadow-pseudo-id.html:
+
2012-12-06 Li Yin <[email protected]>
[Chromium] Unreviewed, webaudio/audioparam-connect-audioratesignal.html is flaky
Modified: trunk/LayoutTests/fast/dom/shadow/pseudo-attribute-dynamic.html (136912 => 136913)
--- trunk/LayoutTests/fast/dom/shadow/pseudo-attribute-dynamic.html 2012-12-07 01:45:07 UTC (rev 136912)
+++ trunk/LayoutTests/fast/dom/shadow/pseudo-attribute-dynamic.html 2012-12-07 01:48:46 UTC (rev 136913)
@@ -24,12 +24,12 @@
var shadowRoot = new WebKitShadowRoot(host);
var div = document.createElement('div');
-div.pseudo = 'x-foo';
+div.webkitPseudo = 'x-foo';
div.innerHTML = "This should be blue.";
shadowRoot.appendChild(div);
setTimeout(function() {
- div.pseudo = 'x-bar';
+ div.webkitPseudo = 'x-bar';
if (window.testRunner)
testRunner.notifyDone();
}, 0);
Modified: trunk/LayoutTests/fast/dom/shadow/pseudo-attribute-expected.txt (136912 => 136913)
--- trunk/LayoutTests/fast/dom/shadow/pseudo-attribute-expected.txt 2012-12-07 01:45:07 UTC (rev 136912)
+++ trunk/LayoutTests/fast/dom/shadow/pseudo-attribute-expected.txt 2012-12-07 01:48:46 UTC (rev 136913)
@@ -1,14 +1,14 @@
This test checks pseudo attribute is exposed correctly.
-PASS div.pseudo is ''
+PASS div.webkitPseudo is ''
PASS div.getAttribute('pseudo') is null
-PASS div.pseudo is 'foo'
+PASS div.webkitPseudo is 'foo'
PASS div.getAttribute('pseudo') is 'foo'
-PASS div.pseudo is 'bar'
+PASS div.webkitPseudo is 'bar'
PASS div.getAttribute('pseudo') is 'bar'
-PASS div.pseudo is ''
+PASS div.webkitPseudo is ''
PASS div.getAttribute('pseudo') is null
-PASS div.pseudo is 'first-letter'
+PASS div.webkitPseudo is 'first-letter'
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/dom/shadow/pseudo-attribute-rendering.html (136912 => 136913)
--- trunk/LayoutTests/fast/dom/shadow/pseudo-attribute-rendering.html 2012-12-07 01:45:07 UTC (rev 136912)
+++ trunk/LayoutTests/fast/dom/shadow/pseudo-attribute-rendering.html 2012-12-07 01:48:46 UTC (rev 136913)
@@ -20,13 +20,13 @@
<script>
var shadowRoot1 = new WebKitShadowRoot(host1);
var div1 = document.createElement('div');
-div1.pseudo = 'x-foo';
+div1.webkitPseudo = 'x-foo';
div1.innerHTML = "This text should be red.";
shadowRoot1.appendChild(div1);
var shadowRoot2 = new WebKitShadowRoot(host2);
var div2 = document.createElement('div');
-div2.pseudo = '-webkit-foobar';
+div2.webkitPseudo = '-webkit-foobar';
div2.innerHTML = "This text should not be red.";
shadowRoot2.appendChild(div2);
</script>
Modified: trunk/LayoutTests/fast/dom/shadow/pseudo-attribute.html (136912 => 136913)
--- trunk/LayoutTests/fast/dom/shadow/pseudo-attribute.html 2012-12-07 01:45:07 UTC (rev 136912)
+++ trunk/LayoutTests/fast/dom/shadow/pseudo-attribute.html 2012-12-07 01:48:46 UTC (rev 136913)
@@ -10,24 +10,24 @@
<script>
var div = document.createElement('div');
-shouldBe("div.pseudo", "''");
+shouldBe("div.webkitPseudo", "''");
shouldBe("div.getAttribute('pseudo')", "null");
div.setAttribute("pseudo", "foo");
-shouldBe("div.pseudo", "'foo'");
+shouldBe("div.webkitPseudo", "'foo'");
shouldBe("div.getAttribute('pseudo')", "'foo'");
-div.pseudo = "bar";
-shouldBe("div.pseudo", "'bar'");
+div.webkitPseudo = "bar";
+shouldBe("div.webkitPseudo", "'bar'");
shouldBe("div.getAttribute('pseudo')", "'bar'");
div.removeAttribute('pseudo');
-shouldBe("div.pseudo", "''");
+shouldBe("div.webkitPseudo", "''");
shouldBe("div.getAttribute('pseudo')", "null");
// Checks pseudo accepts known pseudo-element word.
-div.pseudo = 'first-letter';
-shouldBe("div.pseudo", "'first-letter'");
+div.webkitPseudo = 'first-letter';
+shouldBe("div.webkitPseudo", "'first-letter'");
finishJSTest();
</script>
Modified: trunk/LayoutTests/fast/dom/shadow/shadow-pseudo-id.html (136912 => 136913)
--- trunk/LayoutTests/fast/dom/shadow/shadow-pseudo-id.html 2012-12-07 01:45:07 UTC (rev 136912)
+++ trunk/LayoutTests/fast/dom/shadow/shadow-pseudo-id.html 2012-12-07 01:48:46 UTC (rev 136913)
@@ -28,19 +28,19 @@
var shadowRoot1 = new WebKitShadowRoot(host1);
var div1 = document.createElement('div');
div1.innerHTML = "pseudo is x-shadow: This should be red.";
-div1.pseudo = "x-shadow";
+div1.webkitPseudo = "x-shadow";
shadowRoot1.appendChild(div1);
var shadowRoot2 = new WebKitShadowRoot(host2);
var div2 = document.createElement('div');
div2.innerHTML = "pseudo is -test: This should not be red.";
-div2.pseudo = "-test";
+div2.webkitPseudo = "-test";
shadowRoot2.appendChild(div2);
var shadowRoot3 = new WebKitShadowRoot(host3);
var div3 = document.createElement('div');
div3.innerHTML = "pseudo is foobar: This should not be red.";
-div3.pseudo = "foobar";
+div3.webkitPseudo = "foobar";
shadowRoot3.appendChild(div3);
</script>
Modified: trunk/Source/WebCore/ChangeLog (136912 => 136913)
--- trunk/Source/WebCore/ChangeLog 2012-12-07 01:45:07 UTC (rev 136912)
+++ trunk/Source/WebCore/ChangeLog 2012-12-07 01:48:46 UTC (rev 136913)
@@ -1,3 +1,16 @@
+2012-12-06 Dominic Cooney <[email protected]>
+
+ Element.pseudo property should be prefixed
+ https://bugs.webkit.org/show_bug.cgi?id=104060
+
+ Reviewed by Hajime Morita.
+
+ Other Shadow DOM properties are prefixed; pseudo should be too.
+
+ Covered by updated tests in fast/dom/shadow.
+
+ * dom/Element.idl:
+
2012-12-06 Andrei Bucur <[email protected]>
[CSS Regions] Remove the sanitize mechanism from LineFragmentationData
Modified: trunk/Source/WebCore/dom/Element.idl (136912 => 136913)
--- trunk/Source/WebCore/dom/Element.idl 2012-12-07 01:45:07 UTC (rev 136912)
+++ trunk/Source/WebCore/dom/Element.idl 2012-12-07 01:48:46 UTC (rev 136913)
@@ -121,7 +121,7 @@
// ShadowAware API
#if defined(ENABLE_SHADOW_DOM) && ENABLE_SHADOW_DOM
- [Reflect, V8EnabledAtRuntime=shadowDOM] attribute DOMString pseudo;
+ [Reflect=pseudo, V8EnabledAtRuntime=shadowDOM, ImplementedAs=pseudo] attribute DOMString webkitPseudo;
[V8EnabledAtRuntime=shadowDOM, ImplementedAs=createShadowRoot] ShadowRoot webkitCreateShadowRoot() raises(DOMException);
#endif
