Title: [136930] trunk/Source/WebKit/blackberry
- Revision
- 136930
- Author
- mary...@torchmobile.com.cn
- Date
- 2012-12-07 00:25:23 -0800 (Fri, 07 Dec 2012)
Log Message
[BlackBerry] new target window would cause the url being loaded twice
https://bugs.webkit.org/show_bug.cgi?id=104086
Reviewed by Yong Li.
When webkit need to open window for a new target like "_blank", it would
load the url subsequently after createWindow. But the chrome browser would
load the url again when it get the OpenWindowEvent from native, which
causes the url being loaded twice. We should make sure that createWindow() be
used to create a new window only, not loading url, so we pass empty url
as parameter.
RIM PR# 257329
Internally reviewed by Charles Wei.
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchCreatePage):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (136929 => 136930)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-12-07 08:04:35 UTC (rev 136929)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-12-07 08:25:23 UTC (rev 136930)
@@ -1,3 +1,23 @@
+2012-12-07 Mary Wu <mary...@torchmobile.com.cn>
+
+ [BlackBerry] new target window would cause the url being loaded twice
+ https://bugs.webkit.org/show_bug.cgi?id=104086
+
+ Reviewed by Yong Li.
+
+ When webkit need to open window for a new target like "_blank", it would
+ load the url subsequently after createWindow. But the chrome browser would
+ load the url again when it get the OpenWindowEvent from native, which
+ causes the url being loaded twice. We should make sure that createWindow() be
+ used to create a new window only, not loading url, so we pass empty url
+ as parameter.
+
+ RIM PR# 257329
+ Internally reviewed by Charles Wei.
+
+ * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
+ (WebCore::FrameLoaderClientBlackBerry::dispatchCreatePage):
+
2012-12-05 Otto Derek Cheung <otche...@rim.com>
[BlackBerry] Geolocation prompts won't respond to the correct geolocation object if the user opens two pages and respond in the reversed order
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp (136929 => 136930)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp 2012-12-07 08:04:35 UTC (rev 136929)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp 2012-12-07 08:25:23 UTC (rev 136930)
@@ -962,7 +962,8 @@
Frame* FrameLoaderClientBlackBerry::dispatchCreatePage(const NavigationAction& navigation)
{
- WebPage* webPage = m_webPagePrivate->m_client->createWindow(0, 0, -1, -1, WebPageClient::FlagWindowDefault, navigation.url().string(), BlackBerry::Platform::String::emptyString());
+ UNUSED_PARAM(navigation);
+ WebPage* webPage = m_webPagePrivate->m_client->createWindow(0, 0, -1, -1, WebPageClient::FlagWindowDefault, BlackBerry::Platform::String::emptyString(), BlackBerry::Platform::String::emptyString());
if (!webPage)
return 0;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
