Log Message
Improve confusing code in BaseMultipleFieldsDateAndTimeInputType https://bugs.webkit.org/show_bug.cgi?id=104353
Reviewed by Kentaro Hara. This doesn't change any behavior because call sites of isEditControlOwnerDisabled and isEditControlOwnerReadOnly treat them similarly. * html/BaseMultipleFieldsDateAndTimeInputType.cpp: (WebCore::BaseMultipleFieldsDateAndTimeInputType::isEditControlOwnerDisabled): Checks element()->disabled, not readOnly. (WebCore::BaseMultipleFieldsDateAndTimeInputType::isEditControlOwnerReadOnly): Checks element()->readOnly, not disabled.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (136936 => 136937)
--- trunk/Source/WebCore/ChangeLog 2012-12-07 09:16:07 UTC (rev 136936)
+++ trunk/Source/WebCore/ChangeLog 2012-12-07 09:53:43 UTC (rev 136937)
@@ -1,3 +1,20 @@
+2012-12-07 Kent Tamura <[email protected]>
+
+ Improve confusing code in BaseMultipleFieldsDateAndTimeInputType
+ https://bugs.webkit.org/show_bug.cgi?id=104353
+
+ Reviewed by Kentaro Hara.
+
+ This doesn't change any behavior because call sites of
+ isEditControlOwnerDisabled and isEditControlOwnerReadOnly treat them
+ similarly.
+
+ * html/BaseMultipleFieldsDateAndTimeInputType.cpp:
+ (WebCore::BaseMultipleFieldsDateAndTimeInputType::isEditControlOwnerDisabled):
+ Checks element()->disabled, not readOnly.
+ (WebCore::BaseMultipleFieldsDateAndTimeInputType::isEditControlOwnerReadOnly):
+ Checks element()->readOnly, not disabled.
+
2012-12-07 Jon Lee <[email protected]>
Build fix.
Modified: trunk/Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp (136936 => 136937)
--- trunk/Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp 2012-12-07 09:16:07 UTC (rev 136936)
+++ trunk/Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp 2012-12-07 09:53:43 UTC (rev 136937)
@@ -86,12 +86,12 @@
bool BaseMultipleFieldsDateAndTimeInputType::isEditControlOwnerDisabled() const
{
- return element()->readOnly();
+ return element()->disabled();
}
bool BaseMultipleFieldsDateAndTimeInputType::isEditControlOwnerReadOnly() const
{
- return element()->disabled();
+ return element()->readOnly();
}
void BaseMultipleFieldsDateAndTimeInputType::focusAndSelectSpinButtonOwner()
_______________________________________________ webkit-changes mailing list [email protected] http://lists.webkit.org/mailman/listinfo/webkit-changes
