Title: [136950] trunk/Source/WebCore
- Revision
- 136950
- Author
- [email protected]
- Date
- 2012-12-07 06:30:58 -0800 (Fri, 07 Dec 2012)
Log Message
Web Inspector: [Chromium] Ctrl + ']' "Goto right panel" keyboard shortcut doesn't work
https://bugs.webkit.org/show_bug.cgi?id=104250
Reviewed by Pavel Feldman.
Ignore "keypress" event resulting from a WM_CHAR message emitted by Win7 upon Ctrl + ']' keypress.
* inspector/front-end/InspectorView.js:
(WebInspector.InspectorView.prototype._keyPress): Ignore all events with charCode < 32.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (136949 => 136950)
--- trunk/Source/WebCore/ChangeLog 2012-12-07 14:13:33 UTC (rev 136949)
+++ trunk/Source/WebCore/ChangeLog 2012-12-07 14:30:58 UTC (rev 136950)
@@ -1,3 +1,15 @@
+2012-12-06 Alexander Pavlov <[email protected]>
+
+ Web Inspector: [Chromium] Ctrl + ']' "Goto right panel" keyboard shortcut doesn't work
+ https://bugs.webkit.org/show_bug.cgi?id=104250
+
+ Reviewed by Pavel Feldman.
+
+ Ignore "keypress" event resulting from a WM_CHAR message emitted by Win7 upon Ctrl + ']' keypress.
+
+ * inspector/front-end/InspectorView.js:
+ (WebInspector.InspectorView.prototype._keyPress): Ignore all events with charCode < 32.
+
2012-10-03 Pavel Feldman <[email protected]>
Web Inspector: provide a way to reload page with given script preprocessor.
Modified: trunk/Source/WebCore/inspector/front-end/InspectorView.js (136949 => 136950)
--- trunk/Source/WebCore/inspector/front-end/InspectorView.js 2012-12-07 14:13:33 UTC (rev 136949)
+++ trunk/Source/WebCore/inspector/front-end/InspectorView.js 2012-12-07 14:30:58 UTC (rev 136950)
@@ -126,6 +126,10 @@
_keyPress: function(event)
{
+ // BUG 104250: Windows 7 posts a WM_CHAR message upon the Ctrl+']' keypress.
+ // Any charCode < 32 is not going to be a valid keypress.
+ if (event.charCode < 32 && WebInspector.isWin())
+ return;
clearTimeout(this._keyDownTimer);
delete this._keyDownTimer;
},
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
