Title: [136965] trunk
- Revision
- 136965
- Author
- commit-qu...@webkit.org
- Date
- 2012-12-07 11:16:49 -0800 (Fri, 07 Dec 2012)
Log Message
[BlackBerry] Update BlackBerry Port to use new Graphics::createBuffer BufferType enum values.
https://bugs.webkit.org/show_bug.cgi?id=104121
Patch by Mike Lattanzio <mlattan...@rim.com> on 2012-12-07
Reviewed by Rob Buis.
Source/WebKit/blackberry:
Update createBuffer calls to reflect new BufferType enum.
Set buffers opaque if possible to avoid unnecessary blends.
Internal PR 254649
Internal Review: Jakob Petsovits
* WebKitSupport/BackingStoreTile.cpp:
(BlackBerry::WebKit::TileBuffer::nativeBuffer):
Tools:
Update createBuffer call to reflect new BufferType enum.
Internal PR 254649
Internal Review: Jakob Petsovits
DRT is always backed for maximum compatibility.
* DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
(createBitmapContextFromWebView):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/Api/BackingStore.cpp (136964 => 136965)
--- trunk/Source/WebKit/blackberry/Api/BackingStore.cpp 2012-12-07 19:10:02 UTC (rev 136964)
+++ trunk/Source/WebKit/blackberry/Api/BackingStore.cpp 2012-12-07 19:16:49 UTC (rev 136965)
@@ -1119,6 +1119,7 @@
backBuffer->clearRenderedRegion();
BlackBerry::Platform::Graphics::Buffer* nativeBuffer = backBuffer->nativeBuffer();
+ BlackBerry::Platform::Graphics::setBufferOpaqueHint(nativeBuffer, !Color(m_webPage->settings()->backgroundColor()).hasAlpha());
// TODO: This code is only needed for EGLImage code path, but preferrably BackingStore
// should not know that, and the synchronization should be in BlackBerry::Platform::Graphics
Modified: trunk/Source/WebKit/blackberry/ChangeLog (136964 => 136965)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-12-07 19:10:02 UTC (rev 136964)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-12-07 19:16:49 UTC (rev 136965)
@@ -1,3 +1,18 @@
+2012-12-07 Mike Lattanzio <mlattan...@rim.com>
+
+ [BlackBerry] Update BlackBerry Port to use new Graphics::createBuffer BufferType enum values.
+ https://bugs.webkit.org/show_bug.cgi?id=104121
+
+ Reviewed by Rob Buis.
+
+ Update createBuffer calls to reflect new BufferType enum.
+ Set buffers opaque if possible to avoid unnecessary blends.
+ Internal PR 254649
+ Internal Review: Jakob Petsovits
+
+ * WebKitSupport/BackingStoreTile.cpp:
+ (BlackBerry::WebKit::TileBuffer::nativeBuffer):
+
2012-12-07 Andrew Lo <a...@rim.com>
[BlackBerry] Double zoom animation when focusing on input field.
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/BackingStoreTile.cpp (136964 => 136965)
--- trunk/Source/WebKit/blackberry/WebKitSupport/BackingStoreTile.cpp 2012-12-07 19:10:02 UTC (rev 136964)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/BackingStoreTile.cpp 2012-12-07 19:16:49 UTC (rev 136965)
@@ -101,7 +101,7 @@
Platform::Graphics::Buffer* TileBuffer::nativeBuffer() const
{
if (!m_nativeBuffer)
- m_nativeBuffer = createBuffer(m_size, Platform::Graphics::TileBuffer, SurfacePool::globalSurfacePool()->sharedPixmapGroup());
+ m_nativeBuffer = createBuffer(m_size, Platform::Graphics::AlwaysBacked, SurfacePool::globalSurfacePool()->sharedPixmapGroup());
return m_nativeBuffer;
}
Modified: trunk/Tools/ChangeLog (136964 => 136965)
--- trunk/Tools/ChangeLog 2012-12-07 19:10:02 UTC (rev 136964)
+++ trunk/Tools/ChangeLog 2012-12-07 19:16:49 UTC (rev 136965)
@@ -1,3 +1,19 @@
+2012-12-07 Mike Lattanzio <mlattan...@rim.com>
+
+ [BlackBerry] Update BlackBerry Port to use new Graphics::createBuffer BufferType enum values.
+ https://bugs.webkit.org/show_bug.cgi?id=104121
+
+ Reviewed by Rob Buis.
+
+ Update createBuffer call to reflect new BufferType enum.
+ Internal PR 254649
+ Internal Review: Jakob Petsovits
+
+ DRT is always backed for maximum compatibility.
+
+ * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
+ (createBitmapContextFromWebView):
+
2012-12-07 Jochen Eisinger <joc...@chromium.org>
Add 'CHROMIUM_DEVEL_SANDBOX' to the environment variables to copy for layout test drivers
Modified: trunk/Tools/DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp (136964 => 136965)
--- trunk/Tools/DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp 2012-12-07 19:10:02 UTC (rev 136964)
+++ trunk/Tools/DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp 2012-12-07 19:16:49 UTC (rev 136965)
@@ -86,7 +86,7 @@
memcpy(data, windowPixels, windowSize.width() * windowSize.height() * 4);
}
#else
- BlackBerry::Platform::Graphics::Buffer* buffer = BlackBerry::Platform::Graphics::createBuffer(windowSize, BlackBerry::Platform::Graphics::TemporaryBuffer);
+ BlackBerry::Platform::Graphics::Buffer* buffer = BlackBerry::Platform::Graphics::createBuffer(windowSize, BlackBerry::Platform::Graphics::AlwaysBacked);
BlackBerry::Platform::Graphics::Drawable* drawable = BlackBerry::Platform::Graphics::lockBufferDrawable(buffer);
if (drawable) {
backingStore->drawContents(drawable, windowRect, windowSize);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
