Title: [137071] trunk
- Revision
- 137071
- Author
- [email protected]
- Date
- 2012-12-09 05:26:28 -0800 (Sun, 09 Dec 2012)
Log Message
[GTK] accessibility/label-for-control-hittest.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98368
Patch by Joanmarie Diggs <[email protected]> on 2012-12-09
Reviewed by Martin Robinson.
Tools:
The test was failing because AccessibilityUIElement::elementAtPoint was
not implemented.
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::elementAtPoint): implemented
LayoutTests:
Unskip the test having implemented AccessibilityUIElement::elementAtPoint.
* platform/gtk/TestExpectations: unskip accessibility/label-for-control-hittest.html
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (137070 => 137071)
--- trunk/LayoutTests/ChangeLog 2012-12-09 11:41:04 UTC (rev 137070)
+++ trunk/LayoutTests/ChangeLog 2012-12-09 13:26:28 UTC (rev 137071)
@@ -1,3 +1,14 @@
+2012-12-09 Joanmarie Diggs <[email protected]>
+
+ [GTK] accessibility/label-for-control-hittest.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=98368
+
+ Reviewed by Martin Robinson.
+
+ Unskip the test having implemented AccessibilityUIElement::elementAtPoint.
+
+ * platform/gtk/TestExpectations: unskip accessibility/label-for-control-hittest.html
+
2012-12-09 Christophe Dumez <[email protected]>
Unreviewed EFL gardening.
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (137070 => 137071)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2012-12-09 11:41:04 UTC (rev 137070)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2012-12-09 13:26:28 UTC (rev 137071)
@@ -747,7 +747,6 @@
webkit.org/b/98363 accessibility/canvas-fallback-content-2.html [ Failure ]
webkit.org/b/98364 accessibility/editable-webarea-context-menu-point.html [ Failure ]
webkit.org/b/98365 accessibility/ellipsis-text.html [ Failure ]
-webkit.org/b/98368 accessibility/label-for-control-hittest.html [ Failure ]
webkit.org/b/98369 accessibility/language-attribute.html [ Failure ]
webkit.org/b/98370 accessibility/loading-iframe-sends-notification.html [ Failure ]
webkit.org/b/98371 accessibility/loading-iframe-updates-axtree.html [ Failure ]
Modified: trunk/Tools/ChangeLog (137070 => 137071)
--- trunk/Tools/ChangeLog 2012-12-09 11:41:04 UTC (rev 137070)
+++ trunk/Tools/ChangeLog 2012-12-09 13:26:28 UTC (rev 137071)
@@ -1,3 +1,16 @@
+2012-12-09 Joanmarie Diggs <[email protected]>
+
+ [GTK] accessibility/label-for-control-hittest.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=98368
+
+ Reviewed by Martin Robinson.
+
+ The test was failing because AccessibilityUIElement::elementAtPoint was
+ not implemented.
+
+ * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
+ (AccessibilityUIElement::elementAtPoint): implemented
+
2012-12-09 Jon Lee <[email protected]>
[WK2] Move button image to injected bundle
Modified: trunk/Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp (137070 => 137071)
--- trunk/Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp 2012-12-09 11:41:04 UTC (rev 137070)
+++ trunk/Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp 2012-12-09 13:26:28 UTC (rev 137071)
@@ -240,8 +240,10 @@
AccessibilityUIElement AccessibilityUIElement::elementAtPoint(int x, int y)
{
- // FIXME: implement
- return 0;
+ if (!m_element)
+ return 0;
+
+ return AccessibilityUIElement(atk_component_ref_accessible_at_point(ATK_COMPONENT(m_element), x, y, ATK_XY_WINDOW));
}
AccessibilityUIElement AccessibilityUIElement::linkedUIElementAtIndex(unsigned index)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
