Title: [137078] trunk/Source/WebCore
- Revision
- 137078
- Author
- [email protected]
- Date
- 2012-12-09 09:34:57 -0800 (Sun, 09 Dec 2012)
Log Message
Fix the GError check in GObject DOM bindings.
Reviewed by Xan Lopez.
Previous commit introduced a check to make sure the passed GError
is valid in all DOM methods receiving an error.
* bindings/scripts/CodeGeneratorGObject.pm:
(GetGReturnMacro): Check that the passed GError either is NULL or
the pointer has been initialized to NULL.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (137077 => 137078)
--- trunk/Source/WebCore/ChangeLog 2012-12-09 17:10:17 UTC (rev 137077)
+++ trunk/Source/WebCore/ChangeLog 2012-12-09 17:34:57 UTC (rev 137078)
@@ -1,3 +1,16 @@
+2012-12-09 Carlos Garcia Campos <[email protected]>
+
+ Fix the GError check in GObject DOM bindings.
+
+ Reviewed by Xan Lopez.
+
+ Previous commit introduced a check to make sure the passed GError
+ is valid in all DOM methods receiving an error.
+
+ * bindings/scripts/CodeGeneratorGObject.pm:
+ (GetGReturnMacro): Check that the passed GError either is NULL or
+ the pointer has been initialized to NULL.
+
2012-12-09 Leo Yang <[email protected]>
[BlackBerry] Adapt to name change of createNetworkBufferByCopyingData()
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm (137077 => 137078)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2012-12-09 17:10:17 UTC (rev 137077)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2012-12-09 17:34:57 UTC (rev 137078)
@@ -823,7 +823,7 @@
my $condition;
if ($paramIDLType eq "GError") {
- $condition = "!$paramName || *$paramName";
+ $condition = "!$paramName || !*$paramName";
} elsif (IsGDOMClassType($paramIDLType)) {
my $paramTypeCaps = uc(FixUpDecamelizedName(decamelize($paramIDLType)));
$condition = "WEBKIT_DOM_IS_${paramTypeCaps}($paramName)";
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
