Title: [137110] trunk/Source/_javascript_Core
- Revision
- 137110
- Author
- [email protected]
- Date
- 2012-12-09 22:54:30 -0800 (Sun, 09 Dec 2012)
Log Message
DFG ArrayPush/Pop should not pass their second child as the index for blessArrayOperation()
https://bugs.webkit.org/show_bug.cgi?id=104500
Reviewed by Oliver Hunt.
Slight across-the-board speed-up.
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (137109 => 137110)
--- trunk/Source/_javascript_Core/ChangeLog 2012-12-10 06:45:58 UTC (rev 137109)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-12-10 06:54:30 UTC (rev 137110)
@@ -1,3 +1,17 @@
+2012-12-09 Filip Pizlo <[email protected]>
+
+ DFG ArrayPush/Pop should not pass their second child as the index for blessArrayOperation()
+ https://bugs.webkit.org/show_bug.cgi?id=104500
+
+ Reviewed by Oliver Hunt.
+
+ Slight across-the-board speed-up.
+
+ * dfg/DFGAbstractState.cpp:
+ (JSC::DFG::AbstractState::execute):
+ * dfg/DFGFixupPhase.cpp:
+ (JSC::DFG::FixupPhase::fixupNode):
+
2012-12-08 Filip Pizlo <[email protected]>
JSC should scale the optimization threshold for a code block according to the cost of compiling it
Modified: trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp (137109 => 137110)
--- trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp 2012-12-10 06:45:58 UTC (rev 137109)
+++ trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp 2012-12-10 06:54:30 UTC (rev 137110)
@@ -1590,6 +1590,8 @@
|| value.m_currentKnownStructure.isSubsetOf(set))
m_foundConstants = true;
node.setCanExit(true);
+ if (node.child2())
+ forNode(node.child2()).filter(SpecInt32);
clobberStructures(indexInBlock);
value.filter(set);
m_haveStructures = true;
Modified: trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp (137109 => 137110)
--- trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp 2012-12-10 06:45:58 UTC (rev 137109)
+++ trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp 2012-12-10 06:54:30 UTC (rev 137110)
@@ -172,7 +172,7 @@
m_graph[node.child1()].prediction() & SpecCell,
SpecInt32,
m_graph[node.child2()].prediction()));
- blessArrayOperation(node.child1(), node.child2(), 2);
+ blessArrayOperation(node.child1(), Edge(), 2);
Node* nodePtr = &m_graph[m_compileIndex];
switch (nodePtr->arrayMode().type()) {
@@ -186,7 +186,7 @@
}
case ArrayPop: {
- blessArrayOperation(node.child1(), node.child2(), 1);
+ blessArrayOperation(node.child1(), Edge(), 1);
break;
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
