Title: [137208] trunk
- Revision
- 137208
- Author
- [email protected]
- Date
- 2012-12-10 14:42:32 -0800 (Mon, 10 Dec 2012)
Log Message
nrwt: use the default logic for skipping platform-specific tests for chromium
https://bugs.webkit.org/show_bug.cgi?id=104403
Reviewed by Stephen White.
Tools:
I thought I had fixed this a while ago, but the chromium port was
using custom logic to figure out which platform/* tests to run (or
skip) and as a result we were getting some odd behavior (like running
tests in chromium-linux on chromium-mac, but only when there was
an expectation listed for the test).
Ports are supposed to only run the tests found under their
baseline_search_path() by default.
Not writing a test for this; theoretically there shouldn't been a
test checking that the behavior for Chromium was *different* than
the other ports before.
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort._missing_symbol_to_skipped_tests):
LayoutTests:
Remove a bunch of WONTFIX lines that will now be handled programmatically.
* platform/chromium-android/TestExpectations:
* platform/chromium/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (137207 => 137208)
--- trunk/LayoutTests/ChangeLog 2012-12-10 22:31:43 UTC (rev 137207)
+++ trunk/LayoutTests/ChangeLog 2012-12-10 22:42:32 UTC (rev 137208)
@@ -1,3 +1,15 @@
+2012-12-10 Dirk Pranke <[email protected]>
+
+ nrwt: use the default logic for skipping platform-specific tests for chromium
+ https://bugs.webkit.org/show_bug.cgi?id=104403
+
+ Reviewed by Stephen White.
+
+ Remove a bunch of WONTFIX lines that will now be handled programmatically.
+
+ * platform/chromium-android/TestExpectations:
+ * platform/chromium/TestExpectations:
+
2012-12-10 Dean Jackson <[email protected]>
Unreviewed update to test results after http://trac.webkit.org/changeset/137200.
Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137207 => 137208)
--- trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-10 22:31:43 UTC (rev 137207)
+++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-10 22:42:32 UTC (rev 137208)
@@ -234,17 +234,6 @@
# WONTFIX TESTS
# -----------------------------------------------------------------
-# Run the Mac-specific platform tests, but only to check for crashes.
-platform/gtk [ WontFix ]
-platform/mac [ WontFix ]
-platform/mac-wk2 [ WontFix ]
-platform/qt [ WontFix ]
-platform/qt/plugins/qt-qwidget-plugin.html [ WontFix ]
-platform/qt/fast/forms [ WontFix ]
-[ Mac Win ] platform/chromium-linux [ WontFix ]
-[ Linux Mac ] platform/win [ WontFix ]
-[ Linux Win Mac ] platform/chromium-android [ WontFix ]
-
# These tests are for -apple- and -khtml- prefixes, which we don't support
inspector/styles/vendor-prefixes.html [ WontFix ]
fast/css/apple-prefix.html [ WontFix ]
Modified: trunk/LayoutTests/platform/chromium-android/TestExpectations (137207 => 137208)
--- trunk/LayoutTests/platform/chromium-android/TestExpectations 2012-12-10 22:31:43 UTC (rev 137207)
+++ trunk/LayoutTests/platform/chromium-android/TestExpectations 2012-12-10 22:42:32 UTC (rev 137208)
@@ -3,13 +3,6 @@
#
# Other rules should be in platform/chromium/TestExpectations.
-# Skip tests of other platforms to save time.
-platform/gtk [ WontFix ]
-platform/mac [ WontFix ]
-platform/mac-wk2 [ WontFix ]
-platform/qt [ WontFix ]
-platform/win [ WontFix ]
-
# Features not supported: http://crbug.com/145338.
crbug.com/145338 compositing/plugins
crbug.com/145338 plugins
Modified: trunk/Tools/ChangeLog (137207 => 137208)
--- trunk/Tools/ChangeLog 2012-12-10 22:31:43 UTC (rev 137207)
+++ trunk/Tools/ChangeLog 2012-12-10 22:42:32 UTC (rev 137208)
@@ -1,5 +1,28 @@
2012-12-10 Dirk Pranke <[email protected]>
+ nrwt: use the default logic for skipping platform-specific tests for chromium
+ https://bugs.webkit.org/show_bug.cgi?id=104403
+
+ Reviewed by Stephen White.
+
+ I thought I had fixed this a while ago, but the chromium port was
+ using custom logic to figure out which platform/* tests to run (or
+ skip) and as a result we were getting some odd behavior (like running
+ tests in chromium-linux on chromium-mac, but only when there was
+ an expectation listed for the test).
+
+ Ports are supposed to only run the tests found under their
+ baseline_search_path() by default.
+
+ Not writing a test for this; theoretically there shouldn't been a
+ test checking that the behavior for Chromium was *different* than
+ the other ports before.
+
+ * Scripts/webkitpy/layout_tests/port/chromium.py:
+ (ChromiumPort._missing_symbol_to_skipped_tests):
+
+2012-12-10 Dirk Pranke <[email protected]>
+
fix regression in test-webkitpy after r137189
https://bugs.webkit.org/show_bug.cgi?id=104589
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py (137207 => 137208)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py 2012-12-10 22:31:43 UTC (rev 137207)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py 2012-12-10 22:42:32 UTC (rev 137208)
@@ -277,10 +277,6 @@
"ff_aac_decoder": ["webaudio/codec-tests/aac"],
}
- def skipped_layout_tests(self, test_list):
- # FIXME: Merge w/ WebKitPort.skipped_layout_tests()
- return set(self._skipped_tests_for_unsupported_features(test_list))
-
def setup_test_run(self):
# Delete the disk cache if any to ensure a clean test run.
dump_render_tree_binary_path = self._path_to_driver()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
