Title: [137325] trunk/Tools
- Revision
- 137325
- Author
- [email protected]
- Date
- 2012-12-11 09:16:01 -0800 (Tue, 11 Dec 2012)
Log Message
[GTK] Spurious stderr output from the event sender
https://bugs.webkit.org/show_bug.cgi?id=104678
Reviewed by Gustavo Noronha Silva.
Eliminate some spurious stderr output from the EventSender by using an early return
instead of an assertion that prints a warning to the console.
* DumpRenderTree/gtk/EventSender.cpp:
(continuousMouseScrollByCallback): We don't support continuous scroll events that
move by page, but we should just fail silently instead of printing an error.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (137324 => 137325)
--- trunk/Tools/ChangeLog 2012-12-11 17:15:36 UTC (rev 137324)
+++ trunk/Tools/ChangeLog 2012-12-11 17:16:01 UTC (rev 137325)
@@ -1,3 +1,17 @@
+2012-12-11 Martin Robinson <[email protected]>
+
+ [GTK] Spurious stderr output from the event sender
+ https://bugs.webkit.org/show_bug.cgi?id=104678
+
+ Reviewed by Gustavo Noronha Silva.
+
+ Eliminate some spurious stderr output from the EventSender by using an early return
+ instead of an assertion that prints a warning to the console.
+
+ * DumpRenderTree/gtk/EventSender.cpp:
+ (continuousMouseScrollByCallback): We don't support continuous scroll events that
+ move by page, but we should just fail silently instead of printing an error.
+
2012-12-11 Joone Hur <[email protected]>
[GTK] Add GraphicsLayerActor
Modified: trunk/Tools/DumpRenderTree/gtk/EventSender.cpp (137324 => 137325)
--- trunk/Tools/DumpRenderTree/gtk/EventSender.cpp 2012-12-11 17:15:36 UTC (rev 137324)
+++ trunk/Tools/DumpRenderTree/gtk/EventSender.cpp 2012-12-11 17:16:01 UTC (rev 137325)
@@ -489,8 +489,10 @@
int vertical = JSValueToNumber(context, arguments[1], exception);
g_return_val_if_fail((!exception || !*exception), JSValueMakeUndefined(context));
- g_return_val_if_fail(argumentCount < 3 || !JSValueToBoolean(context, arguments[2]), JSValueMakeUndefined(context));
-
+ // We do not yet support continuous scrolling by page.
+ if (argumentCount >= 3 && JSValueToBoolean(context, arguments[2]), JSValueMakeUndefined(context))
+ return JSValueMakeUndefined(context);
+
GdkEvent* event = gdk_event_new(GDK_SCROLL);
event->scroll.x = lastMousePositionX;
event->scroll.y = lastMousePositionY;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
