Title: [137327] trunk/Source
Revision
137327
Author
[email protected]
Date
2012-12-11 09:38:28 -0800 (Tue, 11 Dec 2012)

Log Message

[Chromium] Clean up unused interfaces in PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=104674

Reviewed by Darin Fisher.

Source/WebCore:

Part of a refactoring series. See tracking bug 82948. Also, there
were some function declarations that were supposed to be removed
as part of bug 102699 but got left out of the final patch.

* platform/chromium/PlatformSupport.h:
(WebCore):
(PlatformSupport):

Source/WebKit/chromium:

Part of a refactoring series. See tracking bug 82948.

* public/platform/WebKitPlatformSupport.h:
* src/PlatformSupport.cpp:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (137326 => 137327)


--- trunk/Source/WebCore/ChangeLog	2012-12-11 17:34:15 UTC (rev 137326)
+++ trunk/Source/WebCore/ChangeLog	2012-12-11 17:38:28 UTC (rev 137327)
@@ -1,3 +1,18 @@
+2012-12-11  Mark Pilgrim  <[email protected]>
+
+        [Chromium] Clean up unused interfaces in PlatformSupport
+        https://bugs.webkit.org/show_bug.cgi?id=104674
+
+        Reviewed by Darin Fisher.
+
+        Part of a refactoring series. See tracking bug 82948. Also, there
+        were some function declarations that were supposed to be removed
+        as part of bug 102699 but got left out of the final patch.
+
+        * platform/chromium/PlatformSupport.h:
+        (WebCore):
+        (PlatformSupport):
+
 2012-12-11  Joone Hur  <[email protected]>, Gustavo Noronha Silva  <[email protected]>
 
         [GTK] Update GraphicsLayerClutter

Modified: trunk/Source/WebCore/platform/chromium/PlatformSupport.h (137326 => 137327)


--- trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-12-11 17:34:15 UTC (rev 137326)
+++ trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-12-11 17:38:28 UTC (rev 137327)
@@ -31,42 +31,12 @@
 #ifndef PlatformSupport_h
 #define PlatformSupport_h
 
-#if ENABLE(WEB_AUDIO)
-#include "AudioBus.h"
-#endif
-
-#include "FileSystem.h"
-#include "ImageSource.h"
-#include "LinkHash.h"
-#include "PluginData.h"
-
 #include <wtf/Forward.h>
-#include <wtf/HashSet.h>
-#include <wtf/PassRefPtr.h>
-#include <wtf/Vector.h>
 
-typedef struct NPObject NPObject;
-typedef struct _NPP NPP_t;
-typedef NPP_t* NPP;
-
 namespace WebCore {
 
-class Color;
-class Cursor;
-class Document;
-class Frame;
-class GeolocationServiceBridge;
-class GeolocationServiceChromium;
-class GraphicsContext;
-class Image;
 class IDBFactoryBackendInterface;
-class IntRect;
-class KURL;
-class SerializedScriptValue;
-class Widget;
 
-struct FontRenderStyle;
-
 // PlatformSupport an interface to the embedding layer that lets the embedder
 // supply implementations for Platform functionality that WebCore cannot access
 // directly (for example, because WebCore is in a sandbox).
@@ -75,28 +45,6 @@
 public:
     // IndexedDB ----------------------------------------------------------
     static PassRefPtr<IDBFactoryBackendInterface> idbFactory();
-
-    // Theming ------------------------------------------------------------
-#if OS(WINDOWS) && !ENABLE(DEFAULT_RENDER_THEME)
-    static void paintButton(
-        GraphicsContext*, int part, int state, int classicState, const IntRect&);
-    static void paintMenuList(
-        GraphicsContext*, int part, int state, int classicState, const IntRect&);
-    static void paintScrollbarArrow(
-        GraphicsContext*, int state, int classicState, const IntRect&);
-    static void paintScrollbarThumb(
-        GraphicsContext*, int part, int state, int classicState, const IntRect&);
-    static void paintScrollbarTrack(
-        GraphicsContext*, int part, int state, int classicState, const IntRect&, const IntRect& alignRect);
-    static void paintSpinButton(
-        GraphicsContext*, int part, int state, int classicState, const IntRect&);
-    static void paintTextField(
-        GraphicsContext*, int part, int state, int classicState, const IntRect&, const Color&, bool fillContentArea, bool drawEdges);
-    static void paintTrackbar(
-        GraphicsContext*, int part, int state, int classicState, const IntRect&);
-    static void paintProgressBar(
-        GraphicsContext*, const IntRect& barRect, const IntRect& valueRect, bool determinate, double animatedSeconds);
-#endif
 };
 
 } // namespace WebCore

Modified: trunk/Source/WebKit/chromium/ChangeLog (137326 => 137327)


--- trunk/Source/WebKit/chromium/ChangeLog	2012-12-11 17:34:15 UTC (rev 137326)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-12-11 17:38:28 UTC (rev 137327)
@@ -1,3 +1,15 @@
+2012-12-11  Mark Pilgrim  <[email protected]>
+
+        [Chromium] Clean up unused interfaces in PlatformSupport
+        https://bugs.webkit.org/show_bug.cgi?id=104674
+
+        Reviewed by Darin Fisher.
+
+        Part of a refactoring series. See tracking bug 82948.
+
+        * public/platform/WebKitPlatformSupport.h:
+        * src/PlatformSupport.cpp:
+
 2012-12-11  Mike West  <[email protected]>
 
         Web Inspector: ConsoleTypes should not expose MessageType - it should be private to inspector.

Modified: trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h (137326 => 137327)


--- trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h	2012-12-11 17:34:15 UTC (rev 137326)
+++ trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h	2012-12-11 17:38:28 UTC (rev 137327)
@@ -31,19 +31,8 @@
 #ifndef WebKitPlatformSupport_h
 #define WebKitPlatformSupport_h
 
-#include "WebCommon.h"
-#include "WebGraphicsContext3D.h"
-#include "WebSerializedScriptValue.h"
-#include "WebString.h"
-#include "WebURL.h"
-#include "WebVector.h"
-#include <time.h>
 #include "../../../../Platform/chromium/public/Platform.h"
 
-#ifdef WIN32
-typedef void *HANDLE;
-#endif
-
 namespace WebKit {
 
 class WebIDBFactory; // FIXME: Does this belong in platform?

Modified: trunk/Source/WebKit/chromium/src/PlatformSupport.cpp (137326 => 137327)


--- trunk/Source/WebKit/chromium/src/PlatformSupport.cpp	2012-12-11 17:34:15 UTC (rev 137326)
+++ trunk/Source/WebKit/chromium/src/PlatformSupport.cpp	2012-12-11 17:38:28 UTC (rev 137327)
@@ -31,42 +31,8 @@
 #include "config.h"
 #include "PlatformSupport.h"
 
-#include "Chrome.h"
-#include "ChromeClientImpl.h"
-#include "FileMetadata.h"
-#include "Page.h"
-#include "WebFileInfo.h"
-#include "WebFileUtilities.h"
-#include "WebFrameClient.h"
-#include "WebFrameImpl.h"
-#include "WebKit.h"
-#include "WebPluginContainerImpl.h"
-#include "WebSandboxSupport.h"
-#include "WebScreenInfo.h"
-#include "WebViewClient.h"
-#include "WebViewImpl.h"
-#include "platform/WebAudioBus.h"
-#include "platform/WebData.h"
-#include "platform/WebDragData.h"
-#include "platform/WebImage.h"
-#include "platform/WebKitPlatformSupport.h"
-#include "platform/WebSerializedScriptValue.h"
-#include "platform/WebString.h"
-#include "platform/WebURL.h"
-
-#include "FrameView.h"
 #include "IDBFactoryBackendProxy.h"
-#include "KURL.h"
-#include "NotImplemented.h"
-#include "PluginData.h"
-#include "SharedBuffer.h"
 
-#include "Worker.h"
-#include "WorkerContextProxy.h"
-#include <public/WebMimeRegistry.h>
-#include <public/WebVector.h>
-#include <wtf/Assertions.h>
-
 // We are part of the WebKit implementation.
 using namespace WebKit;
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to