Title: [137330] trunk/Source/WebKit/chromium
- Revision
- 137330
- Author
- [email protected]
- Date
- 2012-12-11 10:13:17 -0800 (Tue, 11 Dec 2012)
Log Message
[Chromium] IndexedDB: Memory leak in IDBCallbacksProxy::onSuccess(PassRefPtr<IDBDatabaseBackendInterface>)
https://bugs.webkit.org/show_bug.cgi?id=104615
Reviewed by Tony Chang.
Ensure passed pointer is treated with ownership semantics.
* src/WebIDBCallbacksImpl.cpp:
(WebKit::WebIDBCallbacksImpl::onSuccess):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (137329 => 137330)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-12-11 17:58:03 UTC (rev 137329)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-12-11 18:13:17 UTC (rev 137330)
@@ -1,3 +1,15 @@
+2012-12-11 Joshua Bell <[email protected]>
+
+ [Chromium] IndexedDB: Memory leak in IDBCallbacksProxy::onSuccess(PassRefPtr<IDBDatabaseBackendInterface>)
+ https://bugs.webkit.org/show_bug.cgi?id=104615
+
+ Reviewed by Tony Chang.
+
+ Ensure passed pointer is treated with ownership semantics.
+
+ * src/WebIDBCallbacksImpl.cpp:
+ (WebKit::WebIDBCallbacksImpl::onSuccess):
+
2012-12-11 Mark Pilgrim <[email protected]>
[Chromium] Clean up unused interfaces in PlatformSupport
Modified: trunk/Source/WebKit/chromium/src/WebIDBCallbacksImpl.cpp (137329 => 137330)
--- trunk/Source/WebKit/chromium/src/WebIDBCallbacksImpl.cpp 2012-12-11 17:58:03 UTC (rev 137329)
+++ trunk/Source/WebKit/chromium/src/WebIDBCallbacksImpl.cpp 2012-12-11 18:13:17 UTC (rev 137330)
@@ -73,11 +73,12 @@
void WebIDBCallbacksImpl::onSuccess(WebIDBDatabase* webKitInstance)
{
+ OwnPtr<WebIDBDatabase> webDatabase = adoptPtr(webKitInstance);
if (m_databaseProxy) {
m_callbacks->onSuccess(m_databaseProxy.release());
return;
}
- m_callbacks->onSuccess(IDBDatabaseBackendProxy::create(adoptPtr(webKitInstance)));
+ m_callbacks->onSuccess(IDBDatabaseBackendProxy::create(webDatabase.release()));
}
void WebIDBCallbacksImpl::onSuccess(const WebIDBKey& key)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
