Title: [137344] trunk/Source/WebCore
- Revision
- 137344
- Author
- [email protected]
- Date
- 2012-12-11 12:54:39 -0800 (Tue, 11 Dec 2012)
Log Message
2012-12-11 Nate Chapin <[email protected]>
cr-linux valgrind is showing leaks due to r137333.
Rubber-stamped by Antti Koivisto.
MainResourceLoader's destructor should call m_resource->removeClient(this) is m_resource is still non-null.
The missing removeClient() call will leak the CachedResource.
No new tests, should shut valgrind up.
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::~MainResourceLoader):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (137343 => 137344)
--- trunk/Source/WebCore/ChangeLog 2012-12-11 20:54:14 UTC (rev 137343)
+++ trunk/Source/WebCore/ChangeLog 2012-12-11 20:54:39 UTC (rev 137344)
@@ -1,3 +1,17 @@
+2012-12-11 Nate Chapin <[email protected]>
+
+ cr-linux valgrind is showing leaks due to r137333.
+
+ Rubber-stamped by Antti Koivisto.
+
+ MainResourceLoader's destructor should call m_resource->removeClient(this) is m_resource is still non-null.
+ The missing removeClient() call will leak the CachedResource.
+
+ No new tests, should shut valgrind up.
+
+ * loader/MainResourceLoader.cpp:
+ (WebCore::MainResourceLoader::~MainResourceLoader):
+
2012-12-11 Andreas Kling <[email protected]>
REGRESSION(r133492): Heap-use-after-free in WebCore::Element::normalizeAttributes
Modified: trunk/Source/WebCore/loader/MainResourceLoader.cpp (137343 => 137344)
--- trunk/Source/WebCore/loader/MainResourceLoader.cpp 2012-12-11 20:54:14 UTC (rev 137343)
+++ trunk/Source/WebCore/loader/MainResourceLoader.cpp 2012-12-11 20:54:39 UTC (rev 137344)
@@ -81,6 +81,7 @@
MainResourceLoader::~MainResourceLoader()
{
+ clearResource();
#if PLATFORM(MAC) && !PLATFORM(IOS) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1080
ASSERT(!m_filter);
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
