Title: [137383] trunk/Tools
- Revision
- 137383
- Author
- [email protected]
- Date
- 2012-12-11 16:36:00 -0800 (Tue, 11 Dec 2012)
Log Message
Dashboard unit tests should not make xhrs.
https://bugs.webkit.org/show_bug.cgi?id=104598
Reviewed by Dirk Pranke.
The unit test were requesting 25 files that they did not use.
Stub out loader.request to avoid making the xhrs.
Result: order of magnitude speed improvement in test run time (from ~1600ms to 160ms on my machine).
* TestResultServer/static-dashboards/run-embedded-unittests.html:
* TestResultServer/static-dashboards/run-unittests.html:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (137382 => 137383)
--- trunk/Tools/ChangeLog 2012-12-12 00:32:36 UTC (rev 137382)
+++ trunk/Tools/ChangeLog 2012-12-12 00:36:00 UTC (rev 137383)
@@ -1,3 +1,17 @@
+2012-12-11 Julie Parent <[email protected]>
+
+ Dashboard unit tests should not make xhrs.
+ https://bugs.webkit.org/show_bug.cgi?id=104598
+
+ Reviewed by Dirk Pranke.
+
+ The unit test were requesting 25 files that they did not use.
+ Stub out loader.request to avoid making the xhrs.
+ Result: order of magnitude speed improvement in test run time (from ~1600ms to 160ms on my machine).
+
+ * TestResultServer/static-dashboards/run-embedded-unittests.html:
+ * TestResultServer/static-dashboards/run-unittests.html:
+
2012-12-11 Filip Pizlo <[email protected]>
Profiler should show bytecode dumps as they would have been visible to the JITs, including the profiling data that the JITs would see
Modified: trunk/Tools/TestResultServer/static-dashboards/run-embedded-unittests.html (137382 => 137383)
--- trunk/Tools/TestResultServer/static-dashboards/run-embedded-unittests.html 2012-12-12 00:32:36 UTC (rev 137382)
+++ trunk/Tools/TestResultServer/static-dashboards/run-embedded-unittests.html 2012-12-12 00:36:00 UTC (rev 137383)
@@ -50,6 +50,10 @@
<script src=""
<script src=""
<script src=""
+<script>
+ // Mock out loader.request so that we don't actually make xhrs for tests.
+ loader.request = function(url, successCallback, errorCallback) {};
+</script>
<script src=""
<script>
Modified: trunk/Tools/TestResultServer/static-dashboards/run-unittests.html (137382 => 137383)
--- trunk/Tools/TestResultServer/static-dashboards/run-unittests.html 2012-12-12 00:32:36 UTC (rev 137382)
+++ trunk/Tools/TestResultServer/static-dashboards/run-unittests.html 2012-12-12 00:36:00 UTC (rev 137383)
@@ -44,6 +44,10 @@
<script src=""
<script src=""
<script src=""
+<script>
+ // Mock out loader.request so that we don't actually make xhrs for tests.
+ loader.request = function(url, successCallback, errorCallback) {};
+</script>
<script src=""
<script>
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
