Title: [137391] trunk
- Revision
- 137391
- Author
- [email protected]
- Date
- 2012-12-11 17:07:00 -0800 (Tue, 11 Dec 2012)
Log Message
ASSERT running platform/mac/plugins/convert-point.html on the WK2 bots
https://bugs.webkit.org/show_bug.cgi?id=104735
Reviewed by Jon Honeycutt.
Tools:
Do the testing from within NPP_New instead of NPN_SetWindow. Plug-ins aren't supposed to do any real work inside NPP_SetWindow,
and doing so will more easily trigger the assertion failure. Ideally we should get rid of the initial sync painting pass, but this
gets the test passing again!
* DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
(ConvertPoint::NPP_New):
LayoutTests:
Unskip test.
* platform/mac-wk2/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (137390 => 137391)
--- trunk/LayoutTests/ChangeLog 2012-12-12 01:03:26 UTC (rev 137390)
+++ trunk/LayoutTests/ChangeLog 2012-12-12 01:07:00 UTC (rev 137391)
@@ -1,3 +1,14 @@
+2012-12-11 Anders Carlsson <[email protected]>
+
+ ASSERT running platform/mac/plugins/convert-point.html on the WK2 bots
+ https://bugs.webkit.org/show_bug.cgi?id=104735
+
+ Reviewed by Jon Honeycutt.
+
+ Unskip test.
+
+ * platform/mac-wk2/TestExpectations:
+
2012-12-11 Xianzhu Wang <[email protected]>
Add window.internals.mainThreadScrollReasonsAsText for testing slow scrolling
Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (137390 => 137391)
--- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2012-12-12 01:03:26 UTC (rev 137390)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2012-12-12 01:07:00 UTC (rev 137391)
@@ -264,9 +264,6 @@
# Causes next test to crash
webkit.org/b/98960 fast/parser/document-open-in-unload.html [ Skip ]
-# Crashes on WK2
-webkit.org/b/104735 platform/mac/plugins/convert-point.html [ Skip ]
-
# ENABLE(SHADOW_DOM) is disabled.
webkit.org/b/76359 editing/shadow [ Skip ]
webkit.org/b/76359 fast/dom/shadow [ Skip ]
Modified: trunk/Tools/ChangeLog (137390 => 137391)
--- trunk/Tools/ChangeLog 2012-12-12 01:03:26 UTC (rev 137390)
+++ trunk/Tools/ChangeLog 2012-12-12 01:07:00 UTC (rev 137391)
@@ -1,3 +1,17 @@
+2012-12-11 Anders Carlsson <[email protected]>
+
+ ASSERT running platform/mac/plugins/convert-point.html on the WK2 bots
+ https://bugs.webkit.org/show_bug.cgi?id=104735
+
+ Reviewed by Jon Honeycutt.
+
+ Do the testing from within NPP_New instead of NPN_SetWindow. Plug-ins aren't supposed to do any real work inside NPP_SetWindow,
+ and doing so will more easily trigger the assertion failure. Ideally we should get rid of the initial sync painting pass, but this
+ gets the test passing again!
+
+ * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
+ (ConvertPoint::NPP_New):
+
2012-12-11 Julie Parent <[email protected]>
Dashboard unit tests should not make xhrs.
Modified: trunk/Tools/DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp (137390 => 137391)
--- trunk/Tools/DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp 2012-12-12 01:03:26 UTC (rev 137390)
+++ trunk/Tools/DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp 2012-12-12 01:07:00 UTC (rev 137391)
@@ -69,7 +69,7 @@
return true;
}
private:
- virtual NPError NPP_SetWindow(NPWindow*)
+ NPError NPP_New(NPMIMEType pluginType, uint16_t mode, int16_t argc, char *argn[], char *argv[], NPSavedData *saved)
{
if (testConvert())
executeScript("document.getElementById('result').innerHTML = 'SUCCESS!'");
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
