Title: [137470] trunk/LayoutTests
- Revision
- 137470
- Author
- k...@webkit.org
- Date
- 2012-12-12 08:43:30 -0800 (Wed, 12 Dec 2012)
Log Message
Fix slow test so it passes consistently now that we have multipart support
in soup.
Reviewed by Martin Robinson.
The multipart-wait-before-boundary test waits for 30 seconds before
sending the boundary. That is a bit long in itself, but it is exactly
the timeout used for slow tests in some platforms. This change reduces
the wait to 20 seconds, which should be enough for the test, and marks
the test as slow for GTK+.
* http/tests/multipart/resources/multipart-wait-before-boundary.php: wait
for 20 seconds instead of 30, before sending the boundary.
* platform/gtk/TestExpectations: mark test above as slow.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (137469 => 137470)
--- trunk/LayoutTests/ChangeLog 2012-12-12 16:11:04 UTC (rev 137469)
+++ trunk/LayoutTests/ChangeLog 2012-12-12 16:43:30 UTC (rev 137470)
@@ -1,3 +1,20 @@
+2012-12-12 Gustavo Noronha Silva <g...@gnome.org>
+
+ Fix slow test so it passes consistently now that we have multipart support
+ in soup.
+
+ Reviewed by Martin Robinson.
+
+ The multipart-wait-before-boundary test waits for 30 seconds before
+ sending the boundary. That is a bit long in itself, but it is exactly
+ the timeout used for slow tests in some platforms. This change reduces
+ the wait to 20 seconds, which should be enough for the test, and marks
+ the test as slow for GTK+.
+
+ * http/tests/multipart/resources/multipart-wait-before-boundary.php: wait
+ for 20 seconds instead of 30, before sending the boundary.
+ * platform/gtk/TestExpectations: mark test above as slow.
+
2012-12-12 Antoine Quint <grao...@apple.com>
Web Inspector: Crash in InspectorDOMAgent::pushNodePathToFrontend when inspecting document with CSS generated content
Modified: trunk/LayoutTests/http/tests/multipart/resources/multipart-wait-before-boundary.php (137469 => 137470)
--- trunk/LayoutTests/http/tests/multipart/resources/multipart-wait-before-boundary.php 2012-12-12 16:11:04 UTC (rev 137469)
+++ trunk/LayoutTests/http/tests/multipart/resources/multipart-wait-before-boundary.php 2012-12-12 16:43:30 UTC (rev 137470)
@@ -38,5 +38,5 @@
echo("third html");
echo("<!-- $padding -->");
flush();
- usleep(30 * 1000000);
+ usleep(20 * 1000000);
?>
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (137469 => 137470)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2012-12-12 16:11:04 UTC (rev 137469)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2012-12-12 16:43:30 UTC (rev 137470)
@@ -1142,9 +1142,7 @@
# This test is out-dated since r95899.
webkit.org/b/65709 canvas/philip/tests/2d.drawImage.outsidesource.html [ Failure ]
-# The timeout is caused apparently by the whole process hanging; probably a bug in soup,
-# needs further investigation.
-Bug(GTK) http/tests/multipart/multipart-wait-before-boundary.html [ Timeout ]
+Bug(GTK) http/tests/multipart/multipart-wait-before-boundary.html [ Slow ]
# Does not render the rectangle as it should, even though the multiple parts seem to work
webkit.org/b/54251 http/tests/multipart/invalid-image-data.html [ Timeout ]
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes