Title: [137485] trunk/Tools
- Revision
- 137485
- Author
- [email protected]
- Date
- 2012-12-12 11:05:37 -0800 (Wed, 12 Dec 2012)
Log Message
garden-o-matic should prefer efl/ over efl-wk1/ and efl-wk2/ when rebaselining
https://bugs.webkit.org/show_bug.cgi?id=102389
Reviewed by Tony Chang.
The code wasn't aware of both the efl-wk1 and efl-wk2 variants,
because all_port_names() by itself doesn't tell you about the
variants. Work around this for now, and filed bug 104761 to
address the underlying problem.
* Scripts/webkitpy/common/checkout/baselineoptimizer.py:
* Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
(BaselineOptimizerTest.test_efl):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (137484 => 137485)
--- trunk/Tools/ChangeLog 2012-12-12 19:02:54 UTC (rev 137484)
+++ trunk/Tools/ChangeLog 2012-12-12 19:05:37 UTC (rev 137485)
@@ -1,3 +1,19 @@
+2012-12-12 Dirk Pranke <[email protected]>
+
+ garden-o-matic should prefer efl/ over efl-wk1/ and efl-wk2/ when rebaselining
+ https://bugs.webkit.org/show_bug.cgi?id=102389
+
+ Reviewed by Tony Chang.
+
+ The code wasn't aware of both the efl-wk1 and efl-wk2 variants,
+ because all_port_names() by itself doesn't tell you about the
+ variants. Work around this for now, and filed bug 104761 to
+ address the underlying problem.
+
+ * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
+ * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
+ (BaselineOptimizerTest.test_efl):
+
2012-12-12 Krzysztof Czech <[email protected]>
[EFL] Possibility to turn off accessibility feature for WebKit-EFL.
Modified: trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py (137484 => 137485)
--- trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py 2012-12-12 19:02:54 UTC (rev 137484)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py 2012-12-12 19:05:37 UTC (rev 137485)
@@ -60,6 +60,10 @@
'mac-future': ['LayoutTests/platform/mac-future', 'LayoutTests/platform/mac', 'LayoutTests'],
'win-future': ['LayoutTests/platform/win-future', 'LayoutTests/platform/win', 'LayoutTests'],
'qt-unknown': ['LayoutTests/platform/qt-unknown', 'LayoutTests/platform/qt', 'LayoutTests'],
+
+ # FIXME: Account for the efl-wk2 port which isn't returned in builders.all_port_names().
+ # See https://bugs.webkit.org/show_bug.cgi?id=104761.
+ 'efl-wk2': ['LayoutTests/platform/efl-wk2', 'LayoutTests/platform/efl', 'LayoutTests'],
}
Modified: trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py (137484 => 137485)
--- trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py 2012-12-12 19:02:54 UTC (rev 137484)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py 2012-12-12 19:05:37 UTC (rev 137485)
@@ -82,6 +82,14 @@
'LayoutTests/platform/chromium-win': '462d03b9c025db1b0392d7453310dbee5f9a9e74',
})
+ def test_efl(self):
+ self._assertOptimization({
+ 'LayoutTests/platform/efl': '462d03b9c025db1b0392d7453310dbee5f9a9e74',
+ }, {
+ 'LayoutTests/platform/efl': '462d03b9c025db1b0392d7453310dbee5f9a9e74',
+ })
+
+
def test_no_add_mac_future(self):
self._assertOptimization({
'LayoutTests/platform/mac': '29a1715a6470d5dd9486a142f609708de84cdac8',
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
