Title: [137577] trunk/Source/WebCore
- Revision
- 137577
- Author
- [email protected]
- Date
- 2012-12-13 02:09:15 -0800 (Thu, 13 Dec 2012)
Log Message
Safari spends a lot of time in WebCore::findSimpleWordBoundary while selecting text on large scrabutility.com page
https://bugs.webkit.org/show_bug.cgi?id=104884
Reviewed by Hajime Morita.
We don't need to do anything in AlternativeTextController if selection is already outside of the editable region.
No new tests are added since this is only a performance improvement, and doesn't change any asymptotic behavior.
* editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::respondToChangedSelection):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (137576 => 137577)
--- trunk/Source/WebCore/ChangeLog 2012-12-13 09:42:42 UTC (rev 137576)
+++ trunk/Source/WebCore/ChangeLog 2012-12-13 10:09:15 UTC (rev 137577)
@@ -1,3 +1,17 @@
+2012-12-13 Ryosuke Niwa <[email protected]>
+
+ Safari spends a lot of time in WebCore::findSimpleWordBoundary while selecting text on large scrabutility.com page
+ https://bugs.webkit.org/show_bug.cgi?id=104884
+
+ Reviewed by Hajime Morita.
+
+ We don't need to do anything in AlternativeTextController if selection is already outside of the editable region.
+
+ No new tests are added since this is only a performance improvement, and doesn't change any asymptotic behavior.
+
+ * editing/AlternativeTextController.cpp:
+ (WebCore::AlternativeTextController::respondToChangedSelection):
+
2012-12-12 Jon Lee <[email protected]>
Crash in PlugInOriginHash with empty MIME type (104882)
Modified: trunk/Source/WebCore/editing/AlternativeTextController.cpp (137576 => 137577)
--- trunk/Source/WebCore/editing/AlternativeTextController.cpp 2012-12-13 09:42:42 UTC (rev 137576)
+++ trunk/Source/WebCore/editing/AlternativeTextController.cpp 2012-12-13 10:09:15 UTC (rev 137577)
@@ -452,7 +452,7 @@
// containing the original pre-correction word so that user can quickly revert the
// undesired autocorrection. Here, we start correction panel timer once we confirm that
// the new caret position is at the end of a word.
- if (!currentSelection.isCaret() || currentSelection == oldSelection)
+ if (!currentSelection.isCaret() || currentSelection == oldSelection || !currentSelection.isContentEditable())
return;
VisiblePosition selectionPosition = currentSelection.start();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
