Title: [137596] trunk
- Revision
- 137596
- Author
- [email protected]
- Date
- 2012-12-13 07:43:38 -0800 (Thu, 13 Dec 2012)
Log Message
[GTK] Expose ARIA roles for tab, tabpanel and tablist
https://bugs.webkit.org/show_bug.cgi?id=84043
Patch by Joanmarie Diggs <[email protected]> on 2012-12-13
Reviewed by Martin Robinson.
Source/WebCore:
Mapped the ARIA roles to their corresponding ATK roles.
No new tests; instead unskipped the associated test.
* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole): Mapped the ARIA roles to their corresponding ATK roles
LayoutTests:
Mapped the ARIA roles to the corresponding ATK roles and unskipped the
associated test. Also created the missing platform-specific expected
results.
* accessibility/aria-tab-roles-expected.txt: Added.
* platform/gtk/TestExpectations: Unskipped the associated test.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (137595 => 137596)
--- trunk/LayoutTests/ChangeLog 2012-12-13 15:34:41 UTC (rev 137595)
+++ trunk/LayoutTests/ChangeLog 2012-12-13 15:43:38 UTC (rev 137596)
@@ -1,3 +1,17 @@
+2012-12-13 Joanmarie Diggs <[email protected]>
+
+ [GTK] Expose ARIA roles for tab, tabpanel and tablist
+ https://bugs.webkit.org/show_bug.cgi?id=84043
+
+ Reviewed by Martin Robinson.
+
+ Mapped the ARIA roles to the corresponding ATK roles and unskipped the
+ associated test. Also created the missing platform-specific expected
+ results.
+
+ * accessibility/aria-tab-roles-expected.txt: Added.
+ * platform/gtk/TestExpectations: Unskipped the associated test.
+
2012-12-13 Sheriff Bot <[email protected]>
Unreviewed, rolling out r137512.
Added: trunk/LayoutTests/accessibility/aria-tab-roles-expected.txt (0 => 137596)
--- trunk/LayoutTests/accessibility/aria-tab-roles-expected.txt (rev 0)
+++ trunk/LayoutTests/accessibility/aria-tab-roles-expected.txt 2012-12-13 15:43:38 UTC (rev 137596)
@@ -0,0 +1,21 @@
+Crust
+Veges
+Select Crust
+
+This tests that the aria roles for tab, tabpanel and tablist work as expected correctly.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+tabList.role = AXRole: AXTabGroup
+tab1.role = AXRole: AXTab
+PASS tab1.title is 'AXTitle: Crust'
+PASS tab1.childrenCount is 0
+tab2.role = AXRole: AXTab
+PASS tab2.title is 'AXTitle: Veges'
+tabPanel.role = AXRole: AXGroup
+tabPanel.subrole =
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (137595 => 137596)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2012-12-13 15:34:41 UTC (rev 137595)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2012-12-13 15:43:38 UTC (rev 137596)
@@ -41,7 +41,6 @@
# Tests that require new results.
#////////////////////////////////////////////////////////////////////////////////////////
-webkit.org/b/84043 accessibility/aria-tab-roles.html [ Missing ]
webkit.org/b/84044 accessibility/image-link.html [ Missing ]
webkit.org/b/84045 accessibility/image-map1.html [ Missing ]
webkit.org/b/84045 accessibility/image-map2.html [ Missing ]
Modified: trunk/Source/WebCore/ChangeLog (137595 => 137596)
--- trunk/Source/WebCore/ChangeLog 2012-12-13 15:34:41 UTC (rev 137595)
+++ trunk/Source/WebCore/ChangeLog 2012-12-13 15:43:38 UTC (rev 137596)
@@ -1,3 +1,17 @@
+2012-12-13 Joanmarie Diggs <[email protected]>
+
+ [GTK] Expose ARIA roles for tab, tabpanel and tablist
+ https://bugs.webkit.org/show_bug.cgi?id=84043
+
+ Reviewed by Martin Robinson.
+
+ Mapped the ARIA roles to their corresponding ATK roles.
+
+ No new tests; instead unskipped the associated test.
+
+ * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
+ (atkRole): Mapped the ARIA roles to their corresponding ATK roles
+
2012-12-13 Vivek Galatage <[email protected]>
Web Inspector: "Add Attribute" context menu on closing tag should apply on the opening tag on Elements Panel
Modified: trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp (137595 => 137596)
--- trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2012-12-13 15:34:41 UTC (rev 137595)
+++ trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2012-12-13 15:43:38 UTC (rev 137596)
@@ -478,6 +478,7 @@
case SliderRole:
return ATK_ROLE_SLIDER;
case TabGroupRole:
+ case TabListRole:
return ATK_ROLE_PAGE_TAB_LIST;
case TextFieldRole:
case TextAreaRole:
@@ -531,6 +532,7 @@
return ATK_ROLE_APPLICATION;
case GroupRole:
case RadioGroupRole:
+ case TabPanelRole:
return ATK_ROLE_PANEL;
case RowHeaderRole: // Row headers are cells after all.
case ColumnHeaderRole: // Column headers are cells after all.
@@ -570,6 +572,8 @@
return ATK_ROLE_SEPARATOR;
case SpinButtonRole:
return ATK_ROLE_SPIN_BUTTON;
+ case TabRole:
+ return ATK_ROLE_PAGE_TAB;
default:
return ATK_ROLE_UNKNOWN;
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
