Title: [137606] trunk/Source/WebCore
- Revision
- 137606
- Author
- [email protected]
- Date
- 2012-12-13 10:16:58 -0800 (Thu, 13 Dec 2012)
Log Message
Duplicate code in GraphicsContext3D::validateAttributes() and GraphicsContext3D::validateDepthStencil()
https://bugs.webkit.org/show_bug.cgi?id=97275
Reviewed by Dean Jackson.
Remove duplicate code in validateAttributes(). validateAttributes() calls
validateDepthStencil() which has the exact same code.
No new tests because no change in functionality.
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::validateAttributes):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (137605 => 137606)
--- trunk/Source/WebCore/ChangeLog 2012-12-13 17:41:29 UTC (rev 137605)
+++ trunk/Source/WebCore/ChangeLog 2012-12-13 18:16:58 UTC (rev 137606)
@@ -1,3 +1,18 @@
+2012-12-13 Pratik Solanki <[email protected]>
+
+ Duplicate code in GraphicsContext3D::validateAttributes() and GraphicsContext3D::validateDepthStencil()
+ https://bugs.webkit.org/show_bug.cgi?id=97275
+
+ Reviewed by Dean Jackson.
+
+ Remove duplicate code in validateAttributes(). validateAttributes() calls
+ validateDepthStencil() which has the exact same code.
+
+ No new tests because no change in functionality.
+
+ * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
+ (WebCore::GraphicsContext3D::validateAttributes):
+
2012-12-13 Nate Chapin <[email protected]>
CachedResources should hang on to stripped fragment identifiers
Modified: trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp (137605 => 137606)
--- trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp 2012-12-13 17:41:29 UTC (rev 137605)
+++ trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp 2012-12-13 18:16:58 UTC (rev 137606)
@@ -62,14 +62,7 @@
void GraphicsContext3D::validateAttributes()
{
- Extensions3D* extensions = getExtensions();
validateDepthStencil("GL_EXT_packed_depth_stencil");
- if (m_attrs.antialias) {
- if (!extensions->maySupportMultisampling() || !extensions->supports("GL_ANGLE_framebuffer_multisample") || isGLES2Compliant())
- m_attrs.antialias = false;
- else
- extensions->ensureEnabled("GL_ANGLE_framebuffer_multisample");
- }
}
bool GraphicsContext3D::reshapeFBOs(const IntSize& size)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
