Title: [137631] trunk/Source/WebCore
- Revision
- 137631
- Author
- [email protected]
- Date
- 2012-12-13 11:46:13 -0800 (Thu, 13 Dec 2012)
Log Message
ResourceLoader::didReceiveAuthenticationChallenge uses a wrong client
https://bugs.webkit.org/show_bug.cgi?id=104935
<rdar://problem/12870361>
Reviewed by Anders Carlsson.
* loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
The handle is null when NetworkProcess is used. In any case, it should be correct
to use the client carried within AuthenticationChallenge.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (137630 => 137631)
--- trunk/Source/WebCore/ChangeLog 2012-12-13 19:32:23 UTC (rev 137630)
+++ trunk/Source/WebCore/ChangeLog 2012-12-13 19:46:13 UTC (rev 137631)
@@ -1,3 +1,15 @@
+2012-12-13 Alexey Proskuryakov <[email protected]>
+
+ ResourceLoader::didReceiveAuthenticationChallenge uses a wrong client
+ https://bugs.webkit.org/show_bug.cgi?id=104935
+ <rdar://problem/12870361>
+
+ Reviewed by Anders Carlsson.
+
+ * loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
+ The handle is null when NetworkProcess is used. In any case, it should be correct
+ to use the client carried within AuthenticationChallenge.
+
2012-12-13 Stephen White <[email protected]>
CanvasRenderingContext2D::setFont() is slow.
Modified: trunk/Source/WebCore/loader/ResourceLoader.cpp (137630 => 137631)
--- trunk/Source/WebCore/loader/ResourceLoader.cpp 2012-12-13 19:32:23 UTC (rev 137630)
+++ trunk/Source/WebCore/loader/ResourceLoader.cpp 2012-12-13 19:46:13 UTC (rev 137631)
@@ -499,8 +499,8 @@
// Only these platforms provide a way to continue without credentials.
// If we can't continue with credentials, we need to cancel the load altogether.
#if PLATFORM(MAC) || USE(CFNETWORK) || USE(CURL) || PLATFORM(GTK) || PLATFORM(EFL)
- handle()->receivedRequestToContinueWithoutCredential(challenge);
- ASSERT(!handle()->hasAuthenticationChallenge());
+ challenge.authenticationClient()->receivedRequestToContinueWithoutCredential(challenge);
+ ASSERT(!handle() || !handle()->hasAuthenticationChallenge());
#else
didFail(blockedError());
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
