Title: [137633] trunk/Source/WebCore
- Revision
- 137633
- Author
- [email protected]
- Date
- 2012-12-13 11:51:49 -0800 (Thu, 13 Dec 2012)
Log Message
[GTK] Safeguard against possible NULL-dereference
https://bugs.webkit.org/show_bug.cgi?id=104931
Patch by Claudio Saavedra <[email protected]> on 2012-12-13
Reviewed by Chris Fleizach.
This was spotted by Coverity. See bug 104114.
* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetIndexInParent): If parent is NULL
bail out early.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (137632 => 137633)
--- trunk/Source/WebCore/ChangeLog 2012-12-13 19:48:26 UTC (rev 137632)
+++ trunk/Source/WebCore/ChangeLog 2012-12-13 19:51:49 UTC (rev 137633)
@@ -1,3 +1,16 @@
+2012-12-13 Claudio Saavedra <[email protected]>
+
+ [GTK] Safeguard against possible NULL-dereference
+ https://bugs.webkit.org/show_bug.cgi?id=104931
+
+ Reviewed by Chris Fleizach.
+
+ This was spotted by Coverity. See bug 104114.
+
+ * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
+ (webkitAccessibleGetIndexInParent): If parent is NULL
+ bail out early.
+
2012-12-13 David Barton <[email protected]>
Heap-use-after-free in WebCore::RenderBlock::finishDelayUpdateScrollInfo
Modified: trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp (137632 => 137633)
--- trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2012-12-13 19:48:26 UTC (rev 137632)
+++ trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2012-12-13 19:51:49 UTC (rev 137633)
@@ -407,6 +407,9 @@
AccessibilityObject* coreObject = core(object);
AccessibilityObject* parent = coreObject->parentObjectUnignored();
+ if (!parent)
+ return -1;
+
if (!parent && isRootObject(coreObject)) {
AtkObject* atkParent = atkParentOfRootObject(object);
if (!atkParent)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
