Title: [137797] trunk/Source/WebKit2
- Revision
- 137797
- Author
- [email protected]
- Date
- 2012-12-15 10:49:42 -0800 (Sat, 15 Dec 2012)
Log Message
[GTK][WK2] Memory leak in ChunkedUpdateDrawingArea::paintIntoUpdateChunk()
https://bugs.webkit.org/show_bug.cgi?id=105095
Reviewed by Martin Robinson.
Adopt the pointer returned by cairo_create() in
ChunkedUpdateDrawingArea::paintIntoUpdateChunk() to avoid leaking
memory.
* WebProcess/WebPage/gtk/ChunkedUpdateDrawingAreaGtk.cpp:
(WebKit::ChunkedUpdateDrawingArea::paintIntoUpdateChunk):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (137796 => 137797)
--- trunk/Source/WebKit2/ChangeLog 2012-12-15 09:02:47 UTC (rev 137796)
+++ trunk/Source/WebKit2/ChangeLog 2012-12-15 18:49:42 UTC (rev 137797)
@@ -1,3 +1,17 @@
+2012-12-15 Christophe Dumez <[email protected]>
+
+ [GTK][WK2] Memory leak in ChunkedUpdateDrawingArea::paintIntoUpdateChunk()
+ https://bugs.webkit.org/show_bug.cgi?id=105095
+
+ Reviewed by Martin Robinson.
+
+ Adopt the pointer returned by cairo_create() in
+ ChunkedUpdateDrawingArea::paintIntoUpdateChunk() to avoid leaking
+ memory.
+
+ * WebProcess/WebPage/gtk/ChunkedUpdateDrawingAreaGtk.cpp:
+ (WebKit::ChunkedUpdateDrawingArea::paintIntoUpdateChunk):
+
2012-12-15 Mark Lam <[email protected]>
Added #if ENABLE(SQL_DATABASE) around WebPlatformStrategies::getDatabaseServer().
Modified: trunk/Source/WebKit2/WebProcess/WebPage/gtk/ChunkedUpdateDrawingAreaGtk.cpp (137796 => 137797)
--- trunk/Source/WebKit2/WebProcess/WebPage/gtk/ChunkedUpdateDrawingAreaGtk.cpp 2012-12-15 09:02:47 UTC (rev 137796)
+++ trunk/Source/WebKit2/WebProcess/WebPage/gtk/ChunkedUpdateDrawingAreaGtk.cpp 2012-12-15 18:49:42 UTC (rev 137797)
@@ -44,7 +44,7 @@
ASSERT(!updateChunk->isEmpty());
RefPtr<cairo_surface_t> image = updateChunk->createImage();
- RefPtr<cairo_t> cr = cairo_create(image.get());
+ RefPtr<cairo_t> cr = adoptRef(cairo_create(image.get()));
GraphicsContext gc(cr.get());
gc.save();
IntRect rect = updateChunk->rect();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
