Title: [137991] trunk/Source/WebKit/blackberry
- Revision
- 137991
- Author
- [email protected]
- Date
- 2012-12-17 23:34:20 -0800 (Mon, 17 Dec 2012)
Log Message
[BlackBerry] Editable text element can't be selected
https://bugs.webkit.org/show_bug.cgi?id=105240
Patch by Sean Wang <[email protected]> on 2012-12-17
Reviewed by Rob Buis.
Internally reviewed by Genevieve Mak and Mike Fenton.
Internal PR266755
When the target is Text, we should allow it to collect text nodes in
the shadow tree of text editable elements.
* WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::getNodesFromRect):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (137990 => 137991)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-12-18 07:28:52 UTC (rev 137990)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-12-18 07:34:20 UTC (rev 137991)
@@ -1,3 +1,18 @@
+2012-12-17 Sean Wang <[email protected]>
+
+ [BlackBerry] Editable text element can't be selected
+ https://bugs.webkit.org/show_bug.cgi?id=105240
+
+ Reviewed by Rob Buis.
+ Internally reviewed by Genevieve Mak and Mike Fenton.
+
+ Internal PR266755
+ When the target is Text, we should allow it to collect text nodes in
+ the shadow tree of text editable elements.
+
+ * WebKitSupport/FatFingers.cpp:
+ (BlackBerry::WebKit::FatFingers::getNodesFromRect):
+
2012-12-17 Yongxin Dai <[email protected]>
[BlackBerry] Prevent selection handles from being rendered after selection was canceled
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp (137990 => 137991)
--- trunk/Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp 2012-12-18 07:28:52 UTC (rev 137990)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp 2012-12-18 07:34:20 UTC (rev 137991)
@@ -496,7 +496,7 @@
// The user functions checkForText() and findIntersectingRegions() uses the Node.wholeText() to checkFingerIntersection()
// not the text in its shadow tree.
HitTestRequest::HitTestRequestType requestType = HitTestRequest::ReadOnly | HitTestRequest::Active | HitTestRequest::IgnoreClipping;
- if (m_targetType != Text)
+ if (m_targetType == Text)
requestType |= HitTestRequest::AllowShadowContent;
HitTestResult result(contentPos, topPadding, rightPadding, bottomPadding, leftPadding);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
