Title: [138011] trunk/Source/WebCore
- Revision
- 138011
- Author
- [email protected]
- Date
- 2012-12-18 04:57:16 -0800 (Tue, 18 Dec 2012)
Log Message
Web Inspector: [Network] Ordering of cookies displayed is nondeterministic.
https://bugs.webkit.org/show_bug.cgi?id=105272
Patch by Eugene Klyuchnikov <[email protected]> on 2012-12-18
Reviewed by Alexander Pavlov.
This patch fixes double-selection of request and sets default ordering
of cookies.
* inspector/front-end/CookiesTable.js: By default sort by name.
* inspector/front-end/NetworkPanel.js: Remove redundant member, make
rows "not-selectable", activate request selection on "mouse-down".
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (138010 => 138011)
--- trunk/Source/WebCore/ChangeLog 2012-12-18 12:49:10 UTC (rev 138010)
+++ trunk/Source/WebCore/ChangeLog 2012-12-18 12:57:16 UTC (rev 138011)
@@ -1,3 +1,17 @@
+2012-12-18 Eugene Klyuchnikov <[email protected]>
+
+ Web Inspector: [Network] Ordering of cookies displayed is nondeterministic.
+ https://bugs.webkit.org/show_bug.cgi?id=105272
+
+ Reviewed by Alexander Pavlov.
+
+ This patch fixes double-selection of request and sets default ordering
+ of cookies.
+
+ * inspector/front-end/CookiesTable.js: By default sort by name.
+ * inspector/front-end/NetworkPanel.js: Remove redundant member, make
+ rows "not-selectable", activate request selection on "mouse-down".
+
2012-12-18 Tommy Widenflycht <[email protected]>
[JSC] Refactoring CodeGeneratorJS.pm to simplify adding support for overloaded constructors
Modified: trunk/Source/WebCore/inspector/front-end/CookiesTable.js (138010 => 138011)
--- trunk/Source/WebCore/inspector/front-end/CookiesTable.js 2012-12-18 12:49:10 UTC (rev 138010)
+++ trunk/Source/WebCore/inspector/front-end/CookiesTable.js 2012-12-18 12:57:16 UTC (rev 138011)
@@ -45,6 +45,7 @@
columns[0].sortable = true;
columns[0].disclosure = expandable;
columns[0].width = "24%";
+ columns[0].sort = "ascending";
columns[1].title = WebInspector.UIString("Value");
columns[1].sortable = true;
columns[1].width = "34%";
Modified: trunk/Source/WebCore/inspector/front-end/NetworkPanel.js (138010 => 138011)
--- trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2012-12-18 12:49:10 UTC (rev 138010)
+++ trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2012-12-18 12:57:16 UTC (rev 138011)
@@ -48,7 +48,6 @@
WebInspector.View.call(this);
this.registerRequiredCSS("networkLogView.css");
- this._allowRequestSelection = false;
this._requests = [];
this._requestsById = {};
this._requestsByURL = {};
@@ -1489,7 +1488,6 @@
this._networkLogView.switchToDetailedView();
this._networkLogView.allowPopover = true;
- this._networkLogView._allowRequestSelection = false;
},
_toggleViewingRequestMode: function()
@@ -1501,7 +1499,6 @@
this.element.addStyleClass("viewing-resource");
this.splitView.showMainElement();
this._networkLogView.allowPopover = false;
- this._networkLogView._allowRequestSelection = true;
this._networkLogView.switchToBriefView();
},
@@ -1846,8 +1843,9 @@
this._sizeCell = this._createDivInTD("size");
this._timeCell = this._createDivInTD("time");
this._createTimelineCell();
- this._nameCell.addEventListener("click", this.select.bind(this), false);
+ this._nameCell.addEventListener("mousedown", this.select.bind(this), false);
this._nameCell.addEventListener("dblclick", this._openInNewTab.bind(this), false);
+ this.selectable = false;
},
isFilteredOut: function()
@@ -1884,11 +1882,6 @@
InspectorFrontendHost.openInNewTab(this._request.url);
},
- get selectable()
- {
- return this._parentView._allowRequestSelection && !this.isFilteredOut();
- },
-
_createDivInTD: function(columnIdentifier)
{
var td = document.createElement("td");
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
