Title: [138013] trunk/Source/WebCore
- Revision
- 138013
- Author
- [email protected]
- Date
- 2012-12-18 05:42:51 -0800 (Tue, 18 Dec 2012)
Log Message
Unreviewed, rolling out r138011.
http://trac.webkit.org/changeset/138011
https://bugs.webkit.org/show_bug.cgi?id=105272
WebInspector: Broke request selection in the Network panel
* inspector/front-end/CookiesTable.js:
(WebInspector.CookiesTable):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype._toggleGridMode):
(WebInspector.NetworkPanel.prototype._toggleViewingRequestMode):
(WebInspector.NetworkDataGridNode.prototype.createCells):
(WebInspector.NetworkDataGridNode.prototype.get selectable):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (138012 => 138013)
--- trunk/Source/WebCore/ChangeLog 2012-12-18 13:04:51 UTC (rev 138012)
+++ trunk/Source/WebCore/ChangeLog 2012-12-18 13:42:51 UTC (rev 138013)
@@ -1,3 +1,19 @@
+2012-12-18 Alexander Pavlov <[email protected]>
+
+ Unreviewed, rolling out r138011.
+ http://trac.webkit.org/changeset/138011
+ https://bugs.webkit.org/show_bug.cgi?id=105272
+
+ WebInspector: Broke request selection in the Network panel
+
+ * inspector/front-end/CookiesTable.js:
+ (WebInspector.CookiesTable):
+ * inspector/front-end/NetworkPanel.js:
+ (WebInspector.NetworkPanel.prototype._toggleGridMode):
+ (WebInspector.NetworkPanel.prototype._toggleViewingRequestMode):
+ (WebInspector.NetworkDataGridNode.prototype.createCells):
+ (WebInspector.NetworkDataGridNode.prototype.get selectable):
+
2012-12-18 Nate Chapin <[email protected]>
REGRESSION (r137607): Cannot download files, stuck in “Preparing to download”
Modified: trunk/Source/WebCore/inspector/front-end/CookiesTable.js (138012 => 138013)
--- trunk/Source/WebCore/inspector/front-end/CookiesTable.js 2012-12-18 13:04:51 UTC (rev 138012)
+++ trunk/Source/WebCore/inspector/front-end/CookiesTable.js 2012-12-18 13:42:51 UTC (rev 138013)
@@ -45,7 +45,6 @@
columns[0].sortable = true;
columns[0].disclosure = expandable;
columns[0].width = "24%";
- columns[0].sort = "ascending";
columns[1].title = WebInspector.UIString("Value");
columns[1].sortable = true;
columns[1].width = "34%";
Modified: trunk/Source/WebCore/inspector/front-end/NetworkPanel.js (138012 => 138013)
--- trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2012-12-18 13:04:51 UTC (rev 138012)
+++ trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2012-12-18 13:42:51 UTC (rev 138013)
@@ -48,6 +48,7 @@
WebInspector.View.call(this);
this.registerRequiredCSS("networkLogView.css");
+ this._allowRequestSelection = false;
this._requests = [];
this._requestsById = {};
this._requestsByURL = {};
@@ -1488,6 +1489,7 @@
this._networkLogView.switchToDetailedView();
this._networkLogView.allowPopover = true;
+ this._networkLogView._allowRequestSelection = false;
},
_toggleViewingRequestMode: function()
@@ -1499,6 +1501,7 @@
this.element.addStyleClass("viewing-resource");
this.splitView.showMainElement();
this._networkLogView.allowPopover = false;
+ this._networkLogView._allowRequestSelection = true;
this._networkLogView.switchToBriefView();
},
@@ -1843,9 +1846,8 @@
this._sizeCell = this._createDivInTD("size");
this._timeCell = this._createDivInTD("time");
this._createTimelineCell();
- this._nameCell.addEventListener("mousedown", this.select.bind(this), false);
+ this._nameCell.addEventListener("click", this.select.bind(this), false);
this._nameCell.addEventListener("dblclick", this._openInNewTab.bind(this), false);
- this.selectable = false;
},
isFilteredOut: function()
@@ -1882,6 +1884,11 @@
InspectorFrontendHost.openInNewTab(this._request.url);
},
+ get selectable()
+ {
+ return this._parentView._allowRequestSelection && !this.isFilteredOut();
+ },
+
_createDivInTD: function(columnIdentifier)
{
var td = document.createElement("td");
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
