Title: [138306] trunk/Source/WebKit2
- Revision
- 138306
- Author
- [email protected]
- Date
- 2012-12-20 15:10:36 -0800 (Thu, 20 Dec 2012)
Log Message
LocalTerminationDisabler is not needed in WebCookieManager.cpp
https://bugs.webkit.org/show_bug.cgi?id=105581
Reviewed by Anders Carlsson.
All WebCookieManager functions are synchronous, and all LocalTerminationDisabler does
is enable/disable a timer that cannot fire inside the function anyway.
* WebProcess/Cookies/WebCookieManager.cpp:
(WebKit::WebCookieManager::getHostnamesWithCookies):
(WebKit::WebCookieManager::deleteCookiesForHostname):
(WebKit::WebCookieManager::deleteAllCookies):
(WebKit::WebCookieManager::startObservingCookieChanges):
(WebKit::WebCookieManager::setHTTPCookieAcceptPolicy):
(WebKit::WebCookieManager::getHTTPCookieAcceptPolicy):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (138305 => 138306)
--- trunk/Source/WebKit2/ChangeLog 2012-12-20 23:06:46 UTC (rev 138305)
+++ trunk/Source/WebKit2/ChangeLog 2012-12-20 23:10:36 UTC (rev 138306)
@@ -1,3 +1,21 @@
+2012-12-20 Alexey Proskuryakov <[email protected]>
+
+ LocalTerminationDisabler is not needed in WebCookieManager.cpp
+ https://bugs.webkit.org/show_bug.cgi?id=105581
+
+ Reviewed by Anders Carlsson.
+
+ All WebCookieManager functions are synchronous, and all LocalTerminationDisabler does
+ is enable/disable a timer that cannot fire inside the function anyway.
+
+ * WebProcess/Cookies/WebCookieManager.cpp:
+ (WebKit::WebCookieManager::getHostnamesWithCookies):
+ (WebKit::WebCookieManager::deleteCookiesForHostname):
+ (WebKit::WebCookieManager::deleteAllCookies):
+ (WebKit::WebCookieManager::startObservingCookieChanges):
+ (WebKit::WebCookieManager::setHTTPCookieAcceptPolicy):
+ (WebKit::WebCookieManager::getHTTPCookieAcceptPolicy):
+
2012-12-20 Brady Eidson <[email protected]>
NetworkProcess has no need for suspend/resumePendingRequests.
Modified: trunk/Source/WebKit2/WebProcess/Cookies/WebCookieManager.cpp (138305 => 138306)
--- trunk/Source/WebKit2/WebProcess/Cookies/WebCookieManager.cpp 2012-12-20 23:06:46 UTC (rev 138305)
+++ trunk/Source/WebKit2/WebProcess/Cookies/WebCookieManager.cpp 2012-12-20 23:10:36 UTC (rev 138306)
@@ -53,8 +53,6 @@
void WebCookieManager::getHostnamesWithCookies(uint64_t callbackID)
{
- WebProcess::LocalTerminationDisabler terminationDisabler(WebProcess::shared());
-
HashSet<String> hostnames;
WebCore::getHostnamesWithCookies(0, hostnames);
@@ -67,22 +65,16 @@
void WebCookieManager::deleteCookiesForHostname(const String& hostname)
{
- WebProcess::LocalTerminationDisabler terminationDisabler(WebProcess::shared());
-
WebCore::deleteCookiesForHostname(0, hostname);
}
void WebCookieManager::deleteAllCookies()
{
- WebProcess::LocalTerminationDisabler terminationDisabler(WebProcess::shared());
-
WebCore::deleteAllCookies(0);
}
void WebCookieManager::startObservingCookieChanges()
{
- WebProcess::LocalTerminationDisabler terminationDisabler(WebProcess::shared());
-
WebCore::startObservingCookieChanges();
}
@@ -98,13 +90,11 @@
void WebCookieManager::setHTTPCookieAcceptPolicy(HTTPCookieAcceptPolicy policy)
{
- WebProcess::LocalTerminationDisabler terminationDisabler(WebProcess::shared());
platformSetHTTPCookieAcceptPolicy(policy);
}
void WebCookieManager::getHTTPCookieAcceptPolicy(uint64_t callbackID)
{
- WebProcess::LocalTerminationDisabler terminationDisabler(WebProcess::shared());
WebProcess::shared().connection()->send(Messages::WebCookieManagerProxy::DidGetHTTPCookieAcceptPolicy(platformGetHTTPCookieAcceptPolicy(), callbackID), 0);
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
