- Revision
- 138405
- Author
- [email protected]
- Date
- 2012-12-21 17:06:25 -0800 (Fri, 21 Dec 2012)
Log Message
[Mountain Lion] platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html failing
https://bugs.webkit.org/show_bug.cgi?id=95477
Reviewed by Sam Weinig.
Tools:
Co-authored by Jia Pu.
Specify a fixed autocorrection dictionary in resetDefaultsToConsistentValues() so that
we can have consistent autocorrection behavior when running tests.
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
* WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
(WTR::InjectedBundle::platformInitialize):
LayoutTests:
Use "notationl" -> "notational" auto correction in autocorrection-blockquote-crash.html to get reliable results.
Also add a failing expectation to removing-underline-after-accepting-autocorrection-using-punctuation.html for WebKit2.
This failure is tracked by the bug 105616.
* platform/mac-wk2/TestExpectations:
* platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt:
* platform/mac/editing/spelling/autocorrection-blockquote-crash.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (138404 => 138405)
--- trunk/LayoutTests/ChangeLog 2012-12-22 00:24:18 UTC (rev 138404)
+++ trunk/LayoutTests/ChangeLog 2012-12-22 01:06:25 UTC (rev 138405)
@@ -1,3 +1,18 @@
+2012-12-21 Ryosuke Niwa <[email protected]>
+
+ [Mountain Lion] platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html failing
+ https://bugs.webkit.org/show_bug.cgi?id=95477
+
+ Reviewed by Sam Weinig.
+
+ Use "notationl" -> "notational" auto correction in autocorrection-blockquote-crash.html to get reliable results.
+ Also add a failing expectation to removing-underline-after-accepting-autocorrection-using-punctuation.html for WebKit2.
+ This failure is tracked by the bug 105616.
+
+ * platform/mac-wk2/TestExpectations:
+ * platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt:
+ * platform/mac/editing/spelling/autocorrection-blockquote-crash.html:
+
2012-12-21 Joshua Bell <[email protected]>
[Chromium] IndexedDB: storage/indexeddb/intversion-close-between-events.html flaky in content_shell
Modified: trunk/LayoutTests/platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt (138404 => 138405)
--- trunk/LayoutTests/platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt 2012-12-22 00:24:18 UTC (rev 138404)
+++ trunk/LayoutTests/platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt 2012-12-22 01:06:25 UTC (rev 138405)
@@ -1,13 +1,12 @@
-This test checks that markers are correct when auto correcting in the blockquote. If you type "n" and " ", there should be blue dots under the word: "information". This test also makes sure that the replacement does not cause breaking out of blockquotes.
-Note, this test can fail due to user specific spell checking data. If the user has previously dismissed 'information' as the correct spelling of 'infomation' several times, the spell checker will not provide 'information' as a suggestion anymore. To fix this, remove all files in ~/Library/Spelling. and kill AppleSpell.service
+This test checks that markers are correct when auto correcting in the blockquote. If you type "l" and " ", there should be blue dots under the word: "notational". This test also makes sure that the replacement does not cause breaking out of blockquotes.
-PASS internals.hasAutocorrectedMarker(document, 5, 11) is true
+PASS internals.hasAutocorrectedMarker(document, 5, 10) is true
PASS successfullyParsed is true
TEST COMPLETE
would this
-test information
+test notational
make a difference?
Modified: trunk/LayoutTests/platform/mac/editing/spelling/autocorrection-blockquote-crash.html (138404 => 138405)
--- trunk/LayoutTests/platform/mac/editing/spelling/autocorrection-blockquote-crash.html 2012-12-22 00:24:18 UTC (rev 138404)
+++ trunk/LayoutTests/platform/mac/editing/spelling/autocorrection-blockquote-crash.html 2012-12-22 01:06:25 UTC (rev 138405)
@@ -4,7 +4,7 @@
<script src=""
</head>
<body>
- <p id="description">This test checks that markers are correct when auto correcting in the blockquote. If you type "n" and " ", there should be blue dots under the word: "information". This test also makes sure that the replacement does not cause breaking out of blockquotes. <br> Note, this test can fail due to user specific spell checking data. If the user has previously dismissed 'information' as the correct spelling of 'infomation' several times, the spell checker will not provide 'information' as a suggestion anymore. To fix this, remove all files in ~/Library/Spelling. and kill AppleSpell.service</p>
+ <p id="description">This test checks that markers are correct when auto correcting in the blockquote. If you type "l" and " ", there should be blue dots under the word: "notational". This test also makes sure that the replacement does not cause breaking out of blockquotes.</p>
<div id="console"></div>
<div id = "test" contentEditable="true" spellCheck="true"><blockquote type="cite"><font style = "font-family:Arial"><br> would this <b id = "bold"><br></b><b><br></b>make a difference?<span><br></span><span><br></span></font></blockquote></div>
@@ -12,12 +12,12 @@
<script language="_javascript_">
// Insert some text with a typographical error in it, so autocorrection occurs.
window.getSelection().setPosition(document.getElementById("bold"), 1);
- document.execCommand("InsertText", false, "test infomatio");
- eventSender.keyDown('n');
+ document.execCommand("InsertText", false, "test notation");
+ eventSender.keyDown('l');
eventSender.keyDown(' ');
if(window.internals)
- shouldBeTrue('internals.hasAutocorrectedMarker(document, 5, 11)');
+ shouldBeTrue('internals.hasAutocorrectedMarker(document, 5, 10)');
</script>
<script src=""
</body>
Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (138404 => 138405)
--- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2012-12-22 00:24:18 UTC (rev 138404)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2012-12-22 01:06:25 UTC (rev 138405)
@@ -163,6 +163,9 @@
svg/custom/foreignObject-crash-on-hover.xml
svg/custom/use-events-crash.svg
+# [WK2] [Mac] Spellcheck tests don't seem to work
+webkit.org/b/105616 platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html [ Failure ]
+
# [WK2] [Mac] Support drag in mouse events for WebKit2 EventSender
# <https://bugs.webkit.org/show_bug.cgi?id=68552>
editing/pasteboard/drag-drop-iframe-refresh-crash.html
Modified: trunk/Tools/ChangeLog (138404 => 138405)
--- trunk/Tools/ChangeLog 2012-12-22 00:24:18 UTC (rev 138404)
+++ trunk/Tools/ChangeLog 2012-12-22 01:06:25 UTC (rev 138405)
@@ -1,3 +1,20 @@
+2012-12-21 Ryosuke Niwa <[email protected]>
+
+ [Mountain Lion] platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html failing
+ https://bugs.webkit.org/show_bug.cgi?id=95477
+
+ Reviewed by Sam Weinig.
+
+ Co-authored by Jia Pu.
+
+ Specify a fixed autocorrection dictionary in resetDefaultsToConsistentValues() so that
+ we can have consistent autocorrection behavior when running tests.
+
+ * DumpRenderTree/mac/DumpRenderTree.mm:
+ (resetDefaultsToConsistentValues):
+ * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
+ (WTR::InjectedBundle::platformInitialize):
+
2012-12-21 Zan Dobersek <[email protected]>
[GTK] Add WebKit1-specific TestExpectations file
Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (138404 => 138405)
--- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2012-12-22 00:24:18 UTC (rev 138404)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2012-12-22 01:06:25 UTC (rev 138405)
@@ -587,6 +587,10 @@
[defaults setBool:YES forKey:WebKitFullScreenEnabledPreferenceKey];
[defaults setBool:YES forKey:@"UseWebKitWebInspector"];
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1070
+ [defaults setObject:[NSDictionary dictionaryWithObjectsAndKeys:@"notational", @"notationl", nil] forKey:@"NSTestCorrectionDictionary"];
+#endif
+
// Scrollbars are drawn either using AppKit (which uses NSUserDefaults) or using HIToolbox (which uses CFPreferences / kCFPreferencesAnyApplication / kCFPreferencesCurrentUser / kCFPreferencesAnyHost)
[defaults setObject:@"DoubleMax" forKey:@"AppleScrollBarVariant"];
RetainPtr<CFTypeRef> initialValue = CFPreferencesCopyValue(CFSTR("AppleScrollBarVariant"), kCFPreferencesAnyApplication, kCFPreferencesCurrentUser, kCFPreferencesAnyHost);
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm (138404 => 138405)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm 2012-12-22 00:24:18 UTC (rev 138404)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm 2012-12-22 01:06:25 UTC (rev 138405)
@@ -47,6 +47,9 @@
[NSNumber numberWithBool:NO], @"NSOverlayScrollersEnabled",
@"Always", @"AppleShowScrollBars",
[NSArray arrayWithObject:@"en"], @"AppleLanguages",
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1070
+ [NSDictionary dictionaryWithObjectsAndKeys:@"notational", @"notationl", nil], @"NSTestCorrectionDictionary",
+#endif
nil];
[[NSUserDefaults standardUserDefaults] setVolatileDomain:dict forName:NSArgumentDomain];
