Title: [138412] trunk/Source/WebCore
- Revision
- 138412
- Author
- [email protected]
- Date
- 2012-12-22 15:14:57 -0800 (Sat, 22 Dec 2012)
Log Message
InlineTextBox: Remove potentially confusing "} if" pattern.
https://bugs.webkit.org/show_bug.cgi?id=105499
Reviewed by Ojan Vafai.
It's not clear to me on first look if this is intentional or missing
an "else" (and this pattern was used in just one other place in
webkit, which I've removed). It turns out no else is missing here,
this is checked by fast/text/justified-selection.html
* rendering/InlineTextBox.cpp:
(WebCore::paintTextWithShadows):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (138411 => 138412)
--- trunk/Source/WebCore/ChangeLog 2012-12-22 08:00:56 UTC (rev 138411)
+++ trunk/Source/WebCore/ChangeLog 2012-12-22 23:14:57 UTC (rev 138412)
@@ -1,3 +1,18 @@
+2012-12-22 Nico Weber <[email protected]>
+
+ InlineTextBox: Remove potentially confusing "} if" pattern.
+ https://bugs.webkit.org/show_bug.cgi?id=105499
+
+ Reviewed by Ojan Vafai.
+
+ It's not clear to me on first look if this is intentional or missing
+ an "else" (and this pattern was used in just one other place in
+ webkit, which I've removed). It turns out no else is missing here,
+ this is checked by fast/text/justified-selection.html
+
+ * rendering/InlineTextBox.cpp:
+ (WebCore::paintTextWithShadows):
+
2012-12-21 Jan Keromnes <[email protected]>
Web Inspector: Update CodeMirror to stable
Modified: trunk/Source/WebCore/rendering/InlineTextBox.cpp (138411 => 138412)
--- trunk/Source/WebCore/rendering/InlineTextBox.cpp 2012-12-22 08:00:56 UTC (rev 138411)
+++ trunk/Source/WebCore/rendering/InlineTextBox.cpp 2012-12-22 23:14:57 UTC (rev 138412)
@@ -429,7 +429,8 @@
context->drawText(font, textRun, textOrigin + extraOffset, 0, endOffset);
else
context->drawEmphasisMarks(font, textRun, emphasisMark, textOrigin + extraOffset + IntSize(0, emphasisMarkOffset), 0, endOffset);
- } if (startOffset < truncationPoint) {
+ }
+ if (startOffset < truncationPoint) {
if (emphasisMark.isEmpty())
context->drawText(font, textRun, textOrigin + extraOffset, startOffset, truncationPoint);
else
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
