Title: [138440] trunk/Tools
- Revision
- 138440
- Author
- [email protected]
- Date
- 2012-12-24 04:56:26 -0800 (Mon, 24 Dec 2012)
Log Message
[BlackBerry] DRT - Crashed when running pixels tests
https://bugs.webkit.org/show_bug.cgi?id=105711
RIM PR 270003
Patch by Xiaobo Wang <[email protected]> on 2012-12-24
Reviewed by George Staikos.
Calling window->post() here will result in buffer swapping which is
only allowed in UI thread now, and I found we don't need to call it
for GL renderer.
* DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
(createBitmapContextFromWebView):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (138439 => 138440)
--- trunk/Tools/ChangeLog 2012-12-24 12:37:25 UTC (rev 138439)
+++ trunk/Tools/ChangeLog 2012-12-24 12:56:26 UTC (rev 138440)
@@ -1,3 +1,19 @@
+2012-12-24 Xiaobo Wang <[email protected]>
+
+ [BlackBerry] DRT - Crashed when running pixels tests
+ https://bugs.webkit.org/show_bug.cgi?id=105711
+
+ RIM PR 270003
+
+ Reviewed by George Staikos.
+
+ Calling window->post() here will result in buffer swapping which is
+ only allowed in UI thread now, and I found we don't need to call it
+ for GL renderer.
+
+ * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
+ (createBitmapContextFromWebView):
+
2012-12-22 Dan Winship <[email protected]>
Add a patch to fix libxml2 2.9.0 regression
Modified: trunk/Tools/DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp (138439 => 138440)
--- trunk/Tools/DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp 2012-12-24 12:37:25 UTC (rev 138439)
+++ trunk/Tools/DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp 2012-12-24 12:56:26 UTC (rev 138440)
@@ -62,11 +62,11 @@
const Platform::IntSize& windowSize = window->viewportSize();
unsigned char* data = "" unsigned char[windowSize.width() * windowSize.height() * 4];
+#if USE(SKIA)
// We need to force a synchronous update to the window or we may get an empty bitmap.
// For example, running DRT with one test case that finishes before the screen is updated.
window->post(windowRect);
-#if USE(SKIA)
SkBitmap bitmap;
bitmap.setConfig(SkBitmap::kARGB_8888_Config, windowSize.width(), windowSize.height());
bitmap.allocPixels();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
