Title: [138453] trunk/Source/WebCore
- Revision
- 138453
- Author
- [email protected]
- Date
- 2012-12-24 23:26:03 -0800 (Mon, 24 Dec 2012)
Log Message
Web Inspector: add message listener only in case of standalone test-runner.html
https://bugs.webkit.org/show_bug.cgi?id=105715
Reviewed by Pavel Feldman.
Tell InspectorFrontendAPI that it is launched by standalone test runner so that it
can decide whether message event listener should be added.
* inspector/front-end/InspectorFrontendAPI.js:
* inspector/front-end/test-runner.html:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (138452 => 138453)
--- trunk/Source/WebCore/ChangeLog 2012-12-25 07:01:51 UTC (rev 138452)
+++ trunk/Source/WebCore/ChangeLog 2012-12-25 07:26:03 UTC (rev 138453)
@@ -1,3 +1,16 @@
+2012-12-24 Yury Semikhatsky <[email protected]>
+
+ Web Inspector: add message listener only in case of standalone test-runner.html
+ https://bugs.webkit.org/show_bug.cgi?id=105715
+
+ Reviewed by Pavel Feldman.
+
+ Tell InspectorFrontendAPI that it is launched by standalone test runner so that it
+ can decide whether message event listener should be added.
+
+ * inspector/front-end/InspectorFrontendAPI.js:
+ * inspector/front-end/test-runner.html:
+
2012-12-24 Ilya Tikhonovsky <[email protected]>
Web Inspector: Native Memory Instrumentation: propagate member type as edge type to the serialized heap graph.
Modified: trunk/Source/WebCore/inspector/front-end/InspectorFrontendAPI.js (138452 => 138453)
--- trunk/Source/WebCore/inspector/front-end/InspectorFrontendAPI.js 2012-12-25 07:01:51 UTC (rev 138452)
+++ trunk/Source/WebCore/inspector/front-end/InspectorFrontendAPI.js 2012-12-25 07:26:03 UTC (rev 138453)
@@ -184,7 +184,7 @@
}
}
-if (window.opener) {
+if (window.opener && window.dispatchStandaloneTestRunnerMessages) {
function onMessageFromOpener(event)
{
if (event.source === window.opener)
Modified: trunk/Source/WebCore/inspector/front-end/test-runner.html (138452 => 138453)
--- trunk/Source/WebCore/inspector/front-end/test-runner.html 2012-12-25 07:01:51 UTC (rev 138452)
+++ trunk/Source/WebCore/inspector/front-end/test-runner.html 2012-12-25 07:26:03 UTC (rev 138453)
@@ -176,6 +176,7 @@
var height = localStorage.getItem('inspectorHeight') || 400;
var features = "width=" + Math.max(width , 600) + ",height=" + Math.max(height, 400);
this._inspectorWindowLoading = window.open(StandaloneTestRunner.FrontendLocation + "?" + this._debuggerURL, "inspector", features);
+ this._inspectorWindowLoading.dispatchStandaloneTestRunnerMessages = true;
window.addEventListener('unload', this.cleanup.bind(this));
@@ -345,7 +346,7 @@
<ul>
<li>Check out WebKit source tree: git clone http://git.chromium.org/external/Webkit.git</li>
<li>Run "Tools/Scripts/new-run-webkit-httpd --root=. --port=8002 --server=start"</li>
-<li>Run Chrome Canary (ToT Chromium) with following flags: "--remote-debugging-port=9222 --user-data-dir=testProfile http://localhost:8002/Source/WebCore/inspector/front-end/test-runner.html</li>
+<li>Run Chrome Canary (ToT Chromium) with following flags: "--remote-debugging-port=9222 --user-data-dir=testProfile http://localhost:8002/Source/WebCore/inspector/front-end/test-runner.html"</li>
</ul>
<button _onclick_="run()">Run</button>
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
