Title: [138473] trunk/Source/WebCore
- Revision
- 138473
- Author
- [email protected]
- Date
- 2012-12-26 01:56:09 -0800 (Wed, 26 Dec 2012)
Log Message
[Web Inspector]Remove Preview and Response tab from network panel in case websocket.
https://bugs.webkit.org/show_bug.cgi?id=105754
Patch by Pan Deng <[email protected]> on 2012-12-26
Reviewed by Pavel Feldman.
Network item views for websocket is not consistent before/after receiving a frame.
This change keeps Headers, Frames and Cookies tab for websocket.
No new tests.
* inspector/front-end/NetworkItemView.js:
(WebInspector.NetworkItemView):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (138472 => 138473)
--- trunk/Source/WebCore/ChangeLog 2012-12-26 07:24:45 UTC (rev 138472)
+++ trunk/Source/WebCore/ChangeLog 2012-12-26 09:56:09 UTC (rev 138473)
@@ -1,3 +1,18 @@
+2012-12-26 Pan Deng <[email protected]>
+
+ [Web Inspector]Remove Preview and Response tab from network panel in case websocket.
+ https://bugs.webkit.org/show_bug.cgi?id=105754
+
+ Reviewed by Pavel Feldman.
+
+ Network item views for websocket is not consistent before/after receiving a frame.
+ This change keeps Headers, Frames and Cookies tab for websocket.
+
+ No new tests.
+
+ * inspector/front-end/NetworkItemView.js:
+ (WebInspector.NetworkItemView):
+
2012-12-25 John Griggs <[email protected]>
[BlackBerry] Media controls are drawn on top of one another for media with unknown duration.
Modified: trunk/Source/WebCore/inspector/front-end/NetworkItemView.js (138472 => 138473)
--- trunk/Source/WebCore/inspector/front-end/NetworkItemView.js 2012-12-26 07:24:45 UTC (rev 138472)
+++ trunk/Source/WebCore/inspector/front-end/NetworkItemView.js 2012-12-26 09:56:09 UTC (rev 138473)
@@ -43,17 +43,16 @@
this.addEventListener(WebInspector.TabbedPane.EventTypes.TabSelected, this._tabSelected, this);
- if (request.frames().length > 0) {
+ if (request.type === WebInspector.resourceTypes.WebSocket) {
var frameView = new WebInspector.ResourceWebSocketFrameView(request);
this.appendTab("webSocketFrames", WebInspector.UIString("Frames"), frameView);
- return;
+ } else {
+ var responseView = new WebInspector.RequestResponseView(request);
+ var previewView = new WebInspector.RequestPreviewView(request, responseView);
+ this.appendTab("preview", WebInspector.UIString("Preview"), previewView);
+ this.appendTab("response", WebInspector.UIString("Response"), responseView);
}
- var responseView = new WebInspector.RequestResponseView(request);
- var previewView = new WebInspector.RequestPreviewView(request, responseView);
- this.appendTab("preview", WebInspector.UIString("Preview"), previewView);
- this.appendTab("response", WebInspector.UIString("Response"), responseView);
-
if (request.requestCookies || request.responseCookies) {
this._cookiesView = new WebInspector.RequestCookiesView(request);
this.appendTab("cookies", WebInspector.UIString("Cookies"), this._cookiesView);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
