Title: [138478] trunk/Source/WebKit/blackberry
- Revision
- 138478
- Author
- [email protected]
- Date
- 2012-12-26 09:00:32 -0800 (Wed, 26 Dec 2012)
Log Message
[BlackBerry] Caret doesn't update position when scrolling text in Input element
https://bugs.webkit.org/show_bug.cgi?id=105757
Patch by Sean Wang <[email protected]> on 2012-12-26
Reviewed by George Staikos.
PR 271627
Internally reviewed by George Staikos.
Call FrameSelection's updateAppearence instead of SelectionHandler's
selectionPositionChanged to update the caret position.
* Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScrollerPrivate::setLayerScrollPosition):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/Api/InRegionScroller.cpp (138477 => 138478)
--- trunk/Source/WebKit/blackberry/Api/InRegionScroller.cpp 2012-12-26 15:54:42 UTC (rev 138477)
+++ trunk/Source/WebKit/blackberry/Api/InRegionScroller.cpp 2012-12-26 17:00:32 UTC (rev 138478)
@@ -314,7 +314,7 @@
layer->scrollToOffset(toSize(scrollPosition));
}
- m_webPage->m_selectionHandler->selectionPositionChanged();
+ layer->renderer()->frame()->selection()->updateAppearance();
// FIXME: We have code in place to handle scrolling and clipping tap highlight
// on in-region scrolling. As soon as it is fast enough (i.e. we have it backed by
// a backing store), we can reliably make use of it in the real world.
Modified: trunk/Source/WebKit/blackberry/ChangeLog (138477 => 138478)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-12-26 15:54:42 UTC (rev 138477)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-12-26 17:00:32 UTC (rev 138478)
@@ -1,3 +1,19 @@
+2012-12-26 Sean Wang <[email protected]>
+
+ [BlackBerry] Caret doesn't update position when scrolling text in Input element
+ https://bugs.webkit.org/show_bug.cgi?id=105757
+
+ Reviewed by George Staikos.
+
+ PR 271627
+ Internally reviewed by George Staikos.
+
+ Call FrameSelection's updateAppearence instead of SelectionHandler's
+ selectionPositionChanged to update the caret position.
+
+ * Api/InRegionScroller.cpp:
+ (BlackBerry::WebKit::InRegionScrollerPrivate::setLayerScrollPosition):
+
2012-12-25 Charles Wei <[email protected]>
[BlackBerry] Need to initialize the onLine in the global
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
