Title: [138539] trunk/Source/WebKit/blackberry
- Revision
- 138539
- Author
- [email protected]
- Date
- 2012-12-28 08:49:39 -0800 (Fri, 28 Dec 2012)
Log Message
[BlackBerry] Remove unused BackingStorePrivate::m_defersBlit
https://bugs.webkit.org/show_bug.cgi?id=105811
RIM PR 272067
Reviewed by George Staikos.
Internally Reviewed by Jakob Petsovits.
BackingStorePrivate::m_defersBlit is not used anywhere, it should
be removed to simplify the code and to avoid confusion.
* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
* Api/BackingStore.h:
* Api/BackingStore_p.h:
(BackingStorePrivate):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/Api/BackingStore.cpp (138538 => 138539)
--- trunk/Source/WebKit/blackberry/Api/BackingStore.cpp 2012-12-28 16:36:00 UTC (rev 138538)
+++ trunk/Source/WebKit/blackberry/Api/BackingStore.cpp 2012-12-28 16:49:39 UTC (rev 138539)
@@ -213,7 +213,6 @@
, m_webPage(0)
, m_client(0)
, m_renderQueue(adoptPtr(new RenderQueue(this)))
- , m_defersBlit(true)
, m_hasBlitJobs(false)
, m_webPageBackgroundColor(WebCore::Color::white)
, m_currentWindowBackBuffer(0)
@@ -1235,7 +1234,7 @@
return;
}
- if (m_defersBlit && !force) {
+ if (!force) {
#if USE(ACCELERATED_COMPOSITING)
// If there's a WebPageCompositorClient, let it schedule the blit.
if (WebPageCompositorPrivate* compositor = m_webPage->d->compositor()) {
@@ -2470,16 +2469,6 @@
SurfacePool::globalSurfacePool()->releaseBuffers();
}
-bool BackingStore::defersBlit() const
-{
- return d->m_defersBlit;
-}
-
-void BackingStore::setDefersBlit(bool b)
-{
- d->m_defersBlit = b;
-}
-
bool BackingStore::hasBlitJobs() const
{
#if USE(ACCELERATED_COMPOSITING)
Modified: trunk/Source/WebKit/blackberry/Api/BackingStore.h (138538 => 138539)
--- trunk/Source/WebKit/blackberry/Api/BackingStore.h 2012-12-28 16:36:00 UTC (rev 138538)
+++ trunk/Source/WebKit/blackberry/Api/BackingStore.h 2012-12-28 16:49:39 UTC (rev 138539)
@@ -66,11 +66,6 @@
void blitVisibleContents();
void repaint(int x, int y, int width, int height, bool contentChanged, bool immediate);
- // In the defers blit mode, any blit requests will just return early, and
- // a blit job will be queued that is executed by calling blitOnIdle().
- bool defersBlit() const;
- void setDefersBlit(bool);
-
bool hasBlitJobs() const;
void blitOnIdle();
Modified: trunk/Source/WebKit/blackberry/Api/BackingStore_p.h (138538 => 138539)
--- trunk/Source/WebKit/blackberry/Api/BackingStore_p.h 2012-12-28 16:36:00 UTC (rev 138538)
+++ trunk/Source/WebKit/blackberry/Api/BackingStore_p.h 2012-12-28 16:49:39 UTC (rev 138539)
@@ -355,7 +355,6 @@
OwnPtr<RenderQueue> m_renderQueue;
mutable Platform::IntSize m_previousDelta;
- bool m_defersBlit;
bool m_hasBlitJobs;
WebCore::Color m_webPageBackgroundColor; // for user interface thread operations such as blitting
Modified: trunk/Source/WebKit/blackberry/ChangeLog (138538 => 138539)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-12-28 16:36:00 UTC (rev 138538)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-12-28 16:49:39 UTC (rev 138539)
@@ -1,3 +1,21 @@
+2012-12-28 Charles Wei <[email protected]>
+
+ [BlackBerry] Remove unused BackingStorePrivate::m_defersBlit
+ https://bugs.webkit.org/show_bug.cgi?id=105811
+ RIM PR 272067
+
+ Reviewed by George Staikos.
+ Internally Reviewed by Jakob Petsovits.
+
+ BackingStorePrivate::m_defersBlit is not used anywhere, it should
+ be removed to simplify the code and to avoid confusion.
+ * Api/BackingStore.cpp:
+ (BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
+ (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
+ * Api/BackingStore.h:
+ * Api/BackingStore_p.h:
+ (BackingStorePrivate):
+
2012-12-26 Jakob Petsovits <[email protected]>
[BlackBerry] Set load state for popups manually, in absence of a loader.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
