Title: [138564] trunk/Source/WebCore
- Revision
- 138564
- Author
- [email protected]
- Date
- 2012-12-29 04:41:05 -0800 (Sat, 29 Dec 2012)
Log Message
Web Inspector: [Timeline] cpu bar popover shows wrong duration / cpu time.
https://bugs.webkit.org/show_bug.cgi?id=105854
Patch by Eugene Klyuchnikov <[email protected]> on 2012-12-29
Reviewed by Vsevolod Vlasov.
Problem: CPU task indexes are already incremented before written to
data structure.
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._refreshMainThreadBars):
Use for loop to get correct indexes.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (138563 => 138564)
--- trunk/Source/WebCore/ChangeLog 2012-12-29 11:38:05 UTC (rev 138563)
+++ trunk/Source/WebCore/ChangeLog 2012-12-29 12:41:05 UTC (rev 138564)
@@ -1,3 +1,17 @@
+2012-12-29 Eugene Klyuchnikov <[email protected]>
+
+ Web Inspector: [Timeline] cpu bar popover shows wrong duration / cpu time.
+ https://bugs.webkit.org/show_bug.cgi?id=105854
+
+ Reviewed by Vsevolod Vlasov.
+
+ Problem: CPU task indexes are already incremented before written to
+ data structure.
+
+ * inspector/front-end/TimelinePanel.js:
+ (WebInspector.TimelinePanel.prototype._refreshMainThreadBars):
+ Use for loop to get correct indexes.
+
2012-12-28 Ilya Tikhonovsky <[email protected]>
Web Inspector: Native Memory Instrumentation: instrument not instrumented members.
Modified: trunk/Source/WebCore/inspector/front-end/TimelinePanel.js (138563 => 138564)
--- trunk/Source/WebCore/inspector/front-end/TimelinePanel.js 2012-12-29 11:38:05 UTC (rev 138563)
+++ trunk/Source/WebCore/inspector/front-end/TimelinePanel.js 2012-12-29 12:41:05 UTC (rev 138564)
@@ -939,11 +939,10 @@
var lastLeft;
var lastRight;
- while (taskIndex < tasks.length) {
+ for (; taskIndex < tasks.length; ++taskIndex) {
var task = tasks[taskIndex];
if (task.startTime > endTime)
break;
- taskIndex++;
var left = Math.max(0, this._calculator.computePosition(task.startTime) + barOffset - widthAdjustment);
var right = Math.min(width, this._calculator.computePosition(task.endTime) + barOffset + widthAdjustment);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
